Closed Bug 612486 Opened 14 years ago Closed 14 years ago

Change Panorama key to something besides CTRL+E

Categories

(Firefox Graveyard :: Panorama, defect)

Product:
Firefox Graveyard
Component:
Panorama
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 624588

People

(Reporter: johnh30024, Unassigned)

Details

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US) AppleWebKit/534.10 (KHTML, like Gecko) Chrome/8.0.552.200 Safari/534.10
Build Identifier: 

Per https://bugzilla.mozilla.org/show_bug.cgi?id=592183#c81

https://bugzilla.mozilla.org/show_bug.cgi?id=592183#c30
A comment here suggested that the hijacking of the CTRL+E shortcut to the new panaroma shortcut was partly because other platforms used CTRL+K for search in "other platforms". 

http://support.microsoft.com/kb/306832
IE has historically used CTRL+E for search.

http://help.opera.com/Linux/10.60/en/keyboard.html
http://help.opera.com/Windows/10.60/en/keyboard.html
http://help.opera.com/Mac/10.60/en/keyboard.html

http://www.google.com/support/chrome/bin/static.py?page=guide.cs&guide=25799&topic=28650

Opera for all platforms exclusively uses CTRL/CMD+E. Chrome for Windows/Linux uses CTRL+E (though it does include CTRL+K for Firefox switchers). There seems to be a big precedent for CTRL+E for search.

In a world where not all sites work with Firefox, I've learned to use CTRL+E so that I don't have to waste time learning various browser nuances between IE and Firefox. It certainly doesn't make sense to me that a core browser function (search) got thrown under the bus for a feature that heavy tab users with good computers might enjoy.

Reproducible: Always

Steps to Reproduce:
1. Hit CTRL+E
2.
3.
Actual Results:  
My computer slowly convulses and displays some ugly thumbnails.

Expected Results:  
Go to the search bar.
I see your bug was filed as a suggestion from commenting bug 592183. Even if we were to remain with the ctrl+e, I am setting this to NEW, perhaps others will give votes and make suggestions.
Status: UNCONFIRMED → NEW
Ever confirmed: true
I propose ctrl+g. Right now it's the same as ctrl+f. 

Rationale:
+ Can be pressed with one hand
+ Is a mnemonic (sort of) for Group tabs
+ It's not near any highly inconvenient shortcuts (like ctrl+w :| )
Makes sense, since for example, CTRL+V pastes repeatedly without a special "paste again" shortcut.
Whiteboard: Bob BennettBob BennettBob Bennett
(In reply to comment #3)
> Makes sense, since for example, CTRL+V pastes repeatedly without a special
> "paste again" shortcut.

What does ctrl+v have to do with this?
Also, the whiteboard is viewable to everyone. Not sure who 'bob bennett' is.
I don't know how that got there... I meant to parallel how repeatedly pressing ctrl+v repeatedly pastes, and how ctrl+f repeatedly finds, making ctrl+g more replaceable than ctrl+e.
Whiteboard: Bob BennettBob BennettBob Bennett
It seems Ctrl+Q/Ctrl+M are not used on Windows platform. I know Ctrl+Q is used on Linux and Mac, but what about Ctrl+M?
If it is limited to Ctrl + <letter>, there are several possibilities I seen:

Ctrl+D: Display your groups (Bookmark This Page goes to Ctrl+I)
Ctrl+G: Group your tabs (Ctrl+F calls Find/Find Again accordingly)
Ctrl+J: (Downloads goes to Ctrl+Shift+D)
Ctrl+P: Panorama (retire Print)
Ctrl+M: Manage your groups (least used one)
Ctrl+Backspace: Back to your groups
So far Panorama is used by quite few people and it's used less often, so the shortcut key should not be touched too easily. In fact, it's quite annoying to mis-trigger it. Ctrl+P or Ctrl+M may be the best choice.
Ctrl+P is (nearly) universally print in Windows, so that won't work 
Ctrl+D is also a bad choice as it's bookmark in most browsers
Ctrl+M would work, but I feel that the combo should be easy to hit with one hand, preferably the left hand.
Why?
1. Most shortcuts are left handed (for right handed mouse users)
2. The next thing a user will (likely) do after hitting the shortcut is use the mouse to select/arrange tabs. It would be easier if they didn't have to move from keyboard to mouse to do this.
Yes, most shortcuts are left handed, but right handed shortcuts are also used. Panorama has few users. Even used, it's not necessary to open it often. And it's a time work to organize the tabs. So IMO moving from keyboard to mouse is acceptable, just like what you do after pressing Print shortcut.
...currently ctrl+f does not find again for me, and so would not replace the functionality of ctrl+g.  Tested in 4.0b8 and 4.0b9 in Windows.

Ctrl+e is driving me up a wall!  I've now trained myself to prefer ctrl+k for the search bar, but I'm not aware of an alternative to ctrl+shift+r for a hard refresh.  And ctrl+e is absolutely hemmed in by oft-used keys.
Ctrl+E is a near universal hotkey for moving to the search box.  It is mapped to this in:

- Firefox 3
- Internet Explorer
- Opera
- Google Chrome
- Safari
- Windows Shell / File Explorer (Vista and 7)

Ctrl+E should be restored to move the cursor to the search box, since for many applications and people, it has become the de facto "move me to the search box" hotkey.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
(In reply to comment #13)
> 
> *** This bug has been marked as a duplicate of bug 624588 ***

https://bugzilla.mozilla.org/show_bug.cgi?id=592183#c81
I find marking this as a duplicate highly inappropriate.
(In reply to comment #14)
> (In reply to comment #13)
> > 
> > *** This bug has been marked as a duplicate of bug 624588 ***
> 
> https://bugzilla.mozilla.org/show_bug.cgi?id=592183#c81
> I find marking this as a duplicate highly inappropriate.

I'm not sure that I understand why this move was appropriate. In that comment I recommended that, if one would like to see a change, they make a concrete suggestion. Bug 624588 was a concrete suggestion, "change it to shift-ctrl-E", and thus it was acted on.
> I'm not sure that I understand why this move was appropriate.

Whoah, bad typo. :( I meant "I'm not sure that I understand why this move was *in*appropriate". Sorry for the confusion.
This is a concrete suggestion, to NOT be ctrl+e, after the time that ctrl+e was implemented. It's like saying "make a concrete suggestion" and following it up with "But we've already changed it to the thing you specifically don't want, resolved"
The currently committed hotkey for Panorama is Shift+Ctrl+E <http://hg.mozilla.org/mozilla-central/rev/993dea936b18>.  The hotkey Shift+Ctrl+E is NOT the same as Ctrl+E.  This item is asking for a non-Ctrl+E hotkey.  Thus it seems like this issue (612486) has been resolved satisfactorily.  Am I missing something?
...yes, the current key for Panorama/TabCandy is CTRL-E.  At least it has been for the last few builds and currently is for 4.0b10pre (2011-01-16) that I'm running.  CTRL-SHIFT-E doesn't appear to be committed to anything, but it is used by several plugins.
The change to CTRL-SHIFT-E was committed on 2011-01-16, so perhaps the change did not make it into the 2011-01-16 4.0b10pre build.  After all, there are a whole 24 hours in a day, and some of those hours come later than others. :-)

For me 2011-01-_17_ 4.0b10pre maps CTRL-SHIFT-E to panorama, and CTRL-E does not do anything at all.  This behavior is in line with what can be seen in the currently committed source code (http://hg.mozilla.org/mozilla-central/file/993dea936b18/browser/base/content/browser-sets.inc e.g. line 305 and others.)
Oh, I'm terribly embarrassed now... I wasn't running the latest version, so I still had ctrl+e. Sorry all.
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.