Closed Bug 613795 Opened 11 years ago Closed 11 years ago

Add a possibility to Data Manager to only list domains of a certain data type

Categories

(SeaMonkey :: Passwords & Permissions, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1b2

People

(Reporter: kairo, Assigned: kairo)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 4 obsolete files)

In order for making it easier to find all your passwords or permissions, etc. in Data Manager, it would be good to have a way to only list domains that have this data type available.
This also will enable us elegantly to e.g. replace calls to "View Cookies" (that opens Cookie Manager right now) with a call to Data Manager with only cookie domains listed.
I have a patch working locally for the add-on already.
Here's a patch for the SeaMonkey version to allow selecting data types - including an option for loading this as a "view" on Data Manager launch.
Attachment #492118 - Flags: review?(iann_bugzilla)
While developing for the next steps, I realized that we need to make sure calls to all-type views still work when Data Manager is already open and a specific data type selected. This new patch fixes that and adds a test for this case.
Attachment #492118 - Attachment is obsolete: true
Attachment #493466 - Flags: review?(iann_bugzilla)
Attachment #492118 - Flags: review?(iann_bugzilla)
Sorry for yet another iteration, but I found it's more correct to switch to listing all domains _before_ walking the displayed domains array in search of a domain, so I tweaked the view loading code again slightly.
Attachment #493466 - Attachment is obsolete: true
Attachment #493473 - Flags: review?(iann_bugzilla)
Attachment #493466 - Flags: review?(iann_bugzilla)
This patch switches the separator for view calls to |, see bug 588418.
Attachment #493473 - Attachment is obsolete: true
Attachment #493543 - Flags: review?(iann_bugzilla)
Attachment #493473 - Flags: review?(iann_bugzilla)
Blocks: 588417
In bug 588418, I added a few more test cases and that would have needed changes here anyhow, so I switched to a somewhat saner testing infrastructure as well (at first, I hadn't expected that this one would cover that many cases). This patch only contains updates for those changes.
Attachment #493543 - Attachment is obsolete: true
Attachment #496217 - Flags: review?(iann_bugzilla)
Attachment #493543 - Flags: review?(iann_bugzilla)
Comment on attachment 496217 [details] [diff] [review]
v1.4: adjust to changed test

r=me
Attachment #496217 - Flags: review?(iann_bugzilla) → review+
Pushed as http://hg.mozilla.org/comm-central/rev/35e9872fd19f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b2
Blocks: 666102
You need to log in before you can comment on or make changes to this bug.