Switch SeaMonkey UI to open Data Manager instead of other windows

RESOLVED FIXED in seamonkey2.1b2

Status

SeaMonkey
Passwords & Permissions
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Robert Kaiser, Assigned: Robert Kaiser)

Tracking

(Depends on: 1 bug, Blocks: 2 bugs)

Trunk
seamonkey2.1b2
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
We have a number of UI elements, e.g. in Page Info or Preferences windows, that currently open the separate windows for managing data. Those should be switched over to open Data Manager instead.
(Assignee)

Updated

7 years ago
Blocks: 588421

Updated

7 years ago
Blocks: 599097
(Assignee)

Comment 1

7 years ago
Created attachment 492089 [details] [diff] [review]
part1, v1: page info

This patch switches page info to use the new functionality added in bug 588418 for calling the page/domain's cookie and password lists.

I also added code to only activate those buttons when actual cookies or passwords are available, as else this would open the Data Manager to the default (form data list) which doesn't really fit here.
Assignee: nobody → kairo
Status: NEW → ASSIGNED
Attachment #492089 - Flags: review?(iann_bugzilla)
(Assignee)

Updated

7 years ago
Depends on: 613795
(Assignee)

Comment 2

7 years ago
Created attachment 493545 [details] [diff] [review]
v1: full patch for all hooks

This patch does all hooks, and uses with the new syntax from bug 588418.

Conveniently, we can remove permissionsOverlay.js completely, and the inclusion of utilityOverlay.js in preferences.xul makes the broken "Add-ons Manager" button in the software installation panel work again as well.

I think that permissionsNavigatorOverlay should be cleaned up or even merged into the main navigator files, and we might want to restructure the menu items of it in a way to make them more streamlined and reduce redundancy with the Data Manager menu item, but I think all that can go into yet another bug.
Attachment #492089 - Attachment is obsolete: true
Attachment #493545 - Flags: review?(iann_bugzilla)
Attachment #492089 - Flags: review?(iann_bugzilla)
(Assignee)

Comment 3

7 years ago
permissionsOverlay.js in imageContextOverlay.xul can be removed as well, of course, apparently it isn't actually used in there anyhow.

Updated

7 years ago
Blocks: 619098

Comment 4

7 years ago
Comment on attachment 493545 [details] [diff] [review]
v1: full patch for all hooks

r=me followup spun off to Bug 619098
Attachment #493545 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 5

7 years ago
Pushed as http://hg.mozilla.org/comm-central/rev/5834a6efada8
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b2

Updated

6 years ago
Depends on: 666102
You need to log in before you can comment on or make changes to this bug.