588419 - Switch SeaMonkey UI to open Data Manager instead of other windows

Status: RESOLVED FIXED

(SeaMonkey :: Passwords & Permissions, defect)

Description

[Robert Kaiser]

We have a number of UI elements, e.g. in Page Info or Preferences windows, that currently open the separate windows for managing data. Those should be switched over to open Data Manager instead.

Comment 1

[Robert Kaiser]

Attachment: part1, v1: page info

This patch switches page info to use the new functionality added in bug 588418 for calling the page/domain's cookie and password lists.

I also added code to only activate those buttons when actual cookies or passwords are available, as else this would open the Data Manager to the default (form data list) which doesn't really fit here.

Comment 2

[Robert Kaiser]

Attachment: v1: full patch for all hooks

This patch does all hooks, and uses with the new syntax from bug 588418.

Conveniently, we can remove permissionsOverlay.js completely, and the inclusion of utilityOverlay.js in preferences.xul makes the broken "Add-ons Manager" button in the software installation panel work again as well.

I think that permissionsNavigatorOverlay should be cleaned up or even merged into the main navigator files, and we might want to restructure the menu items of it in a way to make them more streamlined and reduce redundancy with the Data Manager menu item, but I think all that can go into yet another bug.

Comment 3

[Robert Kaiser]

permissionsOverlay.js in imageContextOverlay.xul can be removed as well, of course, apparently it isn't actually used in there anyhow.

Comment 4

[Ian Neal]

Comment on attachment 493545 [details] [diff] [review]
v1: full patch for all hooks

r=me followup spun off to Bug 619098

Comment 5

[Robert Kaiser]

Pushed as http://hg.mozilla.org/comm-central/rev/5834a6efada8