614086 - TabCandy: Tab Display corrupt

Status: RESOLVED WORKSFORME

(Firefox Graveyard :: Panorama, defect, P2)

Description

[Stefan]

User-Agent:       
Build Identifier: 

The tab display is corrupt (incomplete) when entering TabCandy for the first time with an "App Tab" open.

Reproducible: Always

Steps to Reproduce:
1. Set Home Page to "http://www.mozilla.org/".
2. Close all unpinned/pinned tabs, quit FF, restart FF.
3. Create new (empty) tab.
4. "Pin" that new tab as "App Tab".
5. Enter TabCandy.
Actual Results:  
-> attachment

Expected Results:  
-> attachment

Comment 1

[Stefan]

Attachment: actual results

Comment 2

[Stefan]

Attachment: expected results

Comment 3

[Stefan]

Build:

Mozilla/5.0 (X11; Linux x86_64; rv:2.0b8pre) Gecko/20100101 Firefox/4.0b8pre
Built from http://hg.mozilla.org/mozilla-central/rev/74b4a2f97e23

Comment 4

[Stefan]

The first bad revision is:
changeset:   57654:ea41c727079b
user:        Sean Dunn <[e-mail]>
date:        Mon Oct 11 11:57:00 2010 -0700
summary:     Bug 588630 - "When invoking TabCandy/Panorama with many open blank tabs, Firefox hangs & then pops up "Unresponsive Script" dialog" [r=dietrich, a=blocking]

Comment 5

[juan becerra [:juanb]]

Attachment: tab candy after following steps to reproduce

I'm not able to reproduce this problem as described. After following the steps in comment #0 I see something like the expected results. See attachment.

Comment 6

[Stefan]

@juan: Which OS/FF Version did you use?

Comment 7

[Stefan]

Could reproduce the problem with

2010-11-22-03-mozilla-central
Mozilla/5.0 (X11; Linux i686; rv:2.0b8pre) Gecko/20101122 Firefox/4.0b8pre
Built from http://hg.mozilla.org/mozilla-central/rev/4d73807bfec7

Comment 8

[juan becerra [:juanb]]

Stefan, I used a Linux 64bit machine and the latest nighly with a clean profile. I also tried Mac OS 10.6.5. Did you try with a clean profile?

Comment 9

[Stefan]

Yes. Just verified it with a clean profile (screenshot "weird.jpg").

Comment 10

[Stefan]

Attachment: with clean profile

Comment 11

[juan becerra [:juanb]]

Ok, I tried this once again, and I am able to reproduce the problem, using the latest nightly 11/29 on Linux 64bit. I'm nominating for blocking, because it looks pretty ugly, although it's hard to tell how often users will encounter this scenario. Maybe it's a trivial fix.

Comment 13

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Is this still happening?

Comment 14

[Stefan]

Yes
Mozilla/5.0 (X11; Linux x86_64; rv:2.0b9pre) Gecko/20100101 Firefox/4.0b9pre
http://hg.mozilla.org/mozilla-central/rev/8755d308796d

Comment 15

[David Dahl :ddahl]

So the appTab is represented by the tiny favicon, which when clicked on opens the app tab. will start digging into this.

Comment 16

[David Dahl :ddahl]

Attachment: another screenshot - missing previews

Comment 17

[Kevin Hanes]

bugspam (moving b9 to b10)

Comment 18

[Kevin Hanes]

bugspam (removing b9)

Comment 19

[Ian Gilman [:iangilman]]

(In reply to comment #15)
> So the appTab is represented by the tiny favicon, which when clicked on opens
> the app tab. will start digging into this.

David, are you working on a fix for this?

Comment 20

[David Dahl :ddahl]

(In reply to comment #19)
> (In reply to comment #15)
> > So the appTab is represented by the tiny favicon, which when clicked on opens
> > the app tab. will start digging into this.
> 
> David, are you working on a fix for this?

I started, but changed focus to hardblockers. This is what I was planning on moving back to asap.

Comment 21

[David Dahl :ddahl]

I have been working on this today, tracing the code paths and the difference between how appTabs are handled vs. normal tabs... anyway, in my latest tests cannot reproduce this on 64bit linux and today's nightly with a clean profile.

I a updating my build and will test that as well. Can anyone else reproduce with the 2010-01-14 nightly?

Comment 22

[Stefan]

Mozilla/5.0 (X11; Linux x86_64; rv:2.0b10pre) Gecko/20110114 Firefox/4.0b10pre
reproduces an error. Screenshot follows.

Comment 23

[Stefan]

Attachment: screenshot

Comment 24

[David Dahl :ddahl]

So, I had the appTab saved in the sessionStore - in which case - you do not see the bug at all. if you create the appTab after starting the browser, you see this bug.

Comment 25

[David Dahl :ddahl]

Another clue in DOM Inspector: http://img406.imageshack.us/img406/8320/minefieldgroupyourtabsd.png

look at the css object. there must be a programmatic setting of the tab height and width, making it 20 px by 30 px.

Comment 26

[Michael Yoshitaka Erlewine [:mitcho]]

softblocker = critical

Comment 27

[David Dahl :ddahl]

After today's hg pull I see the correct sized previews, but the previews cut off at the screen height:

http://img717.imageshack.us/img717/373/minefieldgroupyourtabs0.png

And, after navigating elsewhere, you end up with an overlay problem:

http://img153.imageshack.us/img153/373/minefieldgroupyourtabs0.png

Comment 28

[David Dahl :ddahl]

(In reply to comment #27)
> After today's hg pull I see the correct sized previews, but the previews cut
> off at the screen height:
> 
> http://img717.imageshack.us/img717/373/minefieldgroupyourtabs0.png
> 
> And, after navigating elsewhere, you end up with an overlay problem:
> 
> http://img153.imageshack.us/img153/373/minefieldgroupyourtabs0.png

also, this is apparently affecting all platforms.

Comment 29

[David Dahl :ddahl]

OK, so I think the patch in bug 606824 fixed this bug - if it was primarily a width/height issue.

I just did:
hg update -r d6eac3f4a14a

Which updates us to the state I was in when I last worked on this bug and sure enough, we have some corruption as far as height and width:

http://img819.imageshack.us/img819/373/minefieldgroupyourtabs0.png

Comment 30

[Ian Gilman [:iangilman]]

(In reply to comment #29)
> OK, so I think the patch in bug 606824 fixed this bug - if it was primarily a
> width/height issue.

So should we resolve this bug?

Comment 31

[Stefan]

Yes. Issue is absent in fe04d3537b36.

Comment 32

[David Dahl :ddahl]

Best guess is that this was fixed by bug 606824