Closed
Bug 614550
Opened 14 years ago
Closed 14 years ago
Ensure places is enabled for places related c++ tests
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
1.46 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #610974 +++ Unfortunately, when I did the changes for bug 610974 I forgot about the c++ tests that Thunderbird also runs. The patch I'm attaching fixes the only c++ test that there is so that it will correctly run whether places is disabled or not. After that, Thunderbird should be able to build and test fine with places.
Attachment #492987 -
Flags: review?(sdwilsh)
Comment 1•14 years ago
|
||
Comment on attachment 492987 [details] [diff] [review] The fix >diff --git a/toolkit/components/places/tests/cpp/test_IHistory.cpp b/toolkit/components/places/tests/cpp/test_IHistory.cpp >+void >+test_set_places_enabled() >+{ >+ rv = prefBranch->SetBoolPref("places.history.enabled", true); I think you want PR_TRUE here? I assume you ran this and it was green :)
Attachment #492987 -
Flags: review?(sdwilsh) → review+
Updated•14 years ago
|
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•14 years ago
|
||
Checked in: http://hg.mozilla.org/mozilla-central/rev/2c8654b57cca
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•