614550 - Ensure places is enabled for places related c++ tests

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

+++ This bug was initially created as a clone of Bug #610974 +++

Unfortunately, when I did the changes for bug 610974 I forgot about the c++ tests that Thunderbird also runs.

The patch I'm attaching fixes the only c++ test that there is so that it will correctly run whether places is disabled or not. After that, Thunderbird should be able to build and test fine with places.

Comment 1

[Marco Bonardo [:mak]]

Comment on attachment 492987 [details] [diff] [review]
The fix

>diff --git a/toolkit/components/places/tests/cpp/test_IHistory.cpp b/toolkit/components/places/tests/cpp/test_IHistory.cpp

>+void
>+test_set_places_enabled()
>+{

>+  rv = prefBranch->SetBoolPref("places.history.enabled", true);

I think you want PR_TRUE here?

I assume you ran this and it was green :)

Comment 2

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/mozilla-central/rev/2c8654b57cca