617469 - Flash plugin crash switching from YouTube to any other page via URL bar

Status: RESOLVED DUPLICATE of bug 572134

(Core Graveyard :: Plug-ins, defect)

Description

[Josh Aas]

Using Minefield on Mac OS X 10.6 with the latest Flash plugin (10.1.102.64):

1. Watch a video on YouTube.com
2. While watching the video type "hulu.com" into the address bar and hit enter.

Flash will crash. The problem appears to involve calling NPP_SetWindow. This error shows up in the parent process right before the crash:

###!!! [Parent][RPCChannel] Error: Route error: message sent to unknown actor ID

Comment 1

[Josh Aas]

Attachment: parent hang stack from gdb

Comment 2

[Josh Aas]

Attachment: child crash stack from gdb

Comment 3

[Josh Aas]

I don't think this has anything to do with the NPP_SetWindow-related patch for bug 594482 which just landed. This was happening before that patch landed.

Comment 4

[Josh Aas]

I can repro this by switching to "w3.org" which doesn't have any plugin instance in it. No need to go to Hulu.com or another Flash site to repro.

Comment 5

[Adam Kemp]

This has been happening to me for a month or two (it would surprise me if it wasn't already reported earlier, but this was the first report I found). Any time I leave a page while a flash video is playing the flash plugin crashes. If I pause the video before leaving the page then it doesn't crash. The new page is irrelevant. All that matters is that a flash video is playing when the page is unloaded.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As you can see on bug 619757, it has to be a regression from bug 604734. Josh, can you confirm?

Comment 8

[Ed Lee :Mardak]

See also bug 590955 and bug 572134.

Comment 9

[Alex Limi (:limi) — Firefox UX Team]

Just adding myself to CC here.

I can reproduce this extremely reliably, it happens every time I navigate away
from a YouTube page.

Let me know if there's anything I can do to help track this down, if anyone in
the office wants to run a debug build on my machine, or similar.

Comment 10

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

###!!! [Parent][RPCChannel] Error: Route error: message sent to unknown actor
ID

suggests that the plugin process sent a message to an actor that was __delete__'d.  If that always shows up when this crash occurs, then one could break at
 http://mxr.mozilla.org/mozilla-central/source/ipc/glue/AsyncChannel.cpp#403
and use the instructions in
 https://wiki.mozilla.org/Electrolysis/Debugging#Working_backwards_from_a_C.2B.2B_Message_to_its_IPDL_message
to figure out which IPDL message triggered the error message.

This looks like something valgrind might be able to catch.

Comment 11

[Benjamin Smedberg]

I believe this is the same as bug 572134/bug 623108.

Comment 13

[Benoit Girard (:BenWa)]

Should this also be a duplicate of 572134?

Comment 14

[Josh Aas]

I think there is a strong argument to be made for making this block beta 9. I spent some time looking at Flash and Silverlight video sites this morning to see how much it affects them and it makes things pretty miserable. Closing tabs knocks out instances in other tabs constantly and the browser hangs briefly far too often while it recovers from a plugin crash.

Comment 15

[Benjamin Smedberg]

As this is not a regression from beta8, I don't think it needs to block beta9.

I'm not *sure* that this is the same as 572134, so let's leave it open, fix that, and see what happens here.

Comment 16

[Adam Kemp]

It's a regression from beta 3. It should have blocked beta 4. This bug makes it a pain to use the betas or nightlies. It's embarrassing that it's still not fixed.

Comment 17

[Josh Aas]

I'm confident this is a dupe of bug 572134. As the filer, I'll reopen this if it turns out I'm wrong.