617552 - ALT key doesn't work properly when typing digits in about:config

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Anna (Waverley)]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101207 Firefox/4.0b8pre
Build Identifier: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b8pre) Gecko/20101207 Firefox/4.0b8pre Fennec /4.0b3pre

Make sure you have a device with hard keyboard.

Typing digits in the input text fields from about:config while pressing the ALT key and holding it doesn't work properly.

Device: Motorola DROID 2

Reproducible: Always

Steps to Reproduce:
1. Go to about:config.
2. Search for the preference app.update.interval
3. Tap in the input text field of app.update.interval and make sure you erase the data from it ("28800")
4. Press ALT key and hold  while typing in a number (e.g.: "120")
Actual Results:  
After typing in the first digit (in this case "1") the rest are set to 0. (One has to press the ALT key and hold it, otherwise it does not reproduce.) 
The final result is: "0"

Expected Results:  
The user should get: "120".

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Is this still happening?

Comment 2

[Anna (Waverley)]

Yes, I can still reproduce it on:  Mozilla /5.0 (Android;Linux armv7l;rv:2.0b8pre)
Gecko/20101214 Firefox/4.0b8pre Fennec /4.0b3pre

Comment 3

[Brian Crowder]

Attachment: Don't replace mEditable on every text change

This actually seems to fix a number of issues for us by retaining the state of the editable as much as possible.

Comment 4

[Doug Turner (:dougt)]

Comment on attachment 501827 [details] [diff] [review]
Don't replace mEditable on every text change

this does what it needs to.  it makes typing on the g2 work.

Comment 5

[Doug Turner (:dougt)]

without this, i can't really use my g2 to input text.  we should block b4 on this.

Comment 7

[Brian Crowder]

Comment on attachment 501827 [details] [diff] [review]
Don't replace mEditable on every text change

If blassey +s this, I will land and rev w/ jchen's review down the line.

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 501827 [details] [diff] [review]
Don't replace mEditable on every text change

jchen will do a post-landing review

Comment 9

[Brian Crowder]

Attachment: to land

Comment 10

[Brian Crowder]

Comment on attachment 501875 [details] [diff] [review]
to land

Carrying forward blassey's review, and getting post-landing review from jchen

Comment 11

[Brian Crowder]

http://hg.mozilla.org/mozilla-central/rev/a93d3b9e34af

Comment 12

[ahoza]

Verified as fixed on buildID: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b9pre) Gecko/20100106 Firefox/4.0b9pre Fennec /4.0b4pre using Motorola Droid 2.

Comment 13

[ahoza]

I've put wrong buildID. The correct one is: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b9pre) Gecko/20100107 Firefox/4.0b9pre Fennec /4.0b4pre