2.86 KB, patch
|Details | Diff | Splinter Review|
102.85 KB, image/png
30.61 KB, image/png
94.11 KB, image/png
28.31 KB, image/jpeg
(As discussed in bug 588265) Assigning to Aza for design.
Let's gently increase the darkness of the shadow and lighten the background of the background of the group. Assigning to Sean for final design.
Assignee: aza → smartell
bugspam (moving b9 to b10)
bugspam (removing b9)
No longer blocks: 598154
Not sure who exactly this should be assigned to, but uiwanted.
I'm fairly pressed for time atm, but this should simply be a few new rgba values, slightly darker values for the shadows (or alpha value) and a lighter grey for the group itself. If someone wants to have a go at tweaking this and posting a screen, that would be great.
Assignee: nobody → mitcho
Status: NEW → ASSIGNED
Sent to try for win and linux builds.
(In reply to comment #7) > Created attachment 509988 [details] [diff] [review] > Take 1: much stronger shadow, with slightly lighter group items on Mac > > Sent to try for win and linux builds. Sean, here are what this looks like on Win and linux: https://skitch.com/mitcho/rpgxc/win7 https://skitch.com/mitcho/rpgxk/ubuntu Note the win7 has a persona, just so that the background is opaque so the shadow is clearer.
Comment on attachment 509988 [details] [diff] [review] Take 1: much stronger shadow, with slightly lighter group items on Mac Alex, could you ui-review this quickly in case Sean is busy? Mac screenshot is an attachment; win and linux are in skitch links above.
Attachment #509988 - Flags: ui-review?(faaborg)
Attachment #509988 - Flags: ui-review?(faaborg) → ui-review+
Comment on attachment 509988 [details] [diff] [review] Take 1: much stronger shadow, with slightly lighter group items on Mac Thanks Alex! Requesting review.
Comment on attachment 509988 [details] [diff] [review] Take 1: much stronger shadow, with slightly lighter group items on Mac + Gavin for quick review while Ian is out.
Comment on attachment 509988 [details] [diff] [review] Take 1: much stronger shadow, with slightly lighter group items on Mac Really the only thing to review here is whether this is sufficient (rather than whether it is correct), which is somewhat tricky without being familiar with panorama styling. I see no other references to activeGroupItem that need updating, and I imagine you are at least somewhat familiar with this styling, so you can have rs=gavin to just land this.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b12
Mozilla/5.0 (X11; Linux i686; rv:2.0b12pre) Gecko/20110216 Firefox/4.0b12pre Highlighting in Ubuntu does not resemble the mock-up from the website: https://skitch.com/mitcho/rpgxk/ubuntu
looks correct to me on ubuntu; redish highlight with shadow of group. verified with minefield build of 20110217
Status: RESOLVED → VERIFIED
Mozilla/5.0 (X11; Linux i686; rv:2.0b12pre) Gecko/20110217 Firefox/4.0b12pre This is how Panorama looks for me on the latest build (See Screenshot). No redish highlight.
That IS really subtle; it is not that subtle on Mac or Win7. Shorlander, can you tweak?
Assignee: mitcho → shorlander
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Summary: Make Panorama group highlighting more visible → Make Panorama group highlighting more visible on linux
Target Milestone: Firefox 4.0b12 → ---
[bugspam: betaN -> final] It's not clear to me that this is really final material, i.e. even a simple CSS patch may get a- at this point. We'll see.
Whiteboard: [visual][polish][good first bug] → [visual][polish][good first bug][approved-patches-landed]
Mozilla/5.0 (X11;linux i686;rv:2.0b13pre) Gecko/20110301 Firefox/4.0b13pre It looks ok with the latest nightly build.
Attachment #516203 - Attachment mime type: text/plain → image/png
Looks good for me too, using latest nightly and Ubuntu 10.10 with standard theme.
George, is this still an issue for you?
Mozilla/5.0 (X11; Linux i686; rv:2.0) Gecko/20100101 Firefox/4.0 This is the design specification for Ubuntu: https://skitch.com/mitcho/rpgxk/ubuntu This is what I see: Screenshot 1
No longer blocks: 653099
bugspam (Fx7 was branched, removing open bugs from Fx7 meta bug, we won't create new meta bugs for upcoming Fx versions)
No longer blocks: 660175
Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20100101 Firefox/7.0.1 George: Are you using another theme on Ubuntu or Firefox other than the default one?
Attachment #516203 - Attachment is obsolete: true
Whiteboard: [visual][polish][good first bug][approved-patches-landed] → [visual][polish][approved-patches-landed]
Panorama has been removed from Firefox 45, currently in Beta and scheduled for release on March 7th. As such, I'm closing all existing Panorama bugs. If you are still using Panorama, you will see a deprecation message in Firefox 44, and when 45 is released your tab group data will be migrated to bookmarks, with a folder for each group. There are also a few addons offering similar functionality. See https://support.mozilla.org/en-US/kb/tab-groups-removal for more info. We're removing Panorama because it has extremely low usage (about 0.01% of users), and has a large number of bugs and usability issues. The cost of fixing all those issues is far too high to justify, and so we'll instead be focusing our time and energy on improving other parts of Firefox.
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago → 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.