618854 - Make Panorama group highlighting more visible on linux

Status: RESOLVED WONTFIX

(Firefox Graveyard :: Panorama, defect, P4)

Description

[Ian Gilman [:iangilman]]

(As discussed in bug 588265)

Assigning to Aza for design.

Comment 1

[Aza Raskin [:aza]]

Let's gently increase the darkness of the shadow and lighten the background of the background of the group.

Assigning to Sean for final design.

Comment 2

[Kevin Hanes]

bugspam (moving b9 to b10)

Comment 3

[Kevin Hanes]

bugspam (removing b9)

Comment 4

[Michael Yoshitaka Erlewine [:mitcho]]

Not sure who exactly this should be assigned to, but uiwanted.

Comment 5

[Sean Martell]

I'm fairly pressed for time atm, but this should simply be a few new rgba values, slightly darker values for the shadows (or alpha value) and a lighter grey for the group itself.

If someone wants to have a go at tweaking this and posting a screen, that would be great.

Comment 6

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Take 1

Comment 7

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Take 1: much stronger shadow, with slightly lighter group items on Mac

Sent to try for win and linux builds.

Comment 8

[Michael Yoshitaka Erlewine [:mitcho]]

(In reply to comment #7)
> Created attachment 509988 [details] [diff] [review]
> Take 1: much stronger shadow, with slightly lighter group items on Mac
> 
> Sent to try for win and linux builds.

Sean, here are what this looks like on Win and linux:

https://skitch.com/mitcho/rpgxc/win7
https://skitch.com/mitcho/rpgxk/ubuntu

Note the win7 has a persona, just so that the background is opaque so the shadow is clearer.

Comment 9

[Michael Yoshitaka Erlewine [:mitcho]]

Comment on attachment 509988 [details] [diff] [review]
Take 1: much stronger shadow, with slightly lighter group items on Mac

Alex, could you ui-review this quickly in case Sean is busy? Mac screenshot is an attachment; win and linux are in skitch links above.

Comment 10

[Michael Yoshitaka Erlewine [:mitcho]]

Comment on attachment 509988 [details] [diff] [review]
Take 1: much stronger shadow, with slightly lighter group items on Mac

Thanks Alex! Requesting review.

Comment 11

[Michael Yoshitaka Erlewine [:mitcho]]

Comment on attachment 509988 [details] [diff] [review]
Take 1: much stronger shadow, with slightly lighter group items on Mac

+ Gavin for quick review while Ian is out.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 509988 [details] [diff] [review]
Take 1: much stronger shadow, with slightly lighter group items on Mac

Really the only thing to review here is whether this is sufficient (rather than whether it is correct), which is somewhat tricky without being familiar with panorama styling. I see no other references to activeGroupItem that need updating, and I imagine you are at least somewhat familiar with this styling, so you can have rs=gavin to just land this.

Comment 13

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch for checkin

Comment 14

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/722013f84d1f

Comment 15

[George Carstoiu]

Mozilla/5.0 (X11; Linux i686; rv:2.0b12pre) Gecko/20110216 Firefox/4.0b12pre

Highlighting in Ubuntu does not resemble the mock-up from the website:  
https://skitch.com/mitcho/rpgxk/ubuntu

Comment 16

[Tracy Walker [:tracy]]

looks correct to me on ubuntu; redish highlight with shadow of group.

verified with minefield build of 20110217

Comment 17

[George Carstoiu]

Attachment: Screenshot

Mozilla/5.0 (X11; Linux i686; rv:2.0b12pre) Gecko/20110217 Firefox/4.0b12pre

This is how Panorama looks for me on the latest build (See Screenshot). No redish highlight.

Comment 18

[Kevin Hanes]

That IS really subtle; it is not that subtle on Mac or Win7. Shorlander, can you tweak?

Comment 19

[Michael Yoshitaka Erlewine [:mitcho]]

[bugspam: betaN -> final]

It's not clear to me that this is really final material, i.e. even a simple CSS patch may get a- at this point. We'll see.

Comment 20

[Raymond Lee [:raymondlee]]

Attachment: screenshot [look fine on ubuntu]

Mozilla/5.0 (X11;linux i686;rv:2.0b13pre) Gecko/20110301 Firefox/4.0b13pre

It looks ok with the latest nightly build.

Comment 21

[Tim Taubert [:ttaubert] (inactive)]

Attachment: Screenshot [good on Ubuntu 10.10]

Looks good for me too, using latest nightly and Ubuntu 10.10 with standard theme.

Comment 22

[Kevin Hanes]

George, is this still an issue for you?

Comment 23

[George Carstoiu]

Attachment: Screenshot 1

Mozilla/5.0 (X11; Linux i686; rv:2.0) Gecko/20100101 Firefox/4.0

This is the design specification for Ubuntu:
https://skitch.com/mitcho/rpgxk/ubuntu

This is what I see: Screenshot 1

Comment 24

[Kevin Hanes]

bugspam

Comment 25

[Tim Taubert [:ttaubert] (inactive)]

bugspam

Comment 26

[Tim Taubert [:ttaubert] (inactive)]

bugspam

Comment 27

[Tim Taubert [:ttaubert] (inactive)]

bugspam

(Fx7 was branched, removing open bugs from Fx7 meta bug, we won't create new meta bugs for upcoming Fx versions)

Comment 28

[Raymond Lee [:raymondlee]]

Attachment: Screenshot [good on 11.04]

Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20100101 Firefox/7.0.1

George: Are you using another theme on Ubuntu or Firefox other than the default one?

Comment 29

[Justin Dolske [:Dolske]]

Panorama has been removed from Firefox 45, currently in Beta and scheduled for release on March 7th. As such, I'm closing all existing Panorama bugs.

If you are still using Panorama, you will see a deprecation message in Firefox 44, and when 45 is released your tab group data will be migrated to bookmarks, with a folder for each group. There are also a few addons offering similar functionality.

See https://support.mozilla.org/en-US/kb/tab-groups-removal for more info.

We're removing Panorama because it has extremely low usage (about 0.01% of users), and has a large number of bugs and usability issues. The cost of fixing all those issues is far too high to justify, and so we'll instead be focusing our time and energy on improving other parts of Firefox.