619105 - Persona preview screenshot doesn't match actual persona applied

Status: VERIFIED WORKSFORME

(www.mozilla.org :: General, defect)

Description

[Alex Buchanan [:abuchanan]]

Attachment: screenshot of bug

http://nova.stage.mozilla.com/en-US/firefox/customize/

Hover over the large persona screenshot.  The screenshot doesn't match the persona the actually gets applied.

Comment 1

[John Slater]

Is this really a blocker?

Comment 2

[Alex Buchanan [:abuchanan]]

(In reply to comment #1)
> Is this really a blocker?

Oops, that was out of habit.  Doesn't seem like a launch blocker to me.

Anyway, this is a bug with getpersonas, not mozilla.com

Comment 3

[Shae Rivard [:crimius]]

The image here <http://www.getpersonas.com/static/img/persona-sample.jpg> seems to be dynamically generated since it isn't on svn, and the script seems to be  generating it from the wrong persona.  The personas listed at the right, and the one that previews, are the top popular ones.  I'm still haven't been able to figure out exactly what's making it though.

Comment 4

[Steven Garrity [:sgarrity]]

(In reply to comment #3)
> The image here <http://www.getpersonas.com/static/img/persona-sample.jpg> seems
> to be dynamically generated since it isn't on svn, and the script seems to be 
> generating it from the wrong persona.  The personas listed at the right, and
> the one that previews, are the top popular ones.  I'm still haven't been able
> to figure out exactly what's making it though.

It's just a static image from Bug 522754 [1]. If that list is dynamic, we probably can't maintain a large main preview image like that. Maybe the large preview image should always be tied to a single editorially-chosen Persona?

[1] http://viewvc.svn.mozilla.org/vc/projects/getpersonas.com/production/static/img/persona-sample.jpg?view=log

Comment 5

[Shae Rivard [:crimius]]

Attachment: list of persona ids to be restored as mozilla_personas

Comment 6

[Shae Rivard [:crimius]]

the personas on the right (including the one being referenced for the large preview) are generated in [1].  Looking at it, it seems that list is personas marked as 'mozilla_personas' in the db, and has changed since that page was crafted.  Turning it back is just a matter of setting the original personas to be mozilla_personas.  I can't do that yet, but I believe :dria can.

Right now, the "Featured Personas" on getpersonas.com are determined by this same attribute, so I've added a few functions to storage.php that create a new featured_personas attribute that can be used for this in the future.  Filed bug 620200 for that patch.

[1]
http://viewvc.svn.mozilla.org/vc/projects/getpersonas.com/production/server/lib/storage.php?view=log

Comment 7

[Mats Palmgren (inactive)]

If this can't be fixed for the Fx4 release, can we at least make the large image
not trigger a preview at all?  It's confusing to preview a different persona
from the one in the image.
http://www.mozilla.com/en-US/firefox/customize/

Comment 8

[Deb Richardson [:dria] (plz NEEDINFO)]

I've fixed this temporarily by reassigning the first featured Persona for mozilla.com to be the same as the large image (Japanese Tattoo).  This isn't ideal, but until that page is redesigned/rebuilt, it's a reasonable workaround.

The large image will have to be updated for Firefox 4 anyhow, since Personas now draw in the titlebar.  Hopefully someone can fix it then.  This requires a mozilla.com change, so reassigning to that component.

Comment 9

[John Slater]

Am linking this bug to the overall 'build' bug for the Fx4 version of the personalization page.

Comment 10

[James Long (:jlongster)]

Any update on this? What needs to happen?

Comment 11

[Steven Garrity [:sgarrity]]

This has to be fixed on the getpersonas.com side. Can we move it to the appropriate component and who should we assign it to?

Comment 12

[Deb Richardson [:dria] (plz NEEDINFO)]

Sorry, what needs to be fixed here?  The preview image and persona match up for me on this page: http://www.mozilla.com/en-US/firefox/customize/

Comment 13

[Steven Garrity [:sgarrity]]

(In reply to comment #12)
> Sorry, what needs to be fixed here?  The preview image and persona match up for
> me on this page: http://www.mozilla.com/en-US/firefox/customize/

Deb, I might be mixed up on this too, but I think they work now because of your temp fix in comment #8. Is that sufficient to close the bug, or do you think we need a more flexible long-term fix?

Comment 14

[Deb Richardson [:dria] (plz NEEDINFO)]

I think this is probably sufficient for now, but we can look at a more flexible long-term fix as part of the new site after we merge GetPersonas into AMO.  I'll double-check to make sure Wil has this on his radar for that.

Thanks :)