619532 - Bookmark panel missing header and has a blank remove button

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Stephen Horlander [:shorlander]]

Attachment: Panel with problem

I can't pinpoint what causes this but it does throw an error message:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsITransactionManager.endBatch]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource:///modules/PlacesUIUtils.jsm :: <TOP_LEVEL> :: line 1409"  data: no]

Requires a restart to fix.

Comment 1

[Marco Bonardo [:mak]]

This is somehow related to bug 617956, but it's a different manifestation. Notice that while bug 617956 is fixed if you open a new window, this one is not.

Comment 2

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Mehdi, here's another unassigned places blocker that you might be able to jump into.

Comment 3

[Justin Dolske [:Dolske]]

Unowned blocker, over to Margaret but Mehdi may challenge her in the Bugzilladrome -- two engineers enter, one patch leaves!

Comment 4

[:Margaret Leibovic]

Are there any steps to reproduce? I remember seeing bug 617956 multiple times, but I haven't seen it in a long time.

Marco, could this have been fixed by something else by now?

Comment 5

[Marco Bonardo [:mak]]

Since I have this it randomly and I don't know what was causing it, I don't have a answer for you. I've not seen it lately, as well.

Comment 6

[Stephen Horlander [:shorlander]]

I haven't seem this in a while but it was random for me as well.

Comment 7

[Marco Bonardo [:mak]]

I spoke too early, while I have never been able to reproduce this bug, I still see randomly bug 617956 that is pretty much similar.

Comment 8

[Marco Bonardo [:mak]]

So, we really need any help possible to figure out some steps to reliably reproduce this bug please.

Looks like at a certain point something breaks arrow panels and the random failures in bug 620789 seem to confirm this. It's like we miss some popup event.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

** PRODUCT DRIVERS PLEASE NOTE **

This bug is one of 7 automatically changed from blocking2.0:final+ to blocking2.0:.x during the endgame of Firefox 4 for the following reasons:

 - it was marked as a soft blocking issue without a requirement for beta coverage

Comment 10

[:Margaret Leibovic]

Un-assigning myself, since I was unable to come up with steps to reproduce and
haven't looked at this bug in a long time.

I'm not certain this should even block .x (or remain open) if no one can
reproduce it. We haven't heard other reports of this bug in a while, so it may
not exist anymore.

Comment 11

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

So I'm hitting this 100% of the time right now with a relatively new profile (new computer, Firefox profile setup with Sync). Starting in Safe Mode, things look fine, but then starting again in unsafe mode, the issue is back.

Comment 12

[Philipp von Weitershausen [:philikon]]

(In reply to comment #11)
> So I'm hitting this 100% of the time right now with a relatively new profile
> (new computer, Firefox profile setup with Sync).

What if you don't set up Sync?

Comment 13

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

So this might actually be an issue with Jetpack... Installing Dietrich's cmd addon (https://addons.mozilla.org/en-US/firefox/addon/cmd/) reliably causes this issue (only for new windows though - so look at new windows or restart even though it's restartless).

Comment 14

[Dietrich Ayala (:dietrich)]

I've seen this, but cannot reproduce it reliably. I see it single-window scenarios not only in a new window.

Comment 15

[Marco Bonardo [:mak]]

I've looked briefly at this on the plane, I've come to conclusion that the original bug that we saw often was due to the async star, and was fixed by the same patches that fixed intermittent bug 620789.
Due to that practically we were opening the panel with a wrong _batching value (thinking the uri was bookmarked when really it was not, or viceversa), hard to test though, since it's mostly a timing issue. This explains why after a certain time we saw the problem almost disappear (same for bug 617956).

Now, the fact a jetpack can cause the same bug, could still be interesting to investigate. Also, I'm trying to figure out bug 643715 that sounds a bit more detailed with steps and still related to this.

Comment 16

[Marco Bonardo [:mak]]

Looks like the add-on confuses the binding, the code is correctly called, but setting the property does nothing, while setting the "label" attribute works. So the general binding with the label getter and setter is not applied.
The other missing string we had here (originally) was editBookmarkPanelTitle that is a <label>, doesn't have a oncommand though so looks like this specific add-on doesn't touch it.

Comment 17

[Marco Bonardo [:mak]]

I think I forgot to follow-up here. During the last all-hands I've shown the binding behavior to bz, we didn't figure out what was wrong, but the general binding (that has the label property) was definitely out-of-order.  Inspecting the property first showed undefined, and later caused the binding to be applied correctly.  I sent him a mail with the STR, hope to hear back when he will have  time to look at it.

Comment 18

[Bogdan Maris, Desktop Test Engineering]

Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20130107 Firefox/20.0
Build ID: 20130107030932

Steps to reproduce:
1. Download and install "cmd" addon (https://addons.mozilla.org/en-US/firefox/addon/cmd/).
2. Bookmark any page (crdl+d or Bookmarks/Bookmark This Page).
3. Stay on the same page that was Bookmarked and press ctrl+d or go to Bookmarks/Bookmark This Page.

Expected results:
The Edit Bookmark pop-up is correctly displayed, and the Remove Bookmark button is present.

Actual results:
The Remove Bookmark button is squashed and no text is present on the button to indicate its function.

Note:
This is reproducible on latest Nightly, Aurora, 18 RC, 17 ESR and Firefox 4.0 so no regression window is needed.

In SafeMode this issue does not occur so this is probably caused by "cmd" addon.

Comment 19

[S Cohen]

To possibly shine a sliver of additional light on this, I am having the same issue (with an identical panel save for the newer, grey styling) and have tracked it down to the installation of the add-on Diigo.

Comment 20

[Wayne Mery (:wsmwk)]

(In reply to S Cohen from comment #19)
> To possibly shine a sliver of additional light on this, I am having the same
> issue (with an identical panel save for the newer, grey styling) and have
> tracked it down to the installation of the add-on Diigo.

shorlander, are your circumstances the same?

Comment 21

[Stephen Horlander [:shorlander]]

(In reply to Wayne Mery (:wsmwk) from comment #20)
> (In reply to S Cohen from comment #19)
> > To possibly shine a sliver of additional light on this, I am having the same
> > issue (with an identical panel save for the newer, grey styling) and have
> > tracked it down to the installation of the add-on Diigo.
> 
> shorlander, are your circumstances the same?

I do not have that add-on. I haven't actually seen this issue for a while, but it was always pretty random for me.

Comment 23

[Tim Nguyen :ntim]

It's also random for me. Not sure what addon causes it. Not even sure if it's because of an addon.

Comment 24

[Tim Nguyen :ntim]

(In reply to Tim Nguyen [:ntim] from comment #23)
> It's also random for me. Not sure what addon causes it. Not even sure if
> it's because of an addon.

Also, it just started for a week, I thought it was Australis specific, but it turns out it's not.

Comment 25

[Eva]

I was able to reproduce after creating a brand-new profile. 

Steps to reproduce:
1. Download and install "cmd" addon (https://addons.mozilla.org/en-US/firefox/addon/cmd/).
2. Bookmark any page (crdl+d or Bookmarks/Bookmark This Page).
3. Stay on the same page that was Bookmarked and press ctrl+d or go to Bookmarks/Bookmark This Page.

Expected results:
The Edit Bookmark pop-up is correctly displayed, and the Remove Bookmark button is present.

Actual results:
The Remove Bookmark button and the name of the Bookmark is empty. See screenshot here in Nightly here: http://note.io/Xjtqvw

Note:
This is reproducible on latest Nightly[35.0a1 (2014-09-17)}. 

And this is what is looks like on Aurora [34.0a2 (2014-09-17)]: http://note.io/Xjub7M (note the remove bookmark button is blank, but the name of the bookmark is there.

Comment 26

[Tim Nguyen :ntim]

(In reply to Eva from comment #25)
> I was able to reproduce after creating a brand-new profile. 
> 
> Steps to reproduce:
> 1. Download and install "cmd" addon
> (https://addons.mozilla.org/en-US/firefox/addon/cmd/).
> 2. Bookmark any page (crdl+d or Bookmarks/Bookmark This Page).
> 3. Stay on the same page that was Bookmarked and press ctrl+d or go to
> Bookmarks/Bookmark This Page.
> 
> Expected results:
> The Edit Bookmark pop-up is correctly displayed, and the Remove Bookmark
> button is present.
> 
> Actual results:
> The Remove Bookmark button and the name of the Bookmark is empty. See
> screenshot here in Nightly here: http://note.io/Xjtqvw
> 
> Note:
> This is reproducible on latest Nightly[35.0a1 (2014-09-17)}. 
> 
> And this is what is looks like on Aurora [34.0a2 (2014-09-17)]:
> http://note.io/Xjub7M (note the remove bookmark button is blank, but the
> name of the bookmark is there.
Thanks for investigating :) Can you check if there are Browser Console logs after you open the panel with the blank button ?

I've never had the cmd addon (even though I got the issue), but I think this is getting closer to what we want. This sounds like an issue affecting multiple add-ons.

What do you think Marco ?

Comment 27

[Eva]

(In reply to Tim Nguyen [:ntim] from comment #26)
> (In reply to Eva from comment #25)
> > I was able to reproduce after creating a brand-new profile. 
> > 
> > Steps to reproduce:
> > 1. Download and install "cmd" addon
> > (https://addons.mozilla.org/en-US/firefox/addon/cmd/).
> > 2. Bookmark any page (crdl+d or Bookmarks/Bookmark This Page).
> > 3. Stay on the same page that was Bookmarked and press ctrl+d or go to
> > Bookmarks/Bookmark This Page.
> > 
> > Expected results:
> > The Edit Bookmark pop-up is correctly displayed, and the Remove Bookmark
> > button is present.
> > 
> > Actual results:
> > The Remove Bookmark button and the name of the Bookmark is empty. See
> > screenshot here in Nightly here: http://note.io/Xjtqvw
> > 
> > Note:
> > This is reproducible on latest Nightly[35.0a1 (2014-09-17)}. 
> > 
> > And this is what is looks like on Aurora [34.0a2 (2014-09-17)]:
> > http://note.io/Xjub7M (note the remove bookmark button is blank, but the
> > name of the bookmark is there.
> Thanks for investigating :) Can you check if there are Browser Console logs
> after you open the panel with the blank button ?
> 
> I've never had the cmd addon (even though I got the issue), but I think this
> is getting closer to what we want. This sounds like an issue affecting
> multiple add-ons.
> 
> What do you think Marco ?

Hi Tim,

There are. 
This is from the Nightly:
OpenGL compositor Initialized Succesfully.
Version: 2.1 INTEL-8.28.30
Vendor: Intel Inc.
Renderer: Intel HD Graphics 5000 OpenGL Engine
FBO Texture Target: TEXTURE_2D
Could not read chrome manifest 'file:///Applications/FirefoxNightly.app/Contents/MacOS/chrome.manifest'.
mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create Preferences.jsm:381
Could not read chrome manifest 'file:///Applications/FirefoxNightly.app/Contents/MacOS/browser/extensions/%7B972ce4c6-7e08-4474-a285-3208198ce6fd%7D/chrome.manifest'.
Warning: unrecognized command line flag -foreground
 nsBrowserContentHandler.js:750
OpenGL compositor Initialized Succesfully.
Version: 2.1 INTEL-8.28.30
Vendor: Intel Inc.
Renderer: Intel HD Graphics 5000 OpenGL Engine
FBO Texture Target: TEXTURE_2D
1410995745363	Services.HealthReport.HealthReporter	WARN	No prefs data found.
NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIProperties.get] FileUtils.jsm:63
TypeError: this.galleryElement is null jd.gallery_1_2_4_4.js:118
downloadable font: metrics: bad sb: -199 < -126 (font-family: "Oswald" style:normal weight:normal stretch:normal src index:2)
source: http://fonts.gstatic.com/s/oswald/v9/qs_6LdoYjCitupC9judWT-vvDin1pK8aKteLpeZ5c0A.woff css
downloadable font: metrics: bad sb: -211 < -126 (font-family: "Oswald" style:normal weight:normal stretch:normal src index:2)
source: http://fonts.gstatic.com/s/oswald/v9/qs_6LdoYjCitupC9judWT-vvDin1pK8aKteLpeZ5c0A.woff css
downloadable font: metrics: bad sb: -179 < -126 (font-family: "Oswald" style:normal weight:normal stretch:normal src index:2)
source: http://fonts.gstatic.com/s/oswald/v9/qs_6LdoYjCitupC9judWT-vvDin1pK8aKteLpeZ5c0A.woff css
mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create browser.js:2652
TypeError: this.controller is undefined browserPlacesViews.js:237
OpenGL compositor Initialized Succesfully.
Version: 2.1 INTEL-8.28.30
Vendor: Intel Inc.
Renderer: Intel HD Graphics 5000 OpenGL Engine
FBO Texture Target: TEXTURE_2D

and from Aurora: 
Using //@ to indicate sourceMappingURL pragmas is deprecated. Use //# instead jquery.min.js:1
Use of getPreventDefault() is deprecated.  Use defaultPrevented instead. jquery.min.js:5
OpenGL compositor Initialized Succesfully.
Version: 2.1 INTEL-8.28.30
Vendor: Intel Inc.
Renderer: Intel HD Graphics 5000 OpenGL Engine
FBO Texture Target: TEXTURE_2D

Comment 28

[Marco Bonardo [:mak]]

(In reply to Tim Nguyen [:ntim] from comment #26)
> I've never had the cmd addon (even though I got the issue), but I think this
> is getting closer to what we want. This sounds like an issue affecting
> multiple add-ons.
> 
> What do you think Marco ?

The problem with the cmd add-on was already known and IIRC it's due to lazy loading of xul overlays, that is a much larger issue. I'm sure that was already reported elsewhere.

Btw, it's surely a starting point to evaluate a workaround, unfortunately I don't think this will get traction if the only way to reproduce it is through add-ons...