62030 - Mac menu should show accelerator keycode

Status: REOPENED

(Core :: XUL, defect, P3)

Description

[Peter "jag" Annema]

This is a spin-off from bug 47426 to specifically address Mac. saari confirmed
that some keycodes can be shown as accelerators in Mac menus and suggested
adding code which maps between keycode and Mac native.

This here's the bug for that :-)

btw, saari, you could actually peek at the keytext attribute and if it's only
one char, display it, otherwise try the key attribute, or if that's empty (non
existant) try the keycode attribute. How's that sound?

Comment 1

[Marcia Knous [:marcia]]

nominating for dogfood (from sdagley's list of bugs that are good candidates for 
our next release) 

Comment 2

[Andrew Thompson]

Consider fixing in same manner as bug 70048 ?

Comment 3

[Torben]

Reading through bug 47426 my guess is that this bug is that Mozilla does not
show the keyboard shortcuts for Back, Forward, and Home in the View menu. Right?
If so, this is still needed, updating OS.

If someone fixes this, please try to fix bug 46466 too (No, it is not fixed on
mac AFAIK).

Comment 4

[Jo Hermans]

Was fixed a very long time ago

Comment 5

[Stefan [:stefanh]]

Err, when was this fixed?

Comment 6

[Stefan [:stefanh]]

This bug is about the keycode accelerators not showing up in native mac menus
(not to be confused with the key accelerators).

Comment 7

[Jo Hermans]

(In reply to comment #6)
> This bug is about the keycode accelerators not showing up in native mac menus
> (not to be confused with the key accelerators).

Back and forward are now showing, because we're now showing cmd-[/], not the
arrow keys (bug 117186). Home doesn't show anything yet, but I don't know if
this is still necessary (FF should use cmd-shift-H, bug 231248 ; Seamonkey still
uses cmd-home). Are there any other keycodes that need to be shown ?

Comment 8

[Asaf Romano (gone)]

Jo, this is about the arch problem. That's, even if nither of our apps need this
ability, keycodes should be exposed.

Comment 9

[Rob Campbell [:rc] (:robcee)]

is this bug about keytext attributes for keys created with the keycode attribute not showing up? Because if so, this is what I'm seeing:

<key id="someCommand" keycode="VK_F2 keytext="F2" oncommand="doSomething()"/>

does not put the label "F2" next to the menuitem it's associated with on a Mac. keytext doesn't work.

Comment 10

[Frankie]

The View menu no longer contains commands for Back, Forward, and Home.

Keycodes appear to exist for other commands such as ⇧F2 for Tools > Web Developer > Developer Toolbar.

Comment 11

[Maarten Brouwers]

Seems to work here as well.