620507 - mozilla-central/mozilla-2.0 l10n release mozconfigs are using the wrong update channel

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[juan becerra [:juanb]]

While testing l10n spot checks I noticed that the none of the localized Windows builds show the feedback button when you launch them. So if you are a first time 4beta Windows user with a localized beta 8 build, it looks like you won't be able to submit feedback.

This is a regression from beta 7, and it is a blocker.

Steps:
1. Install one of the localized Windows candidate builds for beta 8
2. Launch with a clean profile

Expected: Feedback button

Actual: No Feedback button shown, but if you go to about:addons the extension is listed and enabled.

Could this be an l10n repackaging issue?

Comment 1

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Is this a DUP of bug#620053, which was fixed this morning?

Comment 2

[juan becerra [:juanb]]

This is not a dupe of bug 620053, because that one happened when updating. This is for plain, first time installation.

More info: the feedback menu option under the Tools menu isn't there.

Comment 3

[juan becerra [:juanb]]

The error console shows this:

Errore: entità non definita
File sorgente: chrome://testpilot/content/feedback-browser.xul
Riga: 21, Colonna: 3
Codice sorgente:
  <toolbarbutton type="menu" id="feedback-menu-button"

Comment 4

[juan becerra [:juanb]]

The customization panel does not show the feedback button option either.

Comment 5

[juan becerra [:juanb]]

Attachment: test pilo error log file

Comment 6

[LegNeato]

There were similar problems with the repacks (same error). Does the feedback extension need to be rebuilt/repacked with the fixed build system step/merge locales script?

Comment 7

[Dave Townsend [:mossop]]

The feedback locale simply doesn't exist in the installer, I don't really know how the repacking works to be able to guess why.

Comment 8

[Jono Xia]

I don't know enough about the build system to answer that question about Feedback.

Comment 9

[[e-mail] (:bhearsum)]

I'm rebuilding the 'it' locale for 4.0b8 using the old repack code to either verify or rule out it as the cause.

Comment 10

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

From irc, juanb confirmed that the feedback button *does* work correctly for linux, mac builds.

Comment 11

[Jono Xia]

Re: The test pilot error log file attached in comment 5 --

I just read through it, and it shows everything *but* the overlay is working fine -- all the JS code and networking stuff etc. for Feedback is still happening correctly, it's just not displaying anything to the UI because the overlay failed.

Comment 12

[Jono Xia]

About the Feedback submenu in the Tools menu not being there -- it's defined later in the xul overlay than the toolbarbutton. So if the overlay process is failing on the toolbarbutton as indicated in comment 3, then that probably also explains the absence of the submenu as well.

Comment 13

[[e-mail] (:bhearsum)]

Another issue with the new repack code. Moving to RelEng.

Comment 14

[Brendan Eich [:brendan]]

Need an owner and b8 by xmas or coal in your stockings!

/be

Comment 15

[Brendan Eich [:brendan]]

Christian, can you make a call here?

/be & damons (at a bar)

Comment 16

[LegNeato]

We aren't blocking on this. Merry Christmas! Beta 8 for all! Well, maybe not for users wanting to download win32 localized builds from Mozilla.com...jury's still out for them w/o additional info :-)

Comment 17

[Brendan Eich [:brendan]]

(In reply to comment #16)
> We aren't blocking on this. Merry Christmas! Beta 8 for all! Well, maybe not
> for users wanting to download win32 localized builds from Mozilla.com...jury's
> still out for them w/o additional info :-)

Bug # or it didn't happen.

/grinch

Comment 18

[Brendan Eich [:brendan]]

Can this bug be closed?

/be

Comment 19

[LegNeato]

Nope. The issue is still outstanding. We haven't got to the root cause, only narrowed it down to the build system. It has been decided the issue isn't severe enough to prevent beta 8 though.

Comment 20

[Axel Hecht [:Pike]]

Digging a bit in the source for possible reasons, does that mean that the MOZ_UPDATE_CHANNEL was not "beta" during the windows repacks, but on the other platforms it was?

I checked the german unsigned candidate build 1 zip, firefox/defaults/pref/channel-prefs.js sets the update channel to beta. Probably not touched during the repacks at all, too.

Comment 21

[Axel Hecht [:Pike]]

Aha, assuming that these are the right files:

http://hg.mozilla.org/build/buildbot-configs/file/6665f865e9d7/mozilla2/linux/mozilla-central/release/l10n-mozconfig says
ac_add_options --enable-update-channel=beta
http://hg.mozilla.org/build/buildbot-configs/file/6665f865e9d7/mozilla2/win32/mozilla-central/release/l10n-mozconfig says
ac_add_options --enable-update-channel=release

Comment 22

[[e-mail] (:bhearsum)]

Those are indeed the right files, and that indeed seems like the issue :-(. I'll verify it.

Comment 23

[[e-mail] (:bhearsum)]

Confirmed. Fixing the update channel in the l10n-mozconfig to be "beta" fixes the feedback extension in beta 8 repacks. The good news is that despite it being wrong in the mozconfig, the repacks with the broken Feedback extension are still using the "beta" channel when checking for updates.

Comment 24

[[e-mail] (:bhearsum)]

Updating summary.

Comment 25

[[e-mail] (:bhearsum)]

Attachment: fix update channels in l10n mozconfigs

I grepped across all of the release mozconfigs for additional wrongness and didn't find any in any of mozilla-1.9.1, mozilla-1.9.2, mozilla-central, or mozilla-2.0. There's a 64-bit Linux release mozconfig in 1.9.2 using "beta" but that's not something we ship.

Comment 26

[[e-mail] (:bhearsum)]

Comment on attachment 499010 [details] [diff] [review]
fix update channels in l10n mozconfigs

changeset:   3674:6d33580c6a24

Comment 27

[[e-mail] (:bhearsum)]

This will be fixed going forward.

Comment 29

[Raymond]

My feedback still isn't working, should I rollback to b7?

Comment 30

[Axel Hecht [:Pike]]

This will work again in update 9. I suggest that you stick with b8, overall it's the better version of the two.

Comment 31

[Terrell Kelley]

Feedback button works perfectly well in my copy of Beta 8. It's one of two "known issues" that were not a problem. You probably should update to only be problems for SOME users.

I am using an existing profile, however. Perhaps that could be a workaround--create the new profile in beta 7.