620695 - Terms entered in search field from http://bugzilla.mozilla.org are not considered

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Anna (Waverley)]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b8) Gecko/20100101 Firefox/4.0b8
Build Identifier: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b9pre) Gecko/20101221 Firefox/4.0b9pre Fennec /4.0b4pre

Terms entered in search field from http://bugzilla.mozilla.org are not considered.

Device: Motorola Droid 2 (Android 2.2)

Reproducible: Always

Steps to Reproduce:
1. Go to Bugzilla 
2. Tap on the search field
3. Enter a search term (eg: "twitter") and press "Quick search" button.
    

Actual Results:  
A message box saying: "Please enter one or more search terms first".

Expected Results:  
A page with the search results.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Is this because you did not press the "Search" button on the virtual keyboard? I have noticed that the text entered via the keyboard is not sent to the textbox as you type.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

This patch commits the composition when the text box is un-focused.

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 500924 [details] [diff] [review]
patch

>diff --git a/embedding/android/GeckoAppShell.java b/embedding/android/GeckoAppShell.java
>--- a/embedding/android/GeckoAppShell.java
>+++ b/embedding/android/GeckoAppShell.java
>@@ -255,6 +255,7 @@ class GeckoAppShell
>             break;
> 
>         case NOTIFY_IME_FOCUSCHANGE:
>+            GeckoApp.surfaceView.inputConnection.finishComposingText();
>             GeckoApp.surfaceView.mIMEFocus = state != 0;
>             IMEStateUpdater.resetIME();
>             break;

I think it's better to call finishComposingText under NOTIFY_IME_RESETINPUTSTATE instead of NOTIFY_IME_FOCUSCHANGE

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

(In reply to comment #7)
> Comment on attachment 500924 [details] [diff] [review]
> patch
> 
> >diff --git a/embedding/android/GeckoAppShell.java b/embedding/android/GeckoAppShell.java
> >--- a/embedding/android/GeckoAppShell.java
> >+++ b/embedding/android/GeckoAppShell.java
> >@@ -255,6 +255,7 @@ class GeckoAppShell
> >             break;
> > 
> >         case NOTIFY_IME_FOCUSCHANGE:
> >+            GeckoApp.surfaceView.inputConnection.finishComposingText();
> >             GeckoApp.surfaceView.mIMEFocus = state != 0;
> >             IMEStateUpdater.resetIME();
> >             break;
> 
> I think it's better to call finishComposingText under
> NOTIFY_IME_RESETINPUTSTATE instead of NOTIFY_IME_FOCUSCHANGE

that works

Comment 9

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 501360 [details] [diff] [review]
patch

Thanks!

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/db4d73bcabf0

Comment 11

[Aakash Desai [:aakashd]]

verified FIXED on build:
Mozilla/5.0 (Android; Linux armv71; rv:2.0b13pre) Gecko/20110317 Firefox/4.0b13pre Fennec/4.0b6pre