The default bug view has changed. See this FAQ.

Make plugins listening presShell SetActive calls

RESOLVED FIXED in mozilla9

Status

()

Core
Plug-ins
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: tom brinkman, Assigned: romaxa)

Tracking

(Depends on: 2 bugs)

Trunk
mozilla9
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments, 4 obsolete attachments)

(Reporter)

Description

6 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.12) Gecko/20101027 Ubuntu/10.04 (lucid) Firefox/3.6.12
Build Identifier: 

Upstream patch from harmattan

Reproducible: Always
(Reporter)

Comment 1

6 years ago
Created attachment 499586 [details] [diff] [review]
Upstream patch from harmattan
(Reporter)

Comment 2

6 years ago
Created attachment 499602 [details] [diff] [review]
Upstream patch from hartmattan
Attachment #499586 - Attachment is obsolete: true
Attachment #499586 - Attachment is patch: true
Attachment #499586 - Attachment mime type: application/octet-stream → text/plain
Attachment #499602 - Attachment is patch: true
(Assignee)

Comment 3

6 years ago
Might be related to bug 585129
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Plugin Activation → Make plugins listening presShell SetActive calls
(Reporter)

Updated

6 years ago
Depends on: 619056
(Reporter)

Comment 4

6 years ago
From code comments:

Update plugin active state. Frame should update if it is on an active tab
or not and forward that information to the plugin to make it possible to
throttle down plugin instance in non active case
Component: General → Plug-ins
OS: Linux → All
Product: Fennec → Core
Hardware: Other → All
QA Contact: general → plugins
(Assignee)

Updated

6 years ago
Blocks: 619056
No longer depends on: 619056
(Reporter)

Updated

6 years ago
Attachment #499602 - Flags: review?(joshmoz)
(Reporter)

Comment 5

6 years ago
Created attachment 501449 [details] [diff] [review]
Updatted patch. Minor patch fix.
Attachment #499602 - Attachment is obsolete: true
Attachment #501449 - Flags: review?(joshmoz)
Attachment #499602 - Flags: review?(joshmoz)

Updated

6 years ago
Attachment #501449 - Flags: review?(joshmoz) → review?(jst)
(Reporter)

Comment 6

6 years ago
Created attachment 501451 [details] [diff] [review]
Updatted patch
Attachment #501449 - Attachment is obsolete: true
Attachment #501451 - Flags: review?(joshmoz)
Attachment #501449 - Flags: review?(jst)

Updated

6 years ago
Attachment #501451 - Flags: review?(joshmoz) → review?(jst)
(Assignee)

Comment 7

6 years ago
Created attachment 553917 [details] [diff] [review]
Sync plugins visibility state with docShell active state

Updated patch, Fixed reactivation of invisible plugins on activated shell...
Without this patch plugins staying in "visible" state for all background tabs
Assignee: nobody → romaxa
Attachment #501451 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #553917 - Flags: review?(jst)
Attachment #501451 - Flags: review?(jst)
Comment on attachment 553917 [details] [diff] [review]
Sync plugins visibility state with docShell active state

+nsPluginInstanceOwner::UpdateDocumentActivity(PRBool aIsActive)

I'd much rather see this new method called UpdateDocumentActiveState(), as that's what it does.

r=jst with that.
Attachment #553917 - Flags: review?(jst) → review+
(Assignee)

Comment 9

6 years ago
Created attachment 553994 [details] [diff] [review]
Sync plugins visibility state with docShell active state. TO PUSH

Fixed nits
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/c51feb247cc4
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/c51feb247cc4
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
(Assignee)

Comment 12

6 years ago
Comment on attachment 553994 [details] [diff] [review]
Sync plugins visibility state with docShell active state. TO PUSH

This is important change for handling Plugins activity on Mobile (N9). and prevent power consumption caused by running plugins in background tabs..

Risk is medium, because plugins are unpredictable...
Attachment #553994 - Flags: approval-mozilla-aurora?
Comment on attachment 553994 [details] [diff] [review]
Sync plugins visibility state with docShell active state. TO PUSH

Discussed in triage today - touching plugins is scary, and while it's good to see this fix coming in, it doesn't feel like something we should rush in against rules (aurora should only be for regressions in the current version or crash/security fixes - this isn't those things). Please re-nom if you think we've missed something in our analysis.
Attachment #553994 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-

Updated

5 years ago
Depends on: 732892

Updated

5 years ago
Depends on: 745286
You need to log in before you can comment on or make changes to this bug.