Closed Bug 621228 Opened 9 years ago Closed 8 years ago
Make plugins listening pres
Shell Set Active calls
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:18.104.22.168) Gecko/20101027 Ubuntu/10.04 (lucid) Firefox/3.6.12 Build Identifier: Upstream patch from harmattan Reproducible: Always
Might be related to bug 585129
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Plugin Activation → Make plugins listening presShell SetActive calls
From code comments: Update plugin active state. Frame should update if it is on an active tab or not and forward that information to the plugin to make it possible to throttle down plugin instance in non active case
Component: General → Plug-ins
OS: Linux → All
Product: Fennec → Core
Hardware: Other → All
Updated patch, Fixed reactivation of invisible plugins on activated shell... Without this patch plugins staying in "visible" state for all background tabs
Comment on attachment 553917 [details] [diff] [review] Sync plugins visibility state with docShell active state +nsPluginInstanceOwner::UpdateDocumentActivity(PRBool aIsActive) I'd much rather see this new method called UpdateDocumentActiveState(), as that's what it does. r=jst with that.
Attachment #553917 - Flags: review?(jst) → review+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Comment on attachment 553994 [details] [diff] [review] Sync plugins visibility state with docShell active state. TO PUSH This is important change for handling Plugins activity on Mobile (N9). and prevent power consumption caused by running plugins in background tabs.. Risk is medium, because plugins are unpredictable...
Attachment #553994 - Flags: approval-mozilla-aurora?
Comment on attachment 553994 [details] [diff] [review] Sync plugins visibility state with docShell active state. TO PUSH Discussed in triage today - touching plugins is scary, and while it's good to see this fix coming in, it doesn't feel like something we should rush in against rules (aurora should only be for regressions in the current version or crash/security fixes - this isn't those things). Please re-nom if you think we've missed something in our analysis.
Attachment #553994 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
You need to log in before you can comment on or make changes to this bug.