Closed Bug 621228 Opened 14 years ago Closed 13 years ago

Make plugins listening presShell SetActive calls

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla9

People

(Reporter: reportbase, Assigned: romaxa)

References

(Depends on 1 open bug,
URL
)

Details

Attachments

(2 files, 4 obsolete files)

Sync plugins visibility state with docShell active state
5.75 KB, patch
jst
: review+
Details | Diff | Splinter Review
Sync plugins visibility state with docShell active state. TO PUSH
5.78 KB, patch
johnath
: approval-mozilla-aurora-
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.12) Gecko/20101027 Ubuntu/10.04 (lucid) Firefox/3.6.12
Build Identifier: 

Upstream patch from harmattan

Reproducible: Always
Attached patch Upstream patch from harmattan (obsolete) — — Splinter Review 

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Upstream patch from hartmattan (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #499586 -
        Attachment is obsolete: true

        Attachment #499586 -
        Attachment is patch: true

        Attachment #499586 -
        Attachment mime type: application/octet-stream → text/plain

        Attachment #499602 -
        Attachment is patch: true

    
    

    
  
Might be related to bug 585129
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Plugin Activation → Make plugins listening presShell SetActive calls

    
  
Depends on: 619056

    
    

    
  
From code comments:

Update plugin active state. Frame should update if it is on an active tab
or not and forward that information to the plugin to make it possible to
throttle down plugin instance in non active case
Component: General → Plug-ins
OS: Linux → All
Product: Fennec → Core
Hardware: Other → All
QA Contact: general → plugins

    
  
Blocks: 619056
No longer depends on: 619056

    
  

        Attachment #499602 -
        Flags: review?(joshmoz)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Updatted patch. Minor patch fix. (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #499602 -
        Attachment is obsolete: true

        Attachment #501449 -
        Flags: review?(joshmoz)

        Attachment #499602 -
        Flags: review?(joshmoz)

    
  

        Attachment #501449 -
        Flags: review?(joshmoz) → review?(jst)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Updatted patch (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #501449 -
        Attachment is obsolete: true

        Attachment #501451 -
        Flags: review?(joshmoz)

        Attachment #501449 -
        Flags: review?(jst)

    
  

        Attachment #501451 -
        Flags: review?(joshmoz) → review?(jst)

    
    

    
  


  
Updated patch, Fixed reactivation of invisible plugins on activated shell...
Without this patch plugins staying in "visible" state for all background tabs
Assignee: nobody → romaxa

        Attachment #501451 -
        Attachment is obsolete: true
Status: NEW → ASSIGNED

        Attachment #553917 -
        Flags: review?(jst)

        Attachment #501451 -
        Flags: review?(jst)

    
    

    
  
Comment on attachment 553917 [details] [diff] [review]
Sync plugins visibility state with docShell active state

+nsPluginInstanceOwner::UpdateDocumentActivity(PRBool aIsActive)

I'd much rather see this new method called UpdateDocumentActiveState(), as that's what it does.

r=jst with that.

        Attachment #553917 -
        Flags: review?(jst) → review+

    
  
Keywords: checkin-needed

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/c51feb247cc4
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9

    
    

    
  
Comment on attachment 553994 [details] [diff] [review]
Sync plugins visibility state with docShell active state. TO PUSH

This is important change for handling Plugins activity on Mobile (N9). and prevent power consumption caused by running plugins in background tabs..

Risk is medium, because plugins are unpredictable...

        Attachment #553994 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Comment on attachment 553994 [details] [diff] [review]
Sync plugins visibility state with docShell active state. TO PUSH

Discussed in triage today - touching plugins is scary, and while it's good to see this fix coming in, it doesn't feel like something we should rush in against rules (aurora should only be for regressions in the current version or crash/security fixes - this isn't those things). Please re-nom if you think we've missed something in our analysis.

        Attachment #553994 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora-

    
  
Depends on: 732892

    
  
Depends on: 745286

    
  
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: