621228 - Make plugins listening presShell SetActive calls

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[tom brinkman]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.12) Gecko/20101027 Ubuntu/10.04 (lucid) Firefox/3.6.12
Build Identifier: 

Upstream patch from harmattan

Reproducible: Always

Comment 1

[tom brinkman]

Attachment: Upstream patch from harmattan

Comment 2

[tom brinkman]

Attachment: Upstream patch from hartmattan

Comment 3

[Oleg Romashin (:romaxa)]

Might be related to bug 585129

Comment 4

[tom brinkman]

From code comments:

Update plugin active state. Frame should update if it is on an active tab
or not and forward that information to the plugin to make it possible to
throttle down plugin instance in non active case

Comment 5

[tom brinkman]

Attachment: Updatted patch. Minor patch fix.

Comment 6

[tom brinkman]

Attachment: Updatted patch

Comment 7

[Oleg Romashin (:romaxa)]

Attachment: Sync plugins visibility state with docShell active state

Updated patch, Fixed reactivation of invisible plugins on activated shell...
Without this patch plugins staying in "visible" state for all background tabs

Comment 8

[Johnny Stenback (:jst)]

Comment on attachment 553917 [details] [diff] [review]
Sync plugins visibility state with docShell active state

+nsPluginInstanceOwner::UpdateDocumentActivity(PRBool aIsActive)

I'd much rather see this new method called UpdateDocumentActiveState(), as that's what it does.

r=jst with that.

Comment 9

[Oleg Romashin (:romaxa)]

Attachment: Sync plugins visibility state with docShell active state. TO PUSH

Fixed nits

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/c51feb247cc4

Comment 11

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/c51feb247cc4

Comment 12

[Oleg Romashin (:romaxa)]

Comment on attachment 553994 [details] [diff] [review]
Sync plugins visibility state with docShell active state. TO PUSH

This is important change for handling Plugins activity on Mobile (N9). and prevent power consumption caused by running plugins in background tabs..

Risk is medium, because plugins are unpredictable...

Comment 13

[Johnathan Nightingale [:johnath]]

Comment on attachment 553994 [details] [diff] [review]
Sync plugins visibility state with docShell active state. TO PUSH

Discussed in triage today - touching plugins is scary, and while it's good to see this fix coming in, it doesn't feel like something we should rush in against rules (aurora should only be for regressions in the current version or crash/security fixes - this isn't those things). Please re-nom if you think we've missed something in our analysis.