621605 - Update es-MX translation for Firefox 4

Status: RESOLVED FIXED

(Mozilla Localizations :: es-MX / Spanish (Mexico), defect)

Description

[Roberto Alvarado]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; es-MX; rv:1.9.2.13) Gecko/20101206 Ubuntu/10.10 (maverick) Firefox/3.6.13
Build Identifier: 

provide patches for review by several people and included in the repository.

Reproducible: Always

Steps to Reproduce:
1.Download an es-MX nightly build of Firefox 4
2.Check the UI; it is only partially translated
3.



The patches are generated from Mozilla Translator an Ricardo Palomares explain the issues arising from the use of the tool.

Comment 1

[RickieES aka Ricardo Palomares]

I've taken the freedom to add both of you, Axel and Juan; hope you don't mind. I've just noticed I must add Ricardo Meza, too.

Roberto is going to upload an initial patch to update the DOM module. I have to warn that, apparently, Firefox 3.6 files were translated by hand (or maybe Narro is very aesthetic with Properties files layout). Whatever reason, the fact is that many Firefox 3.6 Properties files imported into mozilla-central have extra espaces to align the equal sign, while MozillaTranslator always export as key(space)=(space)value (yep, MDN says it is key=value, without intermediate spaces). This leads to many lines without actual changes.

Comment 2

[Roberto Alvarado]

Attachment: Patch to update DOM strings in es-MX for Firefox 4

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 500698 [details] [diff] [review]
Patch to update DOM strings in es-MX for Firefox 4

That's looking good to me, I've looked at it with my l10n-aware diff tool that doesn't show all the formatting changes.

Kinda sad to see them go in, though, I wish all our tools were good editors.

Comment 4

[RickieES aka Ricardo Palomares]

(In reply to comment #3)
> Comment on attachment 500698 [details] [diff] [review]
> Patch to update DOM strings in es-MX for Firefox 4
> 
> That's looking good to me, I've looked at it with my l10n-aware diff tool that
> doesn't show all the formatting changes.


That's nice. Who should do the check-in? Is it OK if I do it?


> Kinda sad to see them go in, though, I wish all our tools were good editors.


Yeah, sorry. I have a list of things to do for MozillaTranslator.next, and one of them is exporting only modified files. At least this will mitigate the problem in the future.

Comment 5

[RickieES aka Ricardo Palomares]

(In reply to comment #4)
> (In reply to comment #3)
> > Comment on attachment 500698 [details] [diff] [review]
> > Patch to update DOM strings in es-MX for Firefox 4
> > 
> > That's looking good to me, I've looked at it with my l10n-aware diff tool that
> > doesn't show all the formatting changes.
> 
> 
> That's nice. Who should do the check-in? Is it OK if I do it?


Pinging Pike. Do I have green light to commit Roberto's changes?

He's about to upload patches for netwerk and security, and he will probably have all Fx4 strings localized by the end of this week.

Comment 6

[Axel Hecht [:Pike]]

Please go ahead and land.

Comment 7

[RickieES aka Ricardo Palomares]

(In reply to comment #6)
> Please go ahead and land.

Done:

http://hg.mozilla.org/l10n-central/es-MX/rev/e8f1b580b2ff

Roberto, next one, please. :-)

Comment 8

[RickieES aka Ricardo Palomares]

(In reply to comment #7)
> (In reply to comment #6)
> > Please go ahead and land.
> 
> Done:
> 
> http://hg.mozilla.org/l10n-central/es-MX/rev/e8f1b580b2ff


Uh, I've taken the freedom to push a followup removing obsolete files (MT removes from its datastore, but does not rm them in the working copy):

http://hg.mozilla.org/l10n-central/es-MX/rev/2c1724198d3a

Time to install compare-locales locally. :-/

Comment 9

[Roberto Alvarado]

Attachment: Patch to update NETWERK strings in es-MX for Firefox 4

This is another patch for more strings in es-MX for Firefox 4

Comment 10

[Axel Hecht [:Pike]]

Comment on attachment 503395 [details] [diff] [review]
Patch to update NETWERK strings in es-MX for Firefox 4

Roberto, just feed patches to Ricardo for now? I don't think I need to be man-in-the-middle here for all modules, and Ricardo is going to do the landing for the next few anyway, I hope.

Comment 11

[RickieES aka Ricardo Palomares]

(In reply to comment #10)
> Comment on attachment 503395 [details] [diff] [review]
> Patch to update NETWERK strings in es-MX for Firefox 4
> 
> Roberto, just feed patches to Ricardo for now?


Done:

http://hg.mozilla.org/l10n-central/es-MX/rev/8c2c1b3f4ec7


> I don't think I need to be
> man-in-the-middle here for all modules, and Ricardo is going to do the landing
> for the next few anyway, I hope.


OK, we will proceed this way then, if you agree:

- Just for the record, I'm reviewing the patches myself and testing how they apply into es-MX repository before Roberto uploads them into this bug.

- Roberto will still attach the patches (after my review and test-apply), but he will NOT request review, to relieve you for the burden.

- I will wait at least some hours before committing and pushing them into l10n-central.

- I will report here each revision.


BTW, Roberto, I think you should take this bug yourself. I will tell you how to do this tonight.

Comment 12

[Axel Hecht [:Pike]]

Thanks, sounds like a good way forward.

I don't see a value in the "few hours wait", but I'll leave that up to you.

I've beefed up Roberto's privs to actually assign bugs to himself, and edit them. Roberto, use the new powers carefully? Thanks.

Comment 13

[Roberto Alvarado]

Attachment: Patch to update SECURITY strings in es-MX for Firefox 4

Patch to update SECURITY strings in es-MX for Firefox 4

Comment 14

[RickieES aka Ricardo Palomares]

(In reply to comment #12)
> Thanks, sounds like a good way forward.
> 
> I don't see a value in the "few hours wait", but I'll leave that up to you.


It was just in case anyone wanted to informally review the patch before it gets landed. I guess it can be backed out, if needed. :-)

Comment 15

[RickieES aka Ricardo Palomares]

(In reply to comment #13)
> Created attachment 503627 [details]
> Patch to update SECURITY strings in es-MX for Firefox 4
> 
> Patch to update SECURITY strings in es-MX for Firefox 4


Landed:

http://hg.mozilla.org/l10n-central/es-MX/rev/45acf8c5e5a4

Comment 16

[RickieES aka Ricardo Palomares]

Attachment: Fix for extra newline in pippki.properties

I forgot to upload this fix before committing it into the repo. In fact, I'm looking how to avoid that MozillaTranslator honors manually entered newlines in values without escaping them first at least.

Comment 17

[RickieES aka Ricardo Palomares]

Attachment: Patch to update TOOLKIT strings in es-MX for Firefox 4

Patch includes removal of obsolete files in Toolkit module.

Comment 18

[RickieES aka Ricardo Palomares]

(In reply to comment #17)
> Created attachment 506931 [details] [diff] [review]
> Patch to update TOOLKIT strings in es-MX for Firefox 4
> 
> Patch includes removal of obsolete files in Toolkit module.


Landed:

http://hg.mozilla.org/l10n-central/es-MX/rev/229cff0a40f0

There are still some missing files in Toolkit localization, as there were a huge number of new strings and it was difficult for Roberto to keep track of new changes while he was struggling to get down the number of untranslated strings. Once I push the browser patch in a few minutes, we'll do another round to provide missing files and strings for toolkit, browser and sync modules.

Comment 19

[RickieES aka Ricardo Palomares]

Attachment: Patch to update BROWSER strings in es-MX for Firefox 4

Comment 20

[RickieES aka Ricardo Palomares]

(In reply to comment #19)
> Created attachment 506951 [details] [diff] [review]
> Patch to update BROWSER strings in es-MX for Firefox 4


Landed:

http://hg.mozilla.org/l10n-central/es-MX/rev/1a144deaea94

Oops, Roberto, there are a fair number of pending strings. Back to intense work! :-)

Comment 21

[RickieES aka Ricardo Palomares]

Attachment: Patch to add new TOOLKIT files in es-MX for Firefox 4

It turns out that running hg diff on a working directory with new files not previously added to the repository lacks those files. Fortunately, Roberto sent me a copy of MT besides the patches, so I'm adding those files here.

Comment 22

[RickieES aka Ricardo Palomares]

(In reply to comment #21)
> Created attachment 506976 [details] [diff] [review]
> Patch to add new TOOLKIT files in es-MX for Firefox 4
> 
> It turns out that running hg diff on a working directory with new files not
> previously added to the repository lacks those files. Fortunately, Roberto sent
> me a copy of MT besides the patches, so I'm adding those files here.

Landed:

http://hg.mozilla.org/l10n-central/es-MX/rev/43b005ef3d9a

Only 382 missing strings at this moment! :-)

Comment 23

[RickieES aka Ricardo Palomares]

Attachment: Patch to add new BROWSER files in es-MX for Firefox 4

The pending missing files for browser.

Comment 24

[RickieES aka Ricardo Palomares]

(In reply to comment #23)
> Created attachment 506989 [details] [diff] [review]
> Patch to add new BROWSER files in es-MX for Firefox 4
> 
> The pending missing files for browser.


Landed:

http://hg.mozilla.org/l10n-central/es-MX/rev/afb068f009f7

Comment 25

[RickieES aka Ricardo Palomares]

Attachment: Patch to add new SYNC files in es-MX for Firefox 4

Comment 26

[RickieES aka Ricardo Palomares]

Landed:

http://hg.mozilla.org/l10n-central/es-MX/rev/c4c2e87eda25

Comment 27

[RickieES aka Ricardo Palomares]

Attachment: Patch to put BROWSER files up to date in es-MX for Firefox 4

Comment 28

[RickieES aka Ricardo Palomares]

Attachment: Patch to put OTHER-LICENSES files up to date in es-MX for Firefox 4

Comment 29

[RickieES aka Ricardo Palomares]

Attachment: Patch to put TOOLKIT files up to date in es-MX for Firefox 4

Comment 30

[RickieES aka Ricardo Palomares]

(In reply to comment #27)
> Created attachment 508910 [details] [diff] [review]
> Patch to put BROWSER files up to date in es-MX for Firefox 4


Landed:

http://hg.mozilla.org/l10n-central/es-MX/rev/1c12fd056c00

(In reply to comment #28)
> Created attachment 508911 [details] [diff] [review]
> Patch to put OTHER-LICENSES files up to date in es-MX for Firefox 4

Landed:

http://hg.mozilla.org/l10n-central/es-MX/rev/0d01d8734a21

(In reply to comment #29)
> Created attachment 508912 [details] [diff] [review]
> Patch to put TOOLKIT files up to date in es-MX for Firefox 4

Landed:

http://hg.mozilla.org/l10n-central/es-MX/rev/af471347dc17

This should turn Fx40 es-MX to green for the first time.

Comment 31

[RickieES aka Ricardo Palomares]

Attachment: Patch to remove all REPORTER files in es-MX for Firefox 4

Comment 32

[RickieES aka Ricardo Palomares]

(In reply to comment #31)
> Created attachment 508917 [details] [diff] [review]
> Patch to remove all REPORTER files in es-MX for Firefox 4

Landed:

http://hg.mozilla.org/l10n-central/es-MX/rev/5496ba66f5e3

Comment 33

[RickieES aka Ricardo Palomares]

Attachment: Patch to remove forgotten obsolete entity in es-MX for Firefox 4

Comment 34

[RickieES aka Ricardo Palomares]

(In reply to comment #33)
> Created attachment 508919 [details] [diff] [review]
> Patch to remove forgotten obsolete entity in es-MX for Firefox 4

Landed:

http://hg.mozilla.org/l10n-central/es-MX/rev/ca4b0a3d26a7

Actually, Fx40 won't turn green because there is an extra key in region.properties that should be removed. As there is a Fx40 productization bug (bug 603960), I think we can manage this file in that bug.

Comment 35

[Axel Hecht [:Pike]]

keyword.URL removal got a whitecard approval in .l10n, just go ahead ;-)

Comment 36

[RickieES aka Ricardo Palomares]

Attachment: Patch to remove keyword.url from Region.properties in es-MX for Firefox 4

As per comment 35.

Comment 37

[RickieES aka Ricardo Palomares]

(In reply to comment #36)
> Created attachment 508930 [details] [diff] [review]
> Patch to remove keyword.url from Region.properties in es-MX for Firefox 4
> 
> As per comment 35.


Landed:

http://hg.mozilla.org/l10n-central/es-MX/rev/87368e8d6b25

Comment 38

[RickieES aka Ricardo Palomares]

*Now* Fx40 es-MX is green! :-)

Comment 39

[Roberto Alvarado]

Can i close this bug?

Comment 40

[Axel Hecht [:Pike]]

Yes, lets. Marking FIXED. Great work and thanks.