603960 - (fx40-p12n-es-MX) [es-MX] Firefox 4.0 productization review for Spanish (Mexico)

Status: RESOLVED FIXED

(Mozilla Localizations :: es-MX / Spanish (Mexico), defect)

Description

[Staś Małolepszy :stas]

As you might have seen in the newsgroups or on the Mozilla blog, there's a couple of changes to search engines planned for the 4.0 release for en-US: <http://groups.google.com/group/mozilla.dev.l10n/msg/81073d8d67e1c4c3>. We would like to use this opportunity to review the current productization setup for Spanish (Mexico) and make any changes that you think will be good for our users.

What is a productization review?
================================

Here's what we're interested in:
* search engines,
* protocol handlers,
* feed readers,
* live bookmark.
You can see what your locale currently ships with at <http://hg.mozilla.org/l10n/l10n-src-verification/file/default/reference/browser/2.0/es-MX>

Please take a moment and review the choice of services available by default in your locale. If there have been any new services that have recently gained popularity and that offer good value for the users, please suggest adding them to your locale. On the other hand, if there are services that lost credibility (e.g. display too many adds) or have poor user experience, consider suggesting that we remove them. If in doubt, feel free to make a suggestion and we'll look at it together. You might find the guidelines at <https://wiki.mozilla.org/L10n:Productization> and <https://wiki.mozilla.org/L10n:Firefox/Productization> helpful, too.

Required changes
================

There's two things I would like to draw your attention to (if applicable):

1) if you have a google.xml file in your `searchplugins` directory, please remove it,

2) Bloglines is closing down on November 1st and we need to remove it from the feed reader options for all locales (see bug 595485). We suspect that it will make sense to move Google Reader up to the first position (if your locale has it). We will be offering technical help with this change, either in form of ready-made patches or a mass-landing by one of the l10n-drivers. If you don't think that moving Google Reader up is a good idea for your locale, please let us know!

Changes in en-US and en-GB
==========================

Here's the changes that we will be making in en-US and en-GB:
* add Bing as the 3rd general search engine (see bug 603298),
* remove Answers,
* remove Creative Commons.

We're making these changes in en-US and en-GB because we feel that they follow the recent market trends and user preferences in the US and the UK. We would like to go through the same thought process for your locale and see if any of these changes would make sense in Spanish (Mexico) builds as well. If you decide that implementing these changes would be in your users' best interest then please go ahead and include them in the patch you'll attach to this bug.


Implementation
==============

Please make suggestions for changes and attach patches that Seth, Axel or I will review. Please note that since Bing provides a global plugin which does the locale detection itself, you will only need to add "bing" to your list.txt if you decide to include it. The XML file will be automatically pulled from en-US.

Once a review is granted, you can land the patch on l10n-central if your locale actively maintains it. Otherwise, please wait for further instructions which will be put in the comments of this bug and announced in mozilla.dev.l10n (we're still unsure when the branching will happen). Please do not land any changes except for the required ones (google.xml, Bloglines) on 1.9.2.

If you do not wish to make any changes, let us know, and we'll only work on removing Bloglines.

Thanks!

Comment 1

[Seth Bindernagel]

Bloglines still remains in your 1.9.2 repository.  Please prepare a patch to remove it. 

Also, if you have any productization changes to make for Firefox 4, like the Bing suggestion listed in comment 0, please provide a patch to make that change on l10n-central.  Thank you.

Comment 2

[Seth Bindernagel]

Ping, please respond to comment #1.

Comment 3

[Roberto Alvarado]

I am currently in charge of translating, reviewing what I can say is said in this direction are still considering all of the files listed here "http://hg.mozilla.org/l10n/l10n-src-verification/file/default/reference/browser/2.0/es-MX" and still handle most of the files, but now we have new in Mozilla Translator. .. is bing.xml, answers.xml, eBay.xml, do you ignore these files or how we can add them? I hope to guide me in order to achieve close the bug and have es-MX

Comment 4

[RickieES aka Ricardo Palomares]

(In reply to comment #3)
> I am currently in charge of translating, reviewing what I can say is said in
> this direction are still considering all of the files listed here
> "http://hg.mozilla.org/l10n/l10n-src-verification/file/default/reference/browser/2.0/es-MX"
> and still handle most of the files, but now we have new in Mozilla Translator.
> .. is bing.xml, answers.xml, eBay.xml, do you ignore these files or how we can
> add them? I hope to guide me in order to achieve close the bug and have es-MX


Hum... Please note that, currently, searchplugins that fall back to en-US have been already removed:

http://hg.mozilla.org/l10n-central/es-MX/file/tip/browser/searchplugins

So, regarding searchplugins, the main issue is to decide if es-MX needs amazondotcom and/or creativecommons, and if adding Bing would be convenient for es-MX. Roberto, that's really your call. Do you think:

- Amazon is popular in Mexico?
- Creativecommons is popular in Mexico?
- Bing is getting popular in Mexico?

For each of the above questions, if the answer is:

- Yes, then keep it (so, don't touch anything)
- No, then remove it from list.txt

Regarding Bloglines, yes, I think we need to provide a patch to remove Bloglines:

http://hg.mozilla.org/l10n-central/es-MX/file/afb068f009f7/browser/chrome/browser-region/region.properties

Roberto, what you need to choose is:

- If you think another web-based blog reader is convenient for es-MX
- In what order should be displayed the available options

Remember, this file is also not managed inside MozillaTranslator. You'll need to use an UTF-8 text editor (Gedit or Kedit work fine).

And for the rest of possible changes, we're so late in the game that I don't think you want to mess with it. IIRC, changing the live bookmark (and maybe protocol handlers, too) involves requesting permission to the new target website, so I think it is better to leave it as is.

Comment 5

[RickieES aka Ricardo Palomares]

(In reply to comment #4)
> Hum... Please note that, currently, searchplugins that fall back to en-US have
> been already removed:
> 
> http://hg.mozilla.org/l10n-central/es-MX/file/tip/browser/searchplugins


BTW, we haven't requested permission to remove google.xml; that's my fault, but I didn't though it was needed, since it was a "must do". Mercado libre landed in l10n-central because it was granted long time ago for l10n-mozilla1.9.2 and it should have been ported back then. For the remaining changes, we will of course request permission before landing. :-)

Comment 6

[RickieES aka Ricardo Palomares]

(In reply to comment #4)
> (...) Roberto, that's really your call. Do you think:
> 
> - Amazon is popular in Mexico?
> - Creativecommons is popular in Mexico?
> - Bing is getting popular in Mexico?
> 
> For each of the above questions, if the answer is:
> 
> - Yes, then keep it (so, don't touch anything)
> - No, then remove it from list.txt
> 
> Regarding Bloglines, yes, I think we need to provide a patch to remove
> Bloglines:
> 
> http://hg.mozilla.org/l10n-central/es-MX/file/afb068f009f7/browser/chrome/browser-region/region.properties
> 
> Roberto, what you need to choose is:
> 
> - If you think another web-based blog reader is convenient for es-MX
> - In what order should be displayed the available options


Roberto, pinging you. After all your hard work to translate Firefox 4.0 to es-MX, this is what can prevent you for getting a shipping Firefox 4.0 in es-MX. Please, respond to the above questions.

Comment 7

[RickieES aka Ricardo Palomares]

Just for the record, I've just removed keyword.url from region.properties. See comment 35 from bug 621605 and further for the reasoning to touch this p12n file:

https://bugzilla.mozilla.org/show_bug.cgi?id=621605#c35

Comment 8

[RickieES aka Ricardo Palomares]

One question: Roberto wants to include Bing. For what I've seen, bing.xml needs some l10n (the searchplugin title, at the very least [1]), so he should actually rename it to bing-mx.xml, similarly to what is usually done with Yahoo! searchplugin. Am I right?


[1] http://hg.mozilla.org/mozilla-central/file/6a78c8b01e9b/browser/locales/en-US/searchplugins/bing.xml#l3

Comment 9

[Seth Bindernagel]

Bing is included in the en-US build.  And, Bing provides results based on their locale detection, so we do not need to included a localized plugin.  Simply add Bing to your list.txt file and it will be included in the localized build.  Just to make it clear, you do not need a special Bing xml file for es-MX.

Comment 10

[Seth Bindernagel]

Hi guys, what is the status of this bug?

Comment 11

[RickieES aka Ricardo Palomares]

Attachment: Cleanup of obsolete searchplugins, adding Bing and reordering all of them

Removed Amazon.com and CreativeCommons, added Bing, and reordered the searchplugin list so Google, Yahoo! and Bing are first, then Wikipedia and last MercadoLibre.

Comment 12

[RickieES aka Ricardo Palomares]

(In reply to comment #4)
> Regarding Bloglines, yes, I think we need to provide a patch to remove
> Bloglines:
> 
> http://hg.mozilla.org/l10n-central/es-MX/file/afb068f009f7/browser/chrome/browser-region/region.properties
> 
> Roberto, what you need to choose is:
> 
> - If you think another web-based blog reader is convenient for es-MX
> - In what order should be displayed the available options
> 
> Remember, this file is also not managed inside MozillaTranslator. You'll need
> to use an UTF-8 text editor (Gedit or Kedit work fine).


Roberto, this is ABSOLUTE PRIORITY. I can prepare the diff for you, but you are the one to choose the above (an optional replacement for Bloglines, and the order of the available options). Please, put in hold everything else in es-MX localization.

Comment 13

[juan becerra [:juanb]]

With only anecdotal evidence to back this up, I think it should be Google followed by Yahoo! as the options for web-based blog readers. The determination in comment #11 seems right to me.

I'll defer to Roberto to confirm this.

Comment 14

[Roberto Alvarado]

This is the order: 1.- Google, 2.- Yahoo! 3.- Bing 4.- wikipedia-es 5.- mercadolibre-mx, for me this is the right order because we need Google as priority followed by Yahoo! and the and the third bing, wikipedia-es and mercadolibre-mx they have much information but the most important are Google, Yahoo! and Bing.

Comment 15

[Roberto Alvarado]

This is correct. Please go ahead with it.

Comment 16

[Seth Bindernagel]

Comment on attachment 511217 [details] [diff] [review]
Cleanup of obsolete searchplugins, adding Bing and reordering all of them

This is nearly perfect with one small problem.  It appears that you have an extra line in this file given the extra "+" for the last line.  Can you remove that and then I will r+ it?  Please flag me (:sethb) for a review.

Comment 17

[RickieES aka Ricardo Palomares]

(In reply to comment #16)
> Comment on attachment 511217 [details] [diff] [review]
> Cleanup of obsolete searchplugins, adding Bing and reordering all of them
> 
> This is nearly perfect with one small problem.  It appears that you have an
> extra line in this file given the extra "+" for the last line.  Can you remove
> that and then I will r+ it?  Please flag me (:sethb) for a review.

Sorry, I added it to prevent the "\ No newline at end of file" message that came up in es-ES p12n bug (see https://bugzilla.mozilla.org/show_bug.cgi?id=603959#c18). Actually, I can't say for sure the message will show up if I don't add that newline, so let me try this afternoon and report back or provide a new patch.

Comment 18

[Seth Bindernagel]

I've been able to avoid the "\ No newline at end of file" by editing in Vim.  Do you know how to use Vim to edit?  If you open the file in Vim, you should be able to remove that extra line where the "+" is showing and then save and the "\ No newline at end of file" will not show up.  

Don't ask me why this happens.  :)

Comment 19

[RickieES aka Ricardo Palomares]

Attachment: Cleanup of obsolete searchplugins, adding Bing and reordering all of them, without extra newlines

It was easier, just removing the new line in GEdit. :-)

Comment 20

[Seth Bindernagel]

Comment on attachment 511729 [details] [diff] [review]
Cleanup of obsolete searchplugins, adding Bing and reordering all of them, without extra newlines

Cool.  Please check this in.  Add this comment:  "Bug 603960, FF 4 p12n review, r=sethb"

Once you land this, test the nightly and then sign off.  You can close this bug once you have confirmed with testing.

Comment 21

[RickieES aka Ricardo Palomares]

> Cool.  Please check this in.  Add this comment:  "Bug 603960, FF 4 p12n review,
> r=sethb"

Done:

http://hg.mozilla.org/l10n-central/es-MX/rev/6991fec1e790


> Once you land this, test the nightly and then sign off.  You can close this
> bug once you have confirmed with testing.


Not really, I'm afraid. The protocol handlers issue is still pending Roberto's decission.

Comment 22

[RickieES aka Ricardo Palomares]

Attachment: Reordering RSS webhandlers (Bloglines is still alive, so it has been pushed down, but not removed)

Roberto has provided me the right order for protocol webhandlers. This will be the last step to really have es-MX ready to be signed-off.

Comment 23

[RickieES aka Ricardo Palomares]

Attachment: Reordering RSS webhandlers (Bloglines is still alive, so it has been pushed down, but not removed)

Oops! The deal with Roberto was Google first, Yahoo second and Bloglines third. Thanks to Axel's e-mail I've reviewed my own patch and realized it was wrong.

Comment 24

[Seth Bindernagel]

Comment on attachment 512212 [details] [diff] [review]
Reordering RSS webhandlers (Bloglines is still alive, so it has been pushed down, but not removed)

Please check this in.  Please add a comment that references bug 603960, r=sethb and this change.  After you land the change, please test it and then sign off.

Comment 25

[RickieES aka Ricardo Palomares]

(In reply to comment #24)
> Comment on attachment 512212 [details] [diff] [review]
> Reordering RSS webhandlers (Bloglines is still alive, so it has been pushed
> down, but not removed)
> 
> Please check this in.  Please add a comment that references bug 603960, r=sethb
> and this change.  After you land the change, please test it and then sign off.


Landed:

http://hg.mozilla.org/l10n-central/es-MX/rev/ad4feb079016

I will sign-off as soon as I can test new binaries with this change.

Comment 26

[RickieES aka Ricardo Palomares]

> Landed:
> 
> http://hg.mozilla.org/l10n-central/es-MX/rev/ad4feb079016
> 
> I will sign-off as soon as I can test new binaries with this change.


Tested with a new fresh profile on Linux 32, binary downloaded from here:

ftp://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-l10n/

Searchplugins and web handlers appear as expected after committing patches in this bug. I've signed-off, although:

- there are 5 missing strings
- there are QA/polish changes to be done

Roberto, please, update your repositories (both mozilla-central and l10n-central/es-MX) and work on giving the final touch to es-MX. :-) You need also to assign yourself this bug and close it as RESOLVED FIXED.

Comment 27

[Axel Hecht [:Pike]]

... accepted the sign-off :-)