622571 - Firefox button menu no longer works when CTRL-clicking a bookmark from the FF button

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Stanley Chan]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b9pre) Gecko/20110103 Firefox/4.0b9pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b9pre) Gecko/20110103 Firefox/4.0b9pre

CTRL-clicking a bookmark from the Firefox button menu breaks the Firefox button itself. After the bookmark is loaded, the Firefox menu no longer opens no matter how much you click on it. The only way to fix this in the same session is hitting ALT to bring up the classic menus and opening a menu from there. The Firefox button functionality returns.

(NOTE: I discovered this bug while filing the report for Bug 622570: https://bugzilla.mozilla.org/show_bug.cgi?id=622570)

Reproducible: Always

Steps to Reproduce:
1. Click on Firefox button on top left
2. Hover over bookmarks
3. CTRL-click a website to open it in a new tab

Actual Results:  
Firefox menu closes and the clicked website opens and loads in a new tab. However, the Firefox button becomes broken and no longer opens.

Expected Results:  
Clicking the Firefox button should cause the menu to open.

Only way to get back the menu (in the same session; ie. not restarting the browser) is to hit ALT to open classic menus and the opening a menu from there. The Firefox button functionality returns.

I rated this bug as a major bug because it is a UI break in a flagship feature of Firefox 4.0.

Comment 1

[Luke Iliffe (Harlequin99)]

Confirmed bug 583386 probably caused this with the nightly pushlog below where the new firefox menu design appeared along with this bug. 

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3be451ad56d7&tochange=c8c886655ea1

Comment 2

[Alice0775 White]

Attachment: possible fix

Add condition for components of splitmenu, i.e splitmenu , hbox and vbox.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Alice, did you figure out what caused the bug? I'm trying to understand what's the reason that the button becomes broken

Comment 4

[Alice0775 White]

(In reply to comment #3)
> Alice, did you figure out what caused the bug? I'm trying to understand what's
> the reason that the button becomes broken
No. i did not figure out *any*.

While testing the bug, The problem dissolved when I evaluate the following code in the error console when a problem happened.
top.opener.document.getElementById("appmenu-popup").hidePopup();

So, the above "possible fix" do hidePopup explicitly.

Comment 5

[:Felipe Gomes (needinfo for replies!)]

The popup frames are ending in an inconsistent state after the STR. They remain with popupState = ePopupInvisible, set by HidePopupsInList.

Enn, I'm trying to find what is causing that. HidePopupsInList says it sets to ePopupInvisible on purpose. After that, then, what is it that is supposed to clear the popup state back to ePopupClosed?

Comment 6

[:Felipe Gomes (needinfo for replies!)]

It is the FirePopupHidingEvent.  For some reason it's not being called for the top-level app menu when a bookmark menuitem receives a ctrl+click.

Comment 7

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 500841 [details] [diff] [review]
possible fix

Considering this is a softblocker, I was talking to Dietrich and I think we could take this workaround patch and then file a follow-up to investigate the underlying platform bug.

The problem goes like this: the handler here calls menu.hidePopup() on the sub-menus of the bookmarks menu. Due to the new structure of the app menu, it stops on the hbox/vbox and doesn't call hidePopup() for the top-level app menu. 
The oncommand handler at nsXULPopupManager::ExecuteMenu hides it anyway, but the PopupHidingEvent doesn't fire and the top-level menu is left at the "invisible" state rather than the "closed" state, and due to that it doesn't open again.

With this patch we call hidePopup on the top-level menu too and no state is left broken. Incidentally it also fixes bug 622570.

Comment 8

[Marek Raida]

I'm not sure, if it is related to this issue or not (but I found nothing more related), but for me stopped working even Delete/Properties actions from bookmark menu. 
Mt build ID is: Mozilla/5.0 (Windows NT 5.1; rv:2.0b10pre) Gecko/20110116 Firefox/4.0b10pre
and if I:
Open Bookmark Dialog
Move with mouse over existing item
Open Item dialog with RightMouseButton
Choose Delete or Properties Action

... and nothing happens...

Comment 9

[Luke Iliffe (Harlequin99)]

A different issue, possibly bug 625778

Comment 10

[Marek Raida]

Thx for tip, I moved my comment and testcase also there...

Comment 11

[:Felipe Gomes (needinfo for replies!)]

http://hg.mozilla.org/mozilla-central/rev/7af5059626fa

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Windows NT 6.1; rv:2.0b10pre) Gecko/20110121 Firefox/4.0b10pre

Do we have any chance for an automated test?