623768 - Pressing Backspace in Panorama causes last focused tab to navigate backwards

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect, P3)

Description

[Sam]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8) Gecko/20100101 Firefox/4.0b8
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8) Gecko/20100101 Firefox/4.0b8

After entering Panorama, pressing backspace causes the tab I entered Panorama from to navigate back a page. This became an issue when I was using the search feature and pressed backspace one to many times.

Reproducible: Always

Steps to Reproduce:
1. Open a tab in which you are able to navigate backwards.
2. From said tab, open Panorama (Ctrl+E or button - same result with either).
3. Press backspace.
Actual Results:  
Tab from which Panorama was opened navigates back a page.

Expected Results:  
Nothing should happen.

Comment 1

[gadjo]

Other shortcuts work as well, for example Ctrl-+

Comment 2

[Ian Gilman [:iangilman]]

This is a specific case of bug 587276; marking as duplicate.

Comment 4

[Kevin Hanes]

The patch for bug 587276 does not cover this case (it white lists commands, not
key strokes, see comment 6 on bug 636178). Re-opening. 

Also, that patch has a- for Fx4. Perhaps we can make a trivial patch for this
one?

Comment 5

[Raymond Lee [:raymondlee]]

Attachment: v1

Comment 6

[Raymond Lee [:raymondlee]]

Comment on attachment 515024 [details] [diff] [review]
v1

Passed try
http://tbpl.mozilla.org/?tree=MozillaTry&rev=de8adb10ac5f

Comment 7

[Michael Yoshitaka Erlewine [:mitcho]]

Comment on attachment 515024 [details] [diff] [review]
v1

Looks great. Definitely worth doing for RC, imho.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 515024 [details] [diff] [review]
v1

a=beltzner

Comment 9

[Raymond Lee [:raymondlee]]

Attachment: [checked-in] Patch for check-in

Comment 10

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 515800 [details] [diff] [review]
[checked-in] Patch for check-in

http://hg.mozilla.org/mozilla-central/rev/270aec271dc8

Comment 11

[gadjo]

I guess that Ctrl+/- case is not fixed by this patch - will it be fixed by bug 587276 or should I file a separate bug?

Comment 12

[Raymond Lee [:raymondlee]]

(In reply to comment #11)
> I guess that Ctrl+/- case is not fixed by this patch - will it be fixed by bug
> 587276 or should I file a separate bug?

It will be fixed by bug 587276 but it would happen post Fx4

Comment 13

[George Carstoiu]

Verified with: Mozilla/5.0 (X11; Linux i686; rv:2.0) Gecko/20100101 Firefox/4.0