62497 - Can't undo shift+deleting a message or deleting a message from trash

Status: VERIFIED DUPLICATE of bug 132121

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[Jesse Ruderman]

Shift+deleting a message or deleting a message from the trash folder doesn't 
update the undo/redo options.  So if I move a message around and then 
shift+delete it, the undo option is still "undo move message", and selecting 
the option creates a blank message.  It should be possible to undo 
shift+deleting a message.

See also bug 62448, shift+delete is normally a shortcut for "cut" but 
permanently deletes a message without prompting.

Comment 1

[Matthew T (active 1999-2002)]

I don't think this is a bug.



When you delete a message, it goes to the Trash. Undo moves it from the Trash 

back to the folder where it was. So if you delete something from the Trash 

itself, you *really* want it deleted permanently, right?



Similarly, if you press Shift+Delete, you explicitly waive your right to undo the 

deletion -- do not pass the Trash, do not collect $200. If you were able to undo 

this deletion, what would be the difference between Shift+Delete and ordinary 

Delete?

Comment 2

[Jesse Ruderman]

>So if you delete something from the Trash itself, you *really* want it deleted 
>permanently, right?

What if I forget I'm viewing the Trash folder?  What if I forget that Mozilla 
uses the Cut shortcut for Permanently Delete?

>If you were able to undo this deletion, what would be the difference between 
>Shift+Delete and ordinary Delete?

With shift+delete, once you leave Mail, the messages aren't wasting any memory 
or hard disk space.


Another reason this is a bug is that it messes up Undo history.  If I activate 
an older Undo option that has to do with the same message, a blank message is 
created.

Comment 3

[scottputterman]

I don't disagree that undo of shift-delete would be nice, but it's not something
that's a high priority for the same reasons that mpt wrote.

The fact that it messes up the undo stack is another bug that we should file.
If we can't currently undo it then it shouldn't be part of the undo stack.

reassigning to naving

Comment 4

[esther]

using build 2001-05-31 on win, mac and linux shift+delete key (the one not on 
the number pad) deletes a message from the inbox bypassing the Trash (like it 
should).  I can use Edit|Undo Deleted Message to undo this type of delete.  I 
also deleted from trash and Edit|Undo Deleted Message was available to me too. 
I think this can be resolved as worksforme or fixed if development remembers 
fixing this since 12-13-2000.

Comment 5

[Henrik Gemal]

Not sure I understand. Are we saying that SHIFT+DELETE should be undoable?
If so, then NO! If you share INBOX with someone it's sometimes nice to be able 
to *really* delete a mail.

I'm also using shift+delete to delete all my spam mails, which I dont want to 
fill up in my Trash. The same goes with huge mails. And virus mails!

This is taken from msdn.microsoft.com:
"When you press the SHIFT+Delete key combination in Windows, the expected 
behavior is that you are deleting files or folders permanently without sending 
them to the Recycle Bin."

Comment 6

[Jerome Lacoste]

I agree with Henrik. This should be invalid. Consistency with other applications
is one point. 'Really deleting should exist' is another.

Comment 7

[David :Bienvenu]

MPT is labouring under the misconception that making shift delete from local
mail undoable would somehow change the way shift delete works, and somehow make
it more like normal delete. It would not. When we shift delete a message from a
local folder, we just set the deleted flag on the message in the local folder
that the message is deleted. The message is not actually removed from disk until
the folder is compacted, and is trivially undeleted by just unsetting the
deleted flag.

Comment 8

[David :Bienvenu]

*** Bug 59650 has been marked as a duplicate of this bug. ***

Comment 9

[David :Bienvenu]

marking this as dup of newer bug, since that bug has keywords and status.
Probably won't make Moz 1.0, unfortunately.

*** This bug has been marked as a duplicate of 132121 ***

Comment 10

[Sheela Ravindran]

verified as dup