Closed Bug 625668 Opened 9 years ago Closed 8 years ago

Resizes for single groups don't stick correctly, returning them to their userSize values

Categories

(Firefox Graveyard :: Panorama, defect, P5)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 8

People

(Reporter: mitcho, Assigned: ttaubert)

References

Details

(Keywords: polish, Whiteboard: [visual][polish])

Attachments

(2 files, 2 obsolete files)

Attached image Screenshot
When a window only has a single group and this window is resized down past the usersize, you observe some odd behavior where you momentarily see the group get resized to new bounds to fit the window, but then bounce back to its original size. Something odd is going on in the resize code in this case.

This is one non-pushAway cause of bug 587140.

This bug is a followup to bug 625269. The test for 625269 includes a TODO for this bug.
Blocks: 673196
Assignee: nobody → tim.taubert
Status: NEW → ASSIGNED
Whiteboard: [visual][polish][good first bug] → [visual][polish]
Target Milestone: Future → ---
Version: unspecified → Trunk
Attached patch patch v1 (obsolete) — Splinter Review
Item.pushAway() does strange things when called with only one top-level item. There's no need to even execute all this code when there's only one top-level item (that's what the patch does).

I refactored the whole test for bug 625269 (that covers this bug, too) because it didn't measure the group size correctly and was as a whole a bit unclear.
Attachment #547592 - Flags: feedback?(raymond)
Attachment #547592 - Flags: feedback?(raymond) → feedback+
Attachment #547592 - Flags: review?(dietrich)
Comment on attachment 547592 [details] [diff] [review]
patch v1

Review of attachment 547592 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, r=me.
Attachment #547592 - Flags: review?(dietrich) → review+
Attached patch patch v2 (obsolete) — Splinter Review
Alas, browser_tabview_bug625269.js failed once on the try server. I extended it to wait until any css transition (if active) ended and check the group bounds after that.
Attachment #547592 - Attachment is obsolete: true
Attachment #547966 - Flags: review?(dietrich)
Comment on attachment 547966 [details] [diff] [review]
patch v2

*Sigh* still fails on try. Investigating.
Attachment #547966 - Flags: review?(dietrich)
Attached patch patch v3Splinter Review
Reverted the changes from patch v2. There are no animations involved, silly me. The problem was that there can be multiple resize events and we need to wait until the target size has been reached.
Attachment #547966 - Attachment is obsolete: true
Attachment #548265 - Flags: review?(dietrich)
Attachment #548265 - Flags: review?(dietrich) → review+
http://hg.mozilla.org/integration/fx-team/rev/42e7710675b2
Whiteboard: [visual][polish] → [visual][polish][fixed-in-fx-team]
http://hg.mozilla.org/mozilla-central/rev/42e7710675b2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [visual][polish][fixed-in-fx-team] → [visual][polish]
Target Milestone: --- → Firefox 8
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.