Closed Bug 626240 Opened 9 years ago Closed 9 years ago

Switching tabs results in blocking TabCanvas updates

Categories

(Firefox Graveyard :: Panorama, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ttaubert, Unassigned)

References

Details

(Keywords: perf)

I recently profiled what Panorama is doing when switching tabs. This is what chromebug told me:

1.) When switching a tab in the main browser window (via click or something) panorama spends about 340ms in TabCanvas.paint(). I think there's really no need to block the whole browser to update a canvas in the background. When disabling this it really felt a bit snappier to change tabs than in my concurrently opened nightly.

2.) When panorama is opened and one clicks on a tab (other than the currently selected) to open it the same thing happens. TabCanvas.paint() is called for the selected tab and blocks the browser (and the zoom?) for about 340ms. I guess this could be already fixed in bug 604215?

FYI, I verified with chromebug breakpoints that these updates are not called via the heartbeat (and so that they block UI).
I believe both of these occurrences have been fixed by bug 609685 (which removes the immediate paint call for the current tab). Can you verify and close if appropriate?
Fixed. Thanks!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
verified per comment #2
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.