626240 - Switching tabs results in blocking TabCanvas updates

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

I recently profiled what Panorama is doing when switching tabs. This is what chromebug told me:

1.) When switching a tab in the main browser window (via click or something) panorama spends about 340ms in TabCanvas.paint(). I think there's really no need to block the whole browser to update a canvas in the background. When disabling this it really felt a bit snappier to change tabs than in my concurrently opened nightly.

2.) When panorama is opened and one clicks on a tab (other than the currently selected) to open it the same thing happens. TabCanvas.paint() is called for the selected tab and blocks the browser (and the zoom?) for about 340ms. I guess this could be already fixed in bug 604215?

FYI, I verified with chromebug breakpoints that these updates are not called via the heartbeat (and so that they block UI).

Comment 1

[Ian Gilman [:iangilman]]

I believe both of these occurrences have been fixed by bug 609685 (which removes the immediate paint call for the current tab). Can you verify and close if appropriate?

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Fixed. Thanks!

Comment 3

[Tracy Walker [:tracy]]

verified per comment #2