627242 - When I disable a jetpack, it hides my Addon bar

Status: RESOLVED DUPLICATE of bug 635714

(Add-on SDK Graveyard :: General, defect)

Description

[Daniel Holbert [:dholbert]]

STEPS TO REPRODUCE:
 0. Start with a fresh profile (for simplicity)

 1. In View | Toolbars, enable "Addon Bar"
  1a. OPTIONAL: View|Toolbars|Customize, and add e.g. the sync icon to the Addons toolbar

 2. Load this minimal jetpack:
      https://builder.addons.mozilla.org/addon/1000076/latest/
   and click "Test". This adds a widget to your Addons bar saying "101" (and may trigger Bug 627235, shrinking the bar slightly - disregard that for now)

 3. Click "Test" again, to disable the jetpack.

ACTUAL RESULTS: Addon bar disappears.

EXPECTED RESULTS: Addon bar should remain. I explicitly asked for it to be shown, back in step 1.  It also potentially has other content on it (from step 1a) that still I want to have access to.

NOTE: The same results happen if you install a jetpack (e.g. gandalf's 'hard blockers counter'*) and then disable it in the addons manager.

*https://addons.mozilla.org/en-US/firefox/addon/hard-blockers-counter/

Comment 2

[Dietrich Ayala (:dietrich)]

Here's the relevant bit in the Add-on SDK:

https://github.com/mozilla/addon-sdk/blob/master/packages/addon-kit/lib/widget.js#L598

It's a bug in the Widget code, it's only checking for other widgets, not for anything else on the bar.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Widgets got a bit of love in 1.0b4, maybe this was fixed as part of it? Can you try with a recent pull of the SDK?

Comment 4

[Alexandre Poirot [:ochameau]]

Fixed :)