62729 - Real name capability on bug_list.cgi.

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, enhancement, P3)

Description

[Matthew Tuck [:CodeMachine]]

Split off of bug #38135, which suggested that the email addresses on
bug_list.cgi be followed by real names like on show_bug.cgi.

I instead suggest there should be separate columns like "QA Contact (Real Name)"
that the user can elect to show with or instead of the e-mail address, for all
e-mail address columns.

Comment 1

[Dave Miller [:justdave]]

moving to real milestones...

Comment 2

[Stephan Niemz]

moving to real milestones...

Comment 3

[Asa Dotzler [:asa]]

realnames in buglist.cgi would alleviate a serious usability shortcoming.  There
are several b.m.o users with email addresses in excess of 30 characters. In
cases where the reporter, qa contact or assignee are visible and of such great
length then all the other columns are shifted far to the right causing a
horizontal scroll and making bug number and summary not visible at the same
time. Another solution to this problem would be to truncate or wrap email
addresses at some reasonable width. I can't ask these folks to get a new email
address but I wouldn't feel too bad asking them to abbreviate a long realname. 

Comment 4

[Matthew Tuck [:CodeMachine]]

Moving to new Bugzilla product ...

Comment 5

[Matthew Tuck [:CodeMachine]]

*** Bug 137942 has been marked as a duplicate of this bug. ***

Comment 6

[Toms Baugis]

It was pretty simple for me. I will attach diff log.

Comment 7

[Toms Baugis]

Attachment: Patch to get mail & it's realname instead just mail

Well, it's the first time i'm using diff, also - i am behind firewall.

What else - you must set primary key on profiles.realname column, in other case
there could be a security leak or something

Comment 8

[Toms Baugis]

Attachment: v1

This patch allows to choose reporter and owner realname columns and displays
them in buglist. I removed possibility to assign by realname, because i am not
sure about the security thing.

Comment 9

[Toms Baugis]

Attachment: v2

Sorry about spamming (because no big activity happens here), but i revised the
patch myself and noticed that i forgot qa_contact (which i don't use).

So - this patch also adds qa_contact_realname to columns in colchange and
buglist.

Someone - please do something with this (revise/propose/comment/whatever)! :)

P.S. i have no rights to obsolete attachment 81486 [details] and attachment 84167 [details] [diff] [review] !

Comment 10

[Andreas Franke (gone)]

Comment on attachment 84389 [details] [diff] [review]
v2

Works nicely, thus r=afranke.

But you may want to add the new columns to the %abbrev hash in
template/en/default/list/table.html.tmpl ...

[e-mail] can give you editbugs permissions if you ask him.

Comment 11

[Toms Baugis]

Attachment: v3

Patch also updates template\en\default\table.html.tmpl template
That should be all for now

P.S. Sorry - i new that i forgot something :)

Comment 12

[Toms Baugis]

See also bug 146162

Comment 13

[Toms Baugis]

Attachment: Patch against HEAD

Previous patch was against 2.16 and there where missing entries to
colchange.html.tmpl.

This one is against HEAD (also search.pm updated) and there at last is nothing
missing (i hope so).

Comment 14

[Andreas Franke (gone)]

Toms: I've seen the review request, but I'm not familiar with the latest version
of bugzilla to an extent that I could perform a full review of this stuff. What
I can say however is that I've looked at the latest version here (Patch against
HEAD, attachment 104120 [details] [diff] [review]) and it is all plausible and well from my point of view.
Also, in the bugzilla installation I'm administering, we are using some version
of your patch for quite a while without any complaints. So I hereby give you an
r=afranke in the sense of the rules that applied before the 2.14 release; but
please get a second r= from someone who is currently more active in bugzilla
development before checking them in. My feeling is that this feature probably
won't hurt anything or anyone. Hope that helps.

Note that I have bugmail turned off completely, so if you need a timely
response, please send me private mail. Sorry.

Comment 15

[Jouni Heikniemi]

Toms, it may take me a while to review this, since my unix test box is blown up
(had RH 8 installed recently). I need to get some Perl modules into it before
delving into this stuff. If you want this done quickly, ask for somebody else's
opinion. :-)

Comment 16

[Christian Reis]

Comment on attachment 104120 [details] [diff] [review]
Patch against HEAD

>--- Bugzilla/Search.pm	13 Oct 2002 04:26:12 -0000	1.21
>+++ Bugzilla/Search.pm	25 Oct 2002 07:40:22 -0000
>@@ -71,17 +71,17 @@
>     my @andlist;
> 
>     # First, deal with all the old hard-coded non-chart-based poop.
>-    if (lsearch($fieldsref, 'map_assigned_to.login_name') >= 0) {
>+    if (lsearch($fieldsref, 'map_assigned_to.login_name') >= 0 || lsearch($fieldsref, 'map_assigned_to.realname') >= 0) {
>         push @supptables, "profiles AS map_assigned_to";
>         push @wherepart, "bugs.assigned_to = map_assigned_to.userid";

Nit: wrapping this line (and the following two blocks) would make the code
somewhat more readable.

This looks good to go. I've applied against CVS HEAD and it works great (the
output is very nice, to be honest). I don't think this needs second-review.

Comment 17

[Toms Baugis]

Attachment: Patch against HEAD, enhanced readability

Nothing special, just made linebreak in search.pm to enhance code readability
as kiko said.

Comment 18

[Christian Reis]

I've retested this patch, and it looks great. Myk has agreed to get it in for
the bmo update, so I've checked it in.

/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.206; previous revision: 1.205
Checking in colchange.cgi;
/cvsroot/mozilla/webtools/bugzilla/colchange.cgi,v  <--  colchange.cgi
new revision: 1.32; previous revision: 1.31
Checking in Bugzilla/Search.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v  <--  Search.pm
new revision: 1.24; previous revision: 1.23
Checking in template/en/default/list/change-columns.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/change-columns.html.tmpl,v
 <--  change-columns.html.tmpl
new revision: 1.6; previous revision: 1.5
Checking in template/en/default/list/table.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/table.html.tmpl,v 
<--  table.html.tmpl
new revision: 1.8; previous revision: 1.7

Comment 19

[Christian Reis]

Comment on attachment 105015 [details] [diff] [review]
Patch against HEAD, enhanced readability

r=kiko
2xr=joel

Comment 20

[Christian Reis]

Thanks Toms, nice first patch.