627428 - Remove background from discovery pane to match about:addons colors

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Discovery Pane, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Attachment: screenshot

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b10pre) Gecko/20110119 Firefox/4.0b10pre ID:20110119030331

If you open the details pane of the get addons page, the currently used background color completely doesn't match the UI of the new addons manager. We should use the same grey background color as we have in the entry page.

See the screenshot for an example on OS X.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Asking for blocking because it's one feature we advertise with the new addons manager and it looks really bad atm.

Comment 2

[Dave Townsend [:mossop]]

Pretty visually striking, the main page is fine but the details seems wrong.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

Committed: https://github.com/jbalogh/zamboni/commit/11c8d3a3

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Henrik: is this fine now?

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

(In reply to comment #5)
> Henrik: is this fine now?

Which URL do I have to use? Is so rarely that I always forget about.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

I was being lazy -- it looks like this, now.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #6)
> (In reply to comment #5)
> > Henrik: is this fine now?
> 
> Which URL do I have to use? Is so rarely that I always forget about.

In about:config, change entries with |services.addons.mozilla.org| and |addons.mozilla.org| to addons.allizom.org.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Ah, missed to clear the cache. So in general it looks fine except the "Reviews" heading which still has a background set.

https://addons.allizom.org/en-US/firefox/discovery/addon/nightly-tester-tools/

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #9)
> Ah, missed to clear the cache. So in general it looks fine except the "Reviews"
> heading which still has a background set.
> 
> https://addons.allizom.org/en-US/firefox/discovery/addon/nightly-tester-tools/

See bug 628448.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Oh I see. So yeah. Then we are done here.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Verified fixed based on the above URL.