627996 - Menu bar bookmarks menu not correctly sized

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[betheking]

User-Agent:       Mozilla/5.0 (Windows NT 6.0; WOW64; rv:2.0b10pre) Gecko/20110121 Firefox/4.0b10pre
Build Identifier: Mozilla/5.0 (Windows NT 6.0; WOW64; rv:2.0b10pre) Gecko/20110121 Firefox/4.0b10pre

When using the bookmarks menu in the "old" menu bar, the menu isn't correctly sized and re-sized. Some items are needlessly truncated, so that "Bookmark This Page" reads "Bookmark This Pa..." and "Show All Bookmarks" reads "Show All Bookma...".

If you then add a bookmark (in the "menu root"), rather than increasing the height of the menu, up/down scroll arrows are added. Or, if the menu was large enough to show all bookmarks and you delete one, there's now an empty row at the end of the menu.

The bookmarks menu off the new titlebar button doesn't seem to be affected.

This happens with a fresh profile.

The nightly build from 2011-01-17 mostly works (2011-01-18 doesn't), but the bad behavior can be still be triggered by deleting a bookmark via the right-click menu in the bookmarks menu. After doing that, menu items are truncated and scroll arrows are added when new bookmark entries are added.

Reproducible: Always

Comment 1

[Alice0775 White]

confirmed
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b10pre) Gecko/20110121 Firefox/4.0b10pre ID:20110121030329

Comment 2

[betheking]

The problem starts with this build:
http://hg.mozilla.org/mozilla-central/rev/433213256ed1

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Is this a dupe of bug 627824?

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

betheking: can you please attach a screenshot of the issue?

Comment 5

[betheking]

Attachment: Screenshot showing truncated bookmarks menu text

Comment 6

[betheking]

Doesn't quite look like a dupe of bug 627824, as it wasn't just a problem of truncated text. The menu height wasn't increased/decreased as bookmarks were added or removed.

However, it is (mostly) fixed in the 2011-01-27 nightly build, perhaps thanks to the backout of bug 562138. Deleting a bookmark menu entry via the right-click menu still triggers it, so I attached a screenshot of what happens when you do that, and then add a new bookmark again.

Comment 7

[Raul Nicolae Malea]

Similar bug: https://bugzilla.mozilla.org/show_bug.cgi?id=629034

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

I don't think this blocks based on the reduced STR in comment 6; feel free to renominate if it begins to happen more frequently.

Comment 9

[random.devstuff]

I was not able to reproduce this bug in Nightly 15.0a1 (2012-04-30). Anyone else?

Comment 10

[Alice0775 White]

I cannot reproduce in Firefox10.0ESR and 12.0 and later.

Comment 11

[Mark Banner (:standard8)]

Closing as WFM based on the last two old comments.