628106 - dragging in open space in a group should select tabs in the group, not drag the whole group

Status: RESOLVED WONTFIX

(Firefox Graveyard :: Panorama, defect, P4)

Description

[Dietrich Ayala (:dietrich)]

in the latest nightly, after seeing my tabs were jumbled across my two groups, i tried to put things right.

however, when i try to select tabs to drag from group to group, i noticed the cursor was already the closed fist, as if i'd already dragged something and was preparing to drop.

then when i tried anyway, it moved the group itself around the tabview.

Comment 1

[Michael Yoshitaka Erlewine [:mitcho]]

So, you drop a tab (A) into a group, then the hand is still closed, and then what happens? You try to pick up another tab (B) and (A) moves there?

Is this just an issue of the visual feedback (the cursor type) or actually wrong behavior?

We'd appreciate concrete STR and/or a video. Thanks!

Comment 2

[Dietrich Ayala (:dietrich)]

1. Put the mouse over a group, but not over a tab in that group. The cursor is the closed hand.

This already seems wrong, from a visual feedback perspective. IIRC, you used to be able select tabs within a group, in order to drag them out (or to a different group).

2. Try to select multiple tabs, in order to drag them into a different group (or whatever).

Expected: multiple tabs in the group are selected.

Actual: whole group is dragged in tab view.

If this behavior is by design, then this bug could be renamed to "dragging in open space in a group should select tabs in the group, not drag the whole group".

Comment 3

[Michael Yoshitaka Erlewine [:mitcho]]

(In reply to comment #2)
> 1. Put the mouse over a group, but not over a tab in that group. The cursor is
> the closed hand.
> 
> This already seems wrong, from a visual feedback perspective. IIRC, you used to
> be able select tabs within a group, in order to drag them out (or to a
> different group).

Indeed, this does seem wrong, but it feels like a CSS issue. This is working fine (i.e., open hand) on the Mac (https://skitch.com/mitcho/rk32d/minefield-group-your-tabs). Tim, can you confirm on Linux?

> 2. Try to select multiple tabs, in order to drag them into a different group
> (or whatever).
> 
> Expected: multiple tabs in the group are selected.
> 
> Actual: whole group is dragged in tab view.
> 
> If this behavior is by design, then this bug could be renamed to "dragging in
> open space in a group should select tabs in the group, not drag the whole
> group".

Unfortunately, this is by design. We have a bug, bug 583435, for selecting multiple tabs in a group.

I'll reform this bug into the first issue.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

(In reply to comment #3)
> Indeed, this does seem wrong, but it feels like a CSS issue. This is working
> fine (i.e., open hand) on the Mac
> (https://skitch.com/mitcho/rk32d/minefield-group-your-tabs). Tim, can you
> confirm on Linux?

Yep the same for me. The cursor value is 'move' for groups. So I have a little hand that looks like the 'pointer' value but has no finger stretched out :) On Windows that should be the cross with arrows in all four directions. On Mac this is just the default cursor?

Comment 5

[Ian Gilman [:iangilman]]

On Mac it should be a hand with all fingers stretched out, to indicate that you can drag the group. Despite Mitcho's screenshot which shows the arrow (is that really what you saw, Mitcho, or is your screen capture app changing the cursor on you?). 

On windows it should be the cross with arrows, and I believe that's what it is.

On Linux it probably shouldn't be a closed hand, unless that's the standard linux "you can drag this" indication. Is there another cursor that indicates you can drag something?

So, sounds like this bug requires a Linux-only CSS change to get that pointer correct.

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

(In reply to comment #5)
> On Linux it probably shouldn't be a closed hand, unless that's the standard
> linux "you can drag this" indication. Is there another cursor that indicates
> you can drag something?

AFAIK this is the standard cursor to indicate you can move something around. At least on Ubuntu.

Comment 7

[Dietrich Ayala (:dietrich)]

The behavior I reported is by design, changing the summary to fit.

Comment 8

[Michael Yoshitaka Erlewine [:mitcho]]

(In reply to comment #5)
> On Mac it should be a hand with all fingers stretched out, to indicate that you
> can drag the group. Despite Mitcho's screenshot which shows the arrow (is that
> really what you saw, Mitcho, or is your screen capture app changing the cursor
> on you?). 

Oh no! I'm sorry for the confusion... I do see a hand with five fingers, but for some reason I'm unable to take any sort of screenshot of it in action. :( Sorry about that.

Comment 9

[Kevin Hanes]

Moving this to the future for consideration. Note that we have bugs (bug 583435 being one) for selecting multiple tabs. If you feel this is enough like that, please dupe. As it is, I am not sure that tab selection takes precedence over group movement.

Comment 10

[Justin Dolske [:Dolske]]

Panorama has been removed from Firefox 45, currently in Beta and scheduled for release on March 7th. As such, I'm closing all existing Panorama bugs.

If you are still using Panorama, you will see a deprecation message in Firefox 44, and when 45 is released your tab group data will be migrated to bookmarks, with a folder for each group. There are also a few addons offering similar functionality.

See https://support.mozilla.org/en-US/kb/tab-groups-removal for more info.

We're removing Panorama because it has extremely low usage (about 0.01% of users), and has a large number of bugs and usability issues. The cost of fixing all those issues is far too high to justify, and so we'll instead be focusing our time and energy on improving other parts of Firefox.