628107 - drag and drop of groups has become really slow and chunky

Status: RESOLVED WONTFIX

(Firefox Graveyard :: Panorama, defect, P2)

Comment 1

[Dietrich Ayala (:dietrich)]

it's delayed enough that things are unusable.

Comment 2

[Michael Yoshitaka Erlewine [:mitcho]]

This is on trunk? Nightly? It's working fine for me on Mac...

Do you have a bajillion groups open or something? It was working fine before?

Comment 3

[Dietrich Ayala (:dietrich)]

Yep, trunk nightly.

I only have 3 groups, but probably 70 tabs. I don't know if it was fine before or not, since I don't go into the tabview UI very often (only a lot lately, since my groups keep getting horked and I have to fix them).

Comment 4

[Michael Yoshitaka Erlewine [:mitcho]]

Tim, are you seeing the same on linux?

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Mhhh.. It's okay and usable for me. My machine is not the newest/fastest anymore but for me there's no noticeable regression. Maybe we could get Dietrich to do some profiling to know what his machine is doing while dragging groups around? :)

Comment 6

[George Carstoiu]

Mozilla/5.0 (Windows NT 6.1; rv:2.0b10pre) Gecko/20110125 Firefox/4.0b10pre

Moving around groups tends to be bumpy. Tried it on WinXP and Win 7.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Dietrich: need specs on your hardware; if it's OSX running 10.5, we recently turned off GL, which might be slowing things down there. Either way, I don't think this blocks, but for the purposes of investigation, it'd help.

Comment 8

[Dietrich Ayala (:dietrich)]

Lenovo T400s, Intel integrated graphics, 4gb RAM.

Comment 9

[Michael Yoshitaka Erlewine [:mitcho]]

If someone could do some js and/or shark profiling on this, it would be appreciated. My guess is that either, indeed, we're spending time with graphics and drawing, or we're using cycles in the snapping code.

One way to quickly see whether it's the snapping which is costly is to see if dragging performance improves greatly if you hold down the option key and drag groups around. This turns off the "snapping" to other groups and tabs.

Also, if someone could identify a regression range, that would also be helpful.

Comment 10

[Michael Yoshitaka Erlewine [:mitcho]]

(In reply to comment #9)
> hold down the option key and drag
> groups around. This turns off the "snapping" to other groups and tabs.

Sorry, I misspoke. The metaKey... on Mac this is command...

Comment 11

[Dietrich Ayala (:dietrich)]

Video: https://people.mozilla.com/~dietrich/tabview.ogv

Note how the dragging is seconds behind my mouse actions, and the snap lines don't show up ever.

(I'm not holding down ctrl during this. Doing so did not change the behavior.)

Comment 12

[Michael Yoshitaka Erlewine [:mitcho]]

(In reply to comment #11)
> Video: https://people.mozilla.com/~dietrich/tabview.ogv

Wow, this strikes me as particularly bad. It is not what I see on my mac with recent builds. :/

Would it be possible to get some profiling?

Comment 13

[Tim Taubert [:ttaubert] (inactive)]

Dietrich, does this still happen for you with the latest nightly? I'm curious because bug 606148 has landed yesterday.

Comment 14

[Ian Gilman [:iangilman]]

Dietrich, in the video you're dragging a stacked group... is it the same for unstacked groups?

Comment 15

[Dietrich Ayala (:dietrich)]

Still happening, and happens for any type of group. If you come up with a patch I could apply that would dump out profiling information, I'd be glad to apply it and get that info for you.

Comment 16

[Michael Yoshitaka Erlewine [:mitcho]]

The final beta window has essentially closed, but I would be happy if we could do some profiling for this post beta12, though a fix itself (if necessary) most likely can't happen for fx4. :(

Comment 17

[Dietrich Ayala (:dietrich)]

If the fix is not large footprint, seems not risky, has great test coverage, then drivers are more likely to take it. I wouldn't let the risk of it not being taken slow any momentum for fixing this.

Comment 18

[Kevin Hanes]

bugspam

Comment 19

[Tim Taubert [:ttaubert] (inactive)]

bugspam

Comment 20

[Tim Taubert [:ttaubert] (inactive)]

bugspam

Comment 21

[Tim Taubert [:ttaubert] (inactive)]

bugspam

(Fx7 was branched, removing open bugs from Fx7 meta bug, we won't create new meta bugs for upcoming Fx versions)

Comment 22

[Tim Taubert [:ttaubert] (inactive)]

We're not going to address this with Panorama being slated for removal.