628173 - [D3D9] Panorama previews are blurry with hardware acceleration enabled

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Marcia Knous [:marcia]]

Attachment: Tab candy on XP

Seen while running Mozilla/5.0 (Windows NT 5.1; rv:2.0b10) Gecko/20100101 Firefox/4.0b10

STR:
1. Load three tabs, with cnn.com, nypost.com and addons.mozilla.org
2. View-> Tab Groups

Compare the screenshot to what you see on Windows 7 with the equivalent build. There is a noticeable difference in clarity of the content inside the tabs

Comment 1

[Marcia Knous [:marcia]]

Attachment: Tab candy on Windows 7, same pages

Comment 2

[Marcia Knous [:marcia]]

The XP machine I am using was recently re-imaged, so it is relatively clean with the standard Win XP theme. The Windows 7 machine has the Aero theme.

Comment 3

[juan becerra [:juanb]]

Marcia, can you check for a regression range? I was able to see this on my XP test run, but I didn't see it on a Windows2000 machine.

Comment 4

[juan becerra [:juanb]]

Nominating because this problems makes tabs indistinguishable from one another in Panorama under XP.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

--> Core::Graphics

FWIW, I don't think this blocks for the effects on TabCandy alone, but it may indicate a deeper problem with HW Accel in XP, so over to Graphics for triage!

Comment 6

[Jonathan Kew [:jfkthame]]

Looks like the XP tab images are drawn using completely wrong colors for the text in many cases - e.g. the title and the Categories sidebar on the Add-ons for Firefox page seems to have painted white text instead of dark blue. (But oddly, the Popular Tags sidebar hasn't done the same thing.)

Comment 7

[Ian Gilman [:iangilman]]

Bug 627838 may be a duplicate of this. Do you get the same problem if the thumbnails are large (over 150 pixels wide)? We have a different code path depending on the size.

Comment 8

[Bas Schouten (:bas.schouten)]

This issue reproduces on Windows 7 when Direct2D is disabled and D3D9 layers is used. I will triage this in the coming days.

Comment 9

[Siddhartha Dugar [:sdrocking]]

There hasn't been any activity here lately. :(

Comment 10

[Bas Schouten (:bas.schouten)]

This got delayed a bit because of work on hardblockers. I do still intend to look at this soon.

Comment 12

[Tim Meader]

Hopefully this can be made a hard blocker, since the complete absence of text content for anything above 150px is a larger issue than just blurriness?

Comment 13

[Bas Schouten (:bas.schouten)]

Attachment: Respect format of source surface

We're currently ignoring the format of the source surface in CanvasLayerD3D9. This is bad. This patch addresses the issue.

Comment 14

[Bas Schouten (:bas.schouten)]

Attachment: Part 2: Match D3D9 and D3D10 styles for hasAlpha

As requested per IRC this lets D3D10 match the style introduced in D3D9.

Comment 15

[Bas Schouten (:bas.schouten)]

http://hg.mozilla.org/mozilla-central/rev/d1c5def46796
http://hg.mozilla.org/mozilla-central/rev/8379db2b16d2

Comment 16

[Alex Lakatos[:AlexLakatos]]

Verified on Build identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b12) Gecko/20100101 Firefox/4.0b12