Closed
Bug 628867
Opened 13 years ago
Closed 13 years ago
browser_tabview_bug586553.js loads about:credits, which hits the network
Categories
(Firefox Graveyard :: Panorama, defect, P4)
Firefox Graveyard
Panorama
Tracking
(status1.9.2 unaffected, status1.9.1 unaffected)
RESOLVED
FIXED
Firefox 4.0b11
Tracking | Status | |
---|---|---|
status1.9.2 | --- | unaffected |
status1.9.1 | --- | unaffected |
People
(Reporter: philor, Assigned: ttaubert)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
2.18 KB,
patch
|
Details | Diff | Splinter Review |
Despite seeming like something perfectly safe to load in a test, about:credits is actually just another name for http://www.mozilla.org/credits/, so browser_tabview_bug586553.js is hitting the network.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → tim.taubert
Assignee | ||
Updated•13 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•13 years ago
|
||
I spotted another about:credits tab used in a session store test and replaced that with about:mozilla. Pushed to try.
Attachment #507014 -
Flags: review?(ian)
Reporter | ||
Comment 2•13 years ago
|
||
I certainly won't object, but I filed bug 628866 for the browser_579868.js one, so don't forget to close it when you land.
Assignee | ||
Comment 3•13 years ago
|
||
Ok, I took that one, too.
Assignee | ||
Comment 4•13 years ago
|
||
Passed try.
Comment 5•13 years ago
|
||
Comment on attachment 507014 [details] [diff] [review] patch v1 Looks good
Attachment #507014 -
Flags: review?(ian) → review+
Assignee | ||
Comment 6•13 years ago
|
||
Attachment #507014 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 7•13 years ago
|
||
Pushed. https://hg.mozilla.org/mozilla-central/rev/037c029a2329
Keywords: checkin-needed
Target Milestone: --- → Firefox 4.0b11
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•13 years ago
|
status1.9.1:
--- → unaffected
status1.9.2:
--- → unaffected
Updated•13 years ago
|
Whiteboard: [qa-]
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•