Closed Bug 628867 Opened 13 years ago Closed 13 years ago

browser_tabview_bug586553.js loads about:credits, which hits the network

Categories

(Firefox Graveyard :: Panorama, defect, P4)

Product:
Firefox Graveyard
Component:
Panorama
Type:
defect

Tracking

(status1.9.2 unaffected, status1.9.1 unaffected)

Status:
RESOLVED FIXED
Milestone:
Firefox 4.0b11
Tracking Flags:
Tracking Status
status1.9.2 --- unaffected
status1.9.1 --- unaffected

People

(Reporter: philor, Assigned: ttaubert)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

patch for checkin
2.18 KB, patch
Details | Diff | Splinter Review 
Despite seeming like something perfectly safe to load in a test, about:credits is actually just another name for http://www.mozilla.org/credits/, so browser_tabview_bug586553.js is hitting the network.
Assignee: nobody → tim.taubert
Status: NEW → ASSIGNED
Attached patch patch v1 (obsolete) — — Splinter Review 
I spotted another about:credits tab used in a session store test and replaced that with about:mozilla. Pushed to try.
Attachment #507014 - Flags: review?(ian)
I certainly won't object, but I filed bug 628866 for the browser_579868.js one, so don't forget to close it when you land.
Blocks: 628866
Ok, I took that one, too.
Passed try.
Comment on attachment 507014 [details] [diff] [review]
patch v1

Looks good
Attachment #507014 - Flags: review?(ian) → review+

        Attachment #507014 -
        Attachment is obsolete: true

    
  
Keywords: checkin-needed
Blocks: 585689
Priority: -- → P4

    
    

    
  
Pushed.

https://hg.mozilla.org/mozilla-central/rev/037c029a2329
Keywords: checkin-needed
Target Milestone: --- → Firefox 4.0b11

    
  
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Product: Firefox → Firefox Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: