629472 - Parts of windowless, transparent nspluginwrapper/Flash plugin not repainted correctly

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

STR
 (1) Load the URL

The little purple ball is painted by the flash instance.  On my gtk2 desktop, I only see the ball drawn when it's between the north and west points of the star.  It's supposed to be drawn all throughout the box, because the applet is at a higher z-index than the star image and background (if I read the source correctly).

3.6 works as expected.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Regression in rendering from 3.6.

Comment 2

[Timothy Nikkel (:tnikkel)]

Linux only or not?

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Kevin reports this working correctly on windows in beta10.

Comment 4

[Timothy Nikkel (:tnikkel)]

Regression range
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8528ce3f97ce&tochange=198709160138

Comment 5

[Timothy Nikkel (:tnikkel)]

Perhaps one of Oleg's changesets?

Comment 6

[Karl Tomlinson (:karlt)]

Works fine here with "Shockwave Flash 10.3 d162".
cjones has 10.1 r102 and nspluginwrapper.
tn are you using nspluginwrapper?

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

FTR, with "10.3 d162" the problem goes away.  But, with the WIP patches in bug 626602 with "10.3 d162", the problem comes *back*.

Comment 8

[Timothy Nikkel (:tnikkel)]

(In reply to comment #6)
> tn are you using nspluginwrapper?

Yes, I _think_ so. Not sure how to check. I have the same version as cjones in comment 6 though.

Comment 9

[Timothy Nikkel (:tnikkel)]

about:plugins says
File: npwrapper.libflashplayer.so

Comment 10

[Johnny Stenback (:jst)]

Should be fixed, but this won't be a priority for 2.0.

Comment 12

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(In reply to comment #7)
> FTR, with "10.3 d162" the problem goes away.  But, with the WIP patches in bug
> 626602 with "10.3 d162", the problem comes *back*.

In case it helps, my patch had made it so that

     if (mIsTransparent && (GetQuirks() & PluginModuleChild::QUIRK_FLASH_EXPOSE_COORD_TRANSLATION)) {

in PluginInstanceChild stopped running, unintentionally.  Fixing that made the bug go away again.

Comment 13

[Karl Tomlinson (:karlt)]

Thanks.

Does nspluginwrapper pass through the "Shockwave Flash 10.1 r102" in-tact?
i.e. is that what about:plugins says for "Version:"?

Comment 14

[Timothy Nikkel (:tnikkel)]

From my about:plugins, the complete flash section:

Shockwave Flash

    File: npwrapper.libflashplayer.so
    Version: 
    Shockwave Flash 10.1 r102

MIME Type 	Description 	Suffixes
application/x-shockwave-flash 	Shockwave Flash 	swf
application/futuresplash 	FutureSplash Player 	spl

Comment 15

[Henri Sivonen (:hsivonen)]

To answer karlt's IRC question about whether I can invoke the Flash Player context menu on http://www.qwiki.com/q/#!/Finland : Yes, the plug-in's context menu is invokable as usual.

http://www.communitymx.com/content/source/E5141/wmodetrans.htm shows me the same problem that is described in comment 0. In this case, the misclipping is constant. In the qwiki case, the misclipping varies as the swf plays.

Comment 16

[Dave Miller [:justdave]]

FWIW, I'm also seeing this, so if there's anything I can do to help debug, let me know.  In my case, I'm seeing things that feel like this same issue while trying to use embedded video players on Crunchyroll and Hulu.  The videos play fine, but the controls black out when you mouse over them.  Everything works fine in full-screen mode, it only blacks out when viewed embedded within the browser window.

Comment 18

[Timothy Nikkel (:tnikkel)]

Bug 648454 contains a description of what is likely the problem here.

Comment 19

[Matěj Cepl]

Attachment: screencast of the reproduction

Just a good reproducer of the issue I see on http://jsbin.tumblr.com/post/4605622638/a-demo-of-the-simple-drag-and-drop-functionality

Comment 20

[Karl Tomlinson (:karlt)]

Based on Bug 603397 comment 13 and bug 648454, it sounds like this is caused
by the switch from using NP_GetValue to NPPluginFuncs::getvalue for the Flash
NPPVpluginDescriptionString test.
http://hg.mozilla.org/mozilla-central/rev/6bf95d58032e

This was fortunate enough to work fine with Flash Player directly (apparently
because Flash handles both methods the same), but what really confuses
nspluginwrapper is that NPPluginFuncs::getvalue is called (incorrectly) before
newp has been called to construct the instance.

Comment 21

[Karl Tomlinson (:karlt)]

Attachment: revert to using NP_GetValue

Can you check that this fixes the issue, please Timothy?

GetPluginInfo does more work than necessary but I think it is simpler/tidier
than the platform-specific FindFunctionSymbol, etc., and moving other
platforms to the plugin-based GetPluginInfo rather than the mimetype-based
InitQuirksModes() is probably the way to go in the future.

Currently AddQuirk() and InitQuirksModes() work (awkwardly) with
QUIRKS_NOT_INITIALIZED because they deal with different plugins on X11, but
InitQuirksModes is already awkward with quirk-free plugins initializing to
QUIRKS_NOT_INITIALIZED.

Comment 22

[Timothy Nikkel (:tnikkel)]

That patch fixes it for me!

Comment 23

[Karl Tomlinson (:karlt)]

Attachment: revert to using NP_GetValue 1.0.1

Thanks, Timothy.  Updated patch to 1cc4d287d0b8.

Comment 24

[Karl Tomlinson (:karlt)]

BTW, I didn't null check .fDescription because nsPluginTag makes the same assumption that it is non-null if GetPluginInfo succeeded.
http://hg.mozilla.org/mozilla-central/annotate/3cdd96a6d372/modules/plugin/base/src/nsPluginTags.cpp#l110
http://hg.mozilla.org/mozilla-central/annotate/1cc4d287d0b8/modules/plugin/base/src/nsPluginTags.h#l112
http://hg.mozilla.org/mozilla-central/annotate/3cdd96a6d372/modules/plugin/base/src/nsPluginHost.cpp#l2289

Comment 25

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 528263 [details] [diff] [review]
revert to using NP_GetValue 1.0.1

>+    // Maemo flash can render plugin with any provided rectangle and not
>+    // require this quirk.

Do you mind fixing the grammar here while you're at it?

Comment 26

[Matěj Cepl]

Internesting ... When looking at http://live.twit.tv I see clearly Bitstream (1Mbps), but Bitstream (400 Kbps) is pretty bad.

Comment 27

[Matěj Cepl]

(In reply to comment #26)
> Internesting ... When looking at http://live.twit.tv I see clearly Bitstream
> (1Mbps), but Bitstream (400 Kbps) is pretty bad.

Yes, I can confirm that with nspluginwrapper-1.3.2-1.fc15 I can play both of these streams without any problems.

Thank you

Comment 28

[Karl Tomlinson (:karlt)]

(Including grammar touch up:)
http://hg.mozilla.org/mozilla-central/rev/c26ec595c923