598112 - UseAsyncPainting, always return FALSE because plugin mRunning == FALSE

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Oleg Romashin (:romaxa)]

Attachment: Disable mRunning check, and fix typo bug.

I found that recent change with new UseAsyncPainting, does not work correctly, because mRunning check
http://mxr.mozilla.org/mozilla-central/source/modules/plugin/base/src/nsNPAPIPluginInstance.cpp#881

is FALSE.

Comment 1

[Oleg Romashin (:romaxa)]

Looks like try server is happy.with this fix

Comment 2

[Doug Turner (:dougt)]

this cause permaorange of 597742.

Comment 3

[Oleg Romashin (:romaxa)]

https://bugzilla.mozilla.org/show_bug.cgi?id=598262 - here is the new bug about it

Comment 4

[Oleg Romashin (:romaxa)]

Attachment: Make reftest pass

Josh can you check this?
See comment in bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=598262#c4

Comment 5

[Oleg Romashin (:romaxa)]

http://hg.mozilla.org/mozilla-central/rev/94b9c4cb2312
http://hg.mozilla.org/mozilla-central/rev/9b2c5eb8641e

Comment 6

[Zio_Fede]

It seems that these two patches triggered this bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=599476

Comment 7

[Doug Turner (:dougt)]

Oleg?

Comment 8

[Daniel Holbert [:dholbert]]

(Looks like Oleg's on it, over on bug 599476)

Comment 9

[juan becerra [:juanb]]

It looks like this caused bug 606481.