629577 - non-libxul builds broken by changes to History, unresolved symbol nsContentUtils::sXPConnect

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Brian Birtles (:birtles)]

Changeset http://hg.mozilla.org/mozilla-central/rev/c03b00587c5d from bug 606966 appears to have broken non-libxul builds, reintroducing bug 627474.

Specifically I'm seeing:

History.obj : error LNK2001: unresolved external symbol "private: static class nsIXPConnect * nsContentUtils::sXPConnect" (?sXPConnect@nsContentUtils@@0PAVnsIXPConnect@@A)
places.dll : fatal error LNK1120: 1 unresolved externals

c:\moz\src\config\rules.mk:955:0: command 'c:/mozilla-build/python/python.exe c:/moz/src/build/pymake/pymake/../make.py -C src libs' failed, return code 2
c:\moz\src\config\rules.mk:888:0: command 'c:/mozilla-build/python/python.exe c:/moz/src/build/pymake/pymake/../make.py -C places libs' failed, return code 2
c:\moz\src\config\rules.mk:888:0: command 'c:/mozilla-build/python/python.exe c:/moz/src/build/pymake/pymake/../make.py -C components libs' failed, return code 2
c:\moz\src\config\rules.mk:785:0: command 'c:/mozilla-build/python/python.exe c:/moz/src/build/pymake/pymake/../make.py -C toolkit libs' failed, return code 2
c:\moz\src\config\rules.mk:796:0: command 'c:/mozilla-build/python/python.exe c:/moz/src/build/pymake/pymake/../make.py libs_tier_platform' failed, return code 2
c:\moz\src\config\rules.mk:746:0: command 'c:/mozilla-build/python/python.exe c:/moz/src/build/pymake/pymake/../make.py  tier_platform' failed, return code 2
c:\moz\src\client.mk:345:0: command 'c:/mozilla-build/python/python.exe c:/moz/src/build/pymake/pymake/../make.py  -C ../obj-debug' failed, return code 2

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Let's see who reviews this sooner!

Comment 2

[Ginn Chen]

You need to add
-I$(topsrcdir)/js/src/xpconnect/src
to Makefile.in.

Comment 3

[(no longer active)]

Attachment: Patch (v2)

The first patch was actually wrong, even with the Makefile.in changes which were not included because of a missing qref.  This one is the right approach, I think.

Comment 4

[Marco Bonardo [:mak]]

nit: +    nsresult rv;
+    nsCOMPtr<nsIXPConnect> xpc(do_GetService(kXPConnectCID, &rv));
+    NS_ENSURE_SUCCESS(rv, nsnull);
could you do (pseudocode)
nsCOMPtr xpc = do_getService...
NS_ENSURE_TRUE(xpc, nsnull)
nsresult rv xpc->GetWrapped...
it's a more common style in our code.

Comment 5

[(no longer active)]

Attachment: Patch (v3)

Addressed the nits.

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 507878 [details] [diff] [review]
Patch (v3)

per discussion on IRC, r+ with a follow-up to cache xpconnect in Services.h

Comment 7

[(no longer active)]

Followup filed as bug 629697.

Comment 8

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/e102c0b5f6f0