630081 - Undo close group buttons should not act as snapping targets

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect, P4)

Description

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Snapping to an undo close group button

Undo close group buttons currently act as snapping targets, and have the wrong range (in the screenshot, vertical extent) to boot. This should be turned off.

This should just be a matter of calling removeTrenches on hiding the group, and setTrenches on undoing the group close.

Comment 1

[Kevin Hanes]

bugspam

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Hope I'll not have to write a test for this. This is a really small patch :) And the patch will be kind of hard to write.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 524319 [details] [diff] [review]
patch v1

Correction: I meant that the test will be hard to write, anyway:

Passed try:

http://tbpl.mozilla.org/?tree=MozillaTry&pusher=[e-mail]&rev=aedb58c7c078

Comment 4

[Ian Gilman [:iangilman]]

Comment on attachment 524319 [details] [diff] [review]
patch v1

This is a minor enough issue I don't think we need a test.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch for checkin

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/081223e6e3e8

Comment 7

[George Carstoiu]

Verified with Mozilla/5.0 (Windows NT 5.1; rv:2.2a1pre) Gecko/20110410 Firefox/4.2a1pre