Undo close group buttons should not act as snapping targets

VERIFIED FIXED in Firefox 5

Status

P4
normal
VERIFIED FIXED
8 years ago
2 years ago

People

(Reporter: mitcho, Assigned: ttaubert)

Tracking

Trunk
Firefox 5

Details

Attachments

(2 attachments, 1 obsolete attachment)

Created attachment 508299 [details]
Snapping to an undo close group button

Undo close group buttons currently act as snapping targets, and have the wrong range (in the screenshot, vertical extent) to boot. This should be turned off.

This should just be a matter of calling removeTrenches on hiding the group, and setTrenches on undoing the group close.

Comment 1

8 years ago
bugspam
Target Milestone: Future → ---
(Assignee)

Updated

8 years ago
Assignee: nobody → tim.taubert
Status: NEW → ASSIGNED
Target Milestone: --- → Future
(Assignee)

Comment 2

8 years ago
Created attachment 524319 [details] [diff] [review]
patch v1

Hope I'll not have to write a test for this. This is a really small patch :) And the patch will be kind of hard to write.
Attachment #524319 - Flags: feedback?(raymond)
Attachment #524319 - Flags: review?(ian)
Attachment #524319 - Flags: feedback?(raymond)
Attachment #524319 - Flags: feedback+
(Assignee)

Comment 3

8 years ago
Comment on attachment 524319 [details] [diff] [review]
patch v1

Correction: I meant that the test will be hard to write, anyway:

Passed try:

http://tbpl.mozilla.org/?tree=MozillaTry&pusher=tim.taubert@gmx.de&rev=aedb58c7c078
Comment on attachment 524319 [details] [diff] [review]
patch v1

This is a minor enough issue I don't think we need a test.
Attachment #524319 - Flags: review?(ian) → review+
(Assignee)

Updated

8 years ago
Version: unspecified → Trunk
(Assignee)

Comment 5

8 years ago
Created attachment 524461 [details] [diff] [review]
patch for checkin
Attachment #524319 - Attachment is obsolete: true
(Assignee)

Updated

8 years ago
Keywords: checkin-needed

Comment 6

8 years ago
http://hg.mozilla.org/mozilla-central/rev/081223e6e3e8
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: Future → Firefox4.2

Comment 7

8 years ago
Verified with Mozilla/5.0 (Windows NT 5.1; rv:2.2a1pre) Gecko/20110410 Firefox/4.2a1pre
Status: RESOLVED → VERIFIED

Updated

8 years ago
Target Milestone: Firefox5 → Firefox 5
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.