Closed Bug 630081 Opened 9 years ago Closed 9 years ago

Undo close group buttons should not act as snapping targets

Categories

(Firefox Graveyard :: Panorama, defect, P4)

defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 5

People

(Reporter: mitcho, Assigned: ttaubert)

References

Details

Attachments

(2 files, 1 obsolete file)

Undo close group buttons currently act as snapping targets, and have the wrong range (in the screenshot, vertical extent) to boot. This should be turned off.

This should just be a matter of calling removeTrenches on hiding the group, and setTrenches on undoing the group close.
bugspam
Target Milestone: Future → ---
Assignee: nobody → tim.taubert
Status: NEW → ASSIGNED
Target Milestone: --- → Future
Attached patch patch v1 (obsolete) — Splinter Review
Hope I'll not have to write a test for this. This is a really small patch :) And the patch will be kind of hard to write.
Attachment #524319 - Flags: feedback?(raymond)
Attachment #524319 - Flags: review?(ian)
Attachment #524319 - Flags: feedback?(raymond)
Attachment #524319 - Flags: feedback+
Comment on attachment 524319 [details] [diff] [review]
patch v1

Correction: I meant that the test will be hard to write, anyway:

Passed try:

http://tbpl.mozilla.org/?tree=MozillaTry&pusher=tim.taubert@gmx.de&rev=aedb58c7c078
Comment on attachment 524319 [details] [diff] [review]
patch v1

This is a minor enough issue I don't think we need a test.
Attachment #524319 - Flags: review?(ian) → review+
Version: unspecified → Trunk
Attachment #524319 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/081223e6e3e8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: Future → Firefox4.2
Verified with Mozilla/5.0 (Windows NT 5.1; rv:2.2a1pre) Gecko/20110410 Firefox/4.2a1pre
Status: RESOLVED → VERIFIED
Target Milestone: Firefox5 → Firefox 5
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.