[D2D] consistent few-px failures in SVG-as-an-image tests w/ scaled circles, on Windows with D2D

RESOLVED FIXED

Status

()

Core
SVG
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: Robert Longson)

Tracking

Trunk
All
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
On Windows with D2D enabled, some SVG-as-an-image tests fail (i.e. don't quite render the same as an equivalent <embed> or inline SVG).

Generally it's just a few pixels of difference, along one edge of a circle, with the difference being very slight (not really noticeable visually).

These tests are currently marked "random-if(d2d)" (soon to be "fails-if(d2d)", after bug 632754 lands, since they seem to reliably fail (and a few reliably pass).

I'm filing this bug on figuring out what's going wrong here and fixing it if possible.
(Assignee)

Comment 1

6 years ago
Created attachment 532466 [details] [diff] [review]
crispEdges
Attachment #532466 - Flags: review?(dholbert)
(Assignee)

Comment 2

6 years ago
Should fix all the other blocked bugs too.
(Reporter)

Comment 3

6 years ago
Comment on attachment 532466 [details] [diff] [review]
crispEdges

Awesome, I hope this works! :)
Attachment #532466 - Flags: review?(dholbert) → review+
(Assignee)

Comment 4

6 years ago
Try server says it the bees knees... http://tbpl.mozilla.org/?tree=Try&rev=f53d142be9b6 the Android reftest failures there are because that version of the patch didn't mark the reftests as passing.
Keywords: checkin-needed
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
(Assignee)

Comment 5

6 years ago
pushed http://hg.mozilla.org/mozilla-central/rev/35de370ddd83
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Assignee: nobody → longsonr
(Assignee)

Updated

6 years ago
Duplicate of this bug: 594815
You need to log in before you can comment on or make changes to this bug.