633308 - Add toString method to various Panorama objects

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect, P4)

Description

[Michael Yoshitaka Erlewine [:mitcho]]

When developing tests, we often see failures like "Got [object Object], expected [object Object]" which is not particularly helpful. We need TabItem, GroupItem, and perhaps other objects to have custom toString methods with some minimally identifying debug information.

Comment 1

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch v1

Comment 2

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch v1.1

Comment 3

[Michael Yoshitaka Erlewine [:mitcho]]

Note to approvers: This is purely the addition of toString methods to our objects which will help us track down objects when debugging tests.

Pushed to try just in case: http://tbpl.mozilla.org/?tree=MozillaTry&rev=fd11ee14cb24

Comment 4

[Michael Yoshitaka Erlewine [:mitcho]]

Passed try.

Comment 5

[Johnathan Nightingale [:johnath]]

Comment on attachment 515357 [details] [diff] [review]
Patch v1.1

I love making tests easier to write, but this can land after FF4, doesn't need to add to the FF4 pile.

Comment 6

[Michael Yoshitaka Erlewine [:mitcho]]

Thanks johnath. Punting to the future.

Comment 7

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/f95cccd25069

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 515357 [details] [diff] [review]
Patch v1.1

minusing for mozilla2.0 again: this isn't fixing a user-facing regression or security bug so we don't see why this can't wait for FF5