Closed Bug 633308 Opened 9 years ago Closed 9 years ago

Add toString method to various Panorama objects

Categories

(Firefox Graveyard :: Panorama, defect, P4)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 5

People

(Reporter: mitcho, Assigned: mitcho)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

When developing tests, we often see failures like "Got [object Object], expected [object Object]" which is not particularly helpful. We need TabItem, GroupItem, and perhaps other objects to have custom toString methods with some minimally identifying debug information.
Priority: -- → P4
Assignee: nobody → mitcho
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #515356 - Flags: review?(ian)
Attached patch Patch v1.1Splinter Review
Attachment #515356 - Attachment is obsolete: true
Attachment #515357 - Flags: review?(ian)
Attachment #515356 - Flags: review?(ian)
Attachment #515357 - Flags: review?(ian) → review+
Attachment #515357 - Flags: approval2.0?
Note to approvers: This is purely the addition of toString methods to our objects which will help us track down objects when debugging tests.

Pushed to try just in case: http://tbpl.mozilla.org/?tree=MozillaTry&rev=fd11ee14cb24
Passed try.
Comment on attachment 515357 [details] [diff] [review]
Patch v1.1

I love making tests easier to write, but this can land after FF4, doesn't need to add to the FF4 pile.
Attachment #515357 - Flags: approval2.0? → approval2.0-
Thanks johnath. Punting to the future.
Blocks: 603789
No longer blocks: 585689
Target Milestone: --- → Future
Attachment #515357 - Flags: approval2.0- → approval2.0?
http://hg.mozilla.org/mozilla-central/rev/f95cccd25069
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: Future → Firefox4.2
Comment on attachment 515357 [details] [diff] [review]
Patch v1.1

minusing for mozilla2.0 again: this isn't fixing a user-facing regression or security bug so we don't see why this can't wait for FF5
Attachment #515357 - Flags: approval2.0? → approval2.0-
Target Milestone: Firefox5 → Firefox 5
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.