633788 - "closing last tab" inconsistency between main browser window and panorama

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect, P2)

Description

[florian.neubauer.neuroscience]

User-Agent:       Mozilla/5.0 (Windows NT 6.0; rv:2.0b11) Gecko/20100101 Firefox/4.0b11
Build Identifier: Mozilla/5.0 (Windows NT 6.0; rv:2.0b11) Gecko/20100101 Firefox/4.0b11

In the main window the last tab cannot be closed. In panorama the last tab can be closed and the browser closes quite unexpectedly. Behavior of main window should copied over to panorama.

Reproducible: Always

Steps to Reproduce:
1. Try to close last tab in main browser window --> not possible.
2. Try to close last tab in panorama --> possible, and browser closes.

Actual Results:  
browser closes after closing last tab in panorama

Expected Results:  
last tab cannot be closed, as in main window of the browser

Between FF4-beta-9 and beta-11 there was progress towards more consistency between the main window and panorama. E.g. the last tab group cannot be closed in panorama anymore. In this spirit you should stick with the design decision made for the main browser window: One cannot close the last tab. Just copy this decision over 1:1 to panorama and make it impossible to close the last tab. Then the surprising and unexpected event does not happen anymore that the browser closes after closing the last tab.

Comment 1

[florian.neubauer.neuroscience]

Implementing this behavior in panorama would have a very positive side effect: If the last tab cannot be closed, you do not need to handle the case anymore what should happen if the last tab group is closed - because it simply could not be closed anymore either. Just as it is already implemented for the case that there are app tabs open. In turn, if you stick with the current decision for the case that there are no app tabs open, which means, that the last tab group actually can be closed and this action ends with an empty tab in the main window, then - again for consistency - closing the last group also should be possible in the case that there are app tabs present, in this case one of the app tabs could be the tab you land in, or - for consistency - an empty tab next to the app tabs. However, I really think that not being able to close the last tab group and not being able to close the last tab whether there are app tabs or not would be the most consistent solution.

Comment 2

[Kevin Hanes]

This is a regression.

Comment 3

[Ian Gilman [:iangilman]]

Up until recently (I suppose), Panorama would put you into a new blank tab if you closed the last tab. I propose we fix whatever broke that, in the Fx4 time frame. Post Fx4 we can consider the additional UX suggestions in this bug.

Comment 4

[Raymond Lee [:raymondlee]]

Attachment: v1

Comment 5

[Raymond Lee [:raymondlee]]

Attachment: v1

Uploaded a wrong patch

Comment 6

[Ian Gilman [:iangilman]]

Comment on attachment 513398 [details] [diff] [review]
v1

Looks good, except I think the new tab should go into the closing tab's parent group (if any, otherwise use the logic you have).

Comment 7

[Raymond Lee [:raymondlee]]

Attachment: v2

Comment 8

[Raymond Lee [:raymondlee]]

Comment on attachment 513754 [details] [diff] [review]
v2

Passed try

http://tbpl.mozilla.org/?tree=MozillaTry&rev=8f1ff63d4c47

Comment 9

[Ian Gilman [:iangilman]]

Comment on attachment 513754 [details] [diff] [review]
v2

Thanks!

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 513754 [details] [diff] [review]
v2

a=beltzner

Comment 11

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch for checkin

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

http://hg.mozilla.org/mozilla-central/rev/9fad1f22f556

Comment 13

[George Carstoiu]

Mozilla/5.0 (X11; Linux i686; rv:2.0b13pre) Gecko/20110224 Firefox/4.0b13pre

Verified issue and it's no longer present in latest build.