633816 - Exiting Fullscreen Panorama will break tabs in titlebar

Status: RESOLVED WONTFIX

(Firefox Graveyard :: Panorama, defect, P2)

Description

[Tan Wei Lin Jason [:Ryuji]]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b12pre) Gecko/20110205 Firefox/4.0b12pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b12pre) Gecko/20110205 Firefox/4.0b12pre

perform STR 

Reproducible: Always

Steps to Reproduce:
1. Enter Panorama
2. Fullscreen by pressing F11
3. press to focus on a tab in a tab group
4. it is still in fullscreen
5. exit fullscreen 
6. You will realised that tabs are no longer in the titlebar

Comment 1

[aravindm]

Mozilla/5.0 (Windows NT 6.1; rv:2.0b12pre) Gecko/20110212 Firefox/4.0b12pre

Confirmed. Tabs are not longer in the title bar after exiting full screen.

Comment 2

[AndreiD[QA]]

Mozilla/5.0 (Windows NT 6.1; rv:2.0b12pre) Gecko/20110215 Firefox/4.0b12pre

Works For Me. STRs unclear

Comment 3

[Kevin Hanes]

Jason, Aravidnm: are you still getting this?

Comment 4

[juan becerra [:juanb]]

I can confirm the problem on the latest Minefield and Win 7. What you should be looking for is where the tab appears in relation to the Firefox/Minefield button. In a normal start, tabs will appear on the same horizontal line (more or less) as the Firefox button, but if you follow the steps in comment #0, the tabs will appear below this line. So you end up having some extra space between tabs and title bar.

Restarting the browser will bring it back to normal.

Comment 5

[Tan Wei Lin Jason [:Ryuji]]

Yes... 

Clearer STR  
1. Enter Panorama View from Normal Firefox browsing
2. Press F11 in Panorama View to enter full screen
3. Press One tab in any of your Panorama group
4. you will realise that it is still full screen in the tab that you have focused on. 
5. exit the full screen mode by pressing F11
6. you will realise that the tabs are no longer in the titlebar.

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

The problem is: when switching to non-fullscreen-mode after returning from panorama the "sizemode" critieria for TabsInTitleBar.allowedBy() does not change its value and therefore doesn't fire TabsInTitleBar._update().

I implemented another "fullscreen" criteria that is handled in Fullscreen.toggle()

Another possibility would have been to change http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#5021 to:

TabsInTitlebar.allowedBy("sizemode", sizemode == "maximized");

and http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#5061 to:

if (!this._initialized)

Unfortunately this seems to fire too early so gNavToolbox's margin-bottom is not calculated correctly.

Comment 7

[Michael Yoshitaka Erlewine [:mitcho]]

[bugspam: betaN -> final]

Should get fixed by patch for bug 626976, which has been set to final. So it's totally up to that bug's fate. If we punt on that one, we punt on this too, though.

Comment 8

[Michael Yoshitaka Erlewine [:mitcho]]

Punting, as per IRC discussion with Tim.

Comment 9

[Kevin Hanes]

bugspam

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

bugspam

Comment 11

[Tim Taubert [:ttaubert] (inactive)]

bugspam

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

bugspam

(Fx7 was branched, removing open bugs from Fx7 meta bug, we won't create new meta bugs for upcoming Fx versions)

Comment 13

[Justin Dolske [:Dolske]]

Panorama has been removed from Firefox 45, currently in Beta and scheduled for release on March 7th. As such, I'm closing all existing Panorama bugs.

If you are still using Panorama, you will see a deprecation message in Firefox 44, and when 45 is released your tab group data will be migrated to bookmarks, with a folder for each group. There are also a few addons offering similar functionality.

See https://support.mozilla.org/en-US/kb/tab-groups-removal for more info.

We're removing Panorama because it has extremely low usage (about 0.01% of users), and has a large number of bugs and usability issues. The cost of fixing all those issues is far too high to justify, and so we'll instead be focusing our time and energy on improving other parts of Firefox.