Closed
Bug 635495
Opened 14 years ago
Closed 14 years ago
"Backspace" key should not navigate back on Android
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 4.0
People
(Reporter: mbrubeck, Unassigned)
Details
(Whiteboard: [has-patch])
Attachments
(1 file)
|
946 bytes,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Android has its own back key, so there's no need to overload the backspace button to navigate back/forward. It can easily be triggered by accident if the user thinks a form field is focused, but ends up navigating instead. We've also suffered multiple bugs where the action is triggered even when a form field should be focused (bug 611592, bug 627849).
Attachment #513749 -
Flags: review?(mark.finkle)
Comment 1•14 years ago
|
||
Comment on attachment 513749 [details] [diff] [review]
patch
This seems pretty reasonable to me. I would even start to think about removing the shortcut entirely, not just for Android.
Attachment #513749 -
Flags: review?(mark.finkle) → review+
| Reporter | ||
Comment 2•14 years ago
|
||
(In reply to comment #1)
> This seems pretty reasonable to me. I would even start to think about removing
> the shortcut entirely, not just for Android.
I find it very useful on N900, so I'd hope to keep it there if possible.
Pushed:
http://hg.mozilla.org/mobile-browser/rev/63257706389b
| Reporter | ||
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → fennec2.0
Comment 3•14 years ago
|
||
VERIFIED FIXED on:
Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b13pre) Gecko/20110317 Firefox/4.0b13pre Fennec /4.0b6pre
Device: Motorola Droid 2 (Android 2.2)
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•