636176 - Sync should not sync general.autoScroll

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Philip Chee]

(NB: Beltzner said to file a bug and CC philIKON)

<http://mxr.mozilla.org/comm-central/search?string=general.autoScroll>
<http://mxr.mozilla.org/comm-central/source/mozilla/browser/app/profile/firefox.js#227>
<http://mxr.mozilla.org/comm-central/source/suite/browser/browser-prefs.js#762>

The default for general.autoScroll is different on *nix.

Suggestion: Sync should not sync general.autoScroll

Reason: unexpected platform behaviour if the user has set up sync on
Linux as well as a Mac.

I'm picking Firefox::Preferences since this isn't SyncUI nor Sync::Backend.

Comment 1

[Philipp von Weitershausen [:philikon]]

(In reply to comment #0)
> The default for general.autoScroll is different on *nix.

Sigh I wish we had done bug 582536.

> Suggestion: Sync should not sync general.autoScroll
> 
> Reason: unexpected platform behaviour if the user has set up sync on
> Linux as well as a Mac.

Fair enough. Care to round up a patch?

> I'm picking Firefox::Preferences since this isn't SyncUI nor Sync::Backend.

Correct.

Comment 2

[Steve Wendt]

(In reply to comment #1)
> Sigh I wish we had done bug 582536.

That seems like the best fix...

Comment 3

[Philipp von Weitershausen [:philikon]]

(In reply to comment #2)
> (In reply to comment #1)
> > Sigh I wish we had done bug 582536.
> 
> That seems like the best fix...

Maybe. It's not trivial to do, though, whereas not whitelisting general.autoScroll is a pretty trivial patch.

Comment 4

[Philip Chee]

So should I fix this in mozilla-central or in fx-sync or in both repositories?

Comment 5

[Philip Chee]

Attachment: Patch Fx1.0 Firefox patch.

Picking a reviewer at random.

Comment 7

[Philip Chee]

Comment on attachment 514757 [details] [diff] [review]
Patch Fx1.0 Firefox patch.

Not a blocker but nice to have paper-cut stuff.
Risk. None that I can see.
Gain. Reduced load on Firefox support having to answer additional questions from confused users.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 514757 [details] [diff] [review]
Patch Fx1.0 Firefox patch.

a=beltzner

Comment 9

[Philipp von Weitershausen [:philikon]]

Pushed to s-c: http://hg.mozilla.org/services/services-central/rev/d7961dc7e5f4
Will merge to m-c shortly

Comment 10

[Philipp von Weitershausen [:philikon]]

Landed the equivalent in fx-sync for the add-on (Firefox 3.5/3.6): https://hg.mozilla.org/services/fx-sync/rev/4cee17375a8d

Comment 11

[Philipp von Weitershausen [:philikon]]

Merged to m-c: http://hg.mozilla.org/mozilla-central/rev/d7961dc7e5f4