636463 - Language list doesn't scroll up/down in Preferences

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ioana Chiorean]

Attachment: screenshot

Build id : Mozilla/5.0 (Maemo;Linux armv7l;rv:2.0b12pre)Gecko/20110224
Firefox/4.0b12pre Fennec /4.0b6pre
Device: Sony Ericsson Xperia X10
OS: Android 2.1 update 1

Steps to reproduce:
1. Open Fennec app
2. Tap on device Settings button > Preferences
3. Tap on Language button
4. Scroll up/down the list

Expected result:
- The language list will scroll up/down if its length oversize the device screen display.

Actual result:
- The language list doesn't scroll at all. Above the "Auto-detect" entry there is an empty cell in the list.

Note:
- please see screenshot

Comment 1

[Ioana Chiorean]

Attachment: alogcat file

Comment 2

[Matt Brubeck (:mbrubeck)]

This is similar to an old bug 606492.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Vivien touched the code that handles displaying the <select> ui, which also drives the <menulist> ui

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

regression from bug 622578

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #3)
> Vivien touched the code that handles displaying the <select> ui, which also
> drives the <menulist> ui

I will fix that soon.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

14:29 <@mfinkle> vingtetun, ping
14:30 < vingtetun> mfinkle: pong
14:30 <@mfinkle> bug 636463
14:30 < vingtetun> yep
14:31 <@mfinkle> there are 2 <label id="menulist-title"
14:31 <@mfinkle> ?
14:31 < vingtetun> ...
14:31 <@mfinkle> <label id="menulist-title" ... flex="0"
14:31 < vingtetun> how could i have missed that...
14:31 <@mfinkle> <label id="menulist-title" ... flex="1"

shame...

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/5d257f348005

Comment 9

[Ioana Chiorean]

the scroll works fine now. 

Build id : Mozilla/5.0 (Android ;Linux armv7l;rv:2.0b13pre)Gecko/20110228
Firefox/4.0b13pre Fennec /4.0b6pre

but now the selection is made at every touch of the list.. Is this change intended or is a new bug?

Comment 10

[Matt Brubeck (:mbrubeck)]

(In reply to comment #9)
> but now the selection is made at every touch of the list.. Is this change
> intended or is a new bug?

I think this will be fixed by bug 637215.

Comment 11

[Matt Brubeck (:mbrubeck)]

(In reply to comment #10)
> (In reply to comment #9)
> > but now the selection is made at every touch of the list.. Is this change
> > intended or is a new bug?
> 
> I think this will be fixed by bug 637215.

Confirmed - the selection changing on touch is fixed by bug 637215 which is already checked in.  (The fix will be in tomorrow's nightly.)