636589 - Add support for external embedded personas ads

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Public Pages, defect, P4)

Description

[Wil Clouser [:clouserw]]

Check out these pages:

http://www.mozilla.com/en-US/firefox/students/
http://www.mozilla.com/pa-IN/firefox/3.6/firstrun/

See those personas in the middle?  See how the hover-over previews work?  That's because those are iframes from getpersonas.  We want to add support for that feature on AMO.  That means we'll need URLs that give equivalent output to:

http://www.getpersonas.com/en-US/external/mozilla/
http://www.getpersonas.com/en-US/external/mozilla/firstrun.php
http://www.getpersonas.com/en-US/external/mozilla/students.php

Of course they are all slightly different...sigh.

This bug covers:

- frontend (see the css/js at the above URLs)
- backend (the add-ons shown come from collections; bug 635331 has more info.  If we need to create a special category or something, that's fine.  If you have questions, ask)
- all 3 output formats :(

Comment 1

[Deb Richardson [:dria] (plz NEEDINFO)]

If we can figure out where these are used, maybe we could replace these three things with a single version that is more flexible (ie: not a hardcoded image in the first, etc).

We replaced the second with the first on the Personas Plus firstrun page, I know, but I'm not sure if firstrun or students are used anywhere else right now.  Is there an easy way to figure that out?

Comment 2

[Wil Clouser [:clouserw]]

Note that there is a new URL in bug 666370 too.

Comment 3

[Steven Garrity [:sgarrity]]

It may give you some small amount of joy to learn that http://www.mozilla.com/en-US/firefox/students/ is no longer.

Comment 4

[Wil Clouser [:clouserw]]

Looks like firstrun pages are no longer featuring personas (eg. http://www.mozilla.org/pa-IN/firefox/10.0/firstrun/).

Deb - are these still needed?

Comment 5

[Matthew N. [:MattN]]

(In reply to Wil Clouser [:clouserw] from comment #4)
/external/ is still shown on https://www.mozilla.org/en-US/firefox/customize/ but previews are broken (bug 705512) until the next push to production of getpersonas.com .

Comment 6

[Wil Clouser [:clouserw]]

Thanks Matthew.  I think we're safe only doing the output equivalent of this URL then:

> http://www.getpersonas.com/en-US/external/mozilla/

Comment 7

[Mike Kaply [:mkaply]]

AMO does not support iframe embedding, so it's not just about building the page.

Comment 8

[Christopher Van Wiemeersch [:cvan]]

(In reply to Michael Kaply (mkaply) from comment #7)
> AMO does not support iframe embedding, so it's not just about building the
> page.

We can set `x-frame-options`.

Comment 9

[Mike Kaply [:mkaply]]

> We can set `x-frame-options`.

I think AMO prevents that on purpose.

Comment 10

[Christopher Van Wiemeersch [:cvan]]

(In reply to Michael Kaply (mkaply) from comment #9)
> > We can set `x-frame-options`.
> 
> I think AMO prevents that on purpose.

Yes we do. But we can make exceptions for particular pages such as this one.

Comment 11

[Christopher Van Wiemeersch [:cvan]]

http://www.mozilla.com/en-US/firefox/students/ seems defunct

http://www.mozilla.com/pa-IN/firefox/3.6/firstrun/ is still around

Is this something we still need? If so, show me where.

Comment 12

[Matthew N. [:MattN]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #11)
> http://www.mozilla.com/pa-IN/firefox/3.6/firstrun/ is still around
> 
> Is this something we still need? If so, show me where.

This is probably still shown in a new install of a pa-IN Firefox 3.6 install (from the pref startup.homepage_welcome_url).  Firefox 3.6 is no longer supported so it's probably fine to break but to be nice we could remove the iframe so an error page isn't shown.

Comment 13

[Wil Clouser [:clouserw]]

I'm comfortable wontfixing this.  Bug 795138 for the iframe.