Closed Bug 636692 Opened 9 years ago Closed 9 years ago

Remove the Hotmail-specific hack that forces the old parser for document.open()

Categories

(Core :: HTML: Parser, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Tracking Status
blocking2.0 --- final+

People

(Reporter: hsivonen, Assigned: hsivonen)

References

(Blocks 1 open bug)

Details

(Whiteboard: [hardblocker])

Attachments

(1 file)

The patch for bug 627729 is a Hotmail-specific code path that forces the use of the old HTML parser for document.open() on Hotmail.

Remove that code path once Hotmail has deployed a fix for the problem at their end.
The patch that added the workaround no longer reverses without rejections, so let's have a removal patch that's cleanly qimportable ready.
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Attachment #515853 - Flags: review?(bzbarsky)
Comment on attachment 515853 [details] [diff] [review]
Remove the Hotmail workaround

r=me
Attachment #515853 - Flags: review?(bzbarsky) → review+
Marking this bug as a final hardblocker and resolving bug 627729
blocking2.0: --- → final+
Whiteboard: [hardblocker][has patch][needs decision]
raul@live.com:  Please note that we are planning to ship RC with this exception unless we hear that Microsoft can fix in Hotmail in the next 24 hours.
Microsoft has contacted me and they are pushing a fix to hotmail today.  They asked that we not make an exception for Hotmail.  

Please stand by.
OK.  Talked more with Microsoft on the phone, and the plan is to remove the hack to force the old parser.  They are sending me info to test their changes in their
staging cluster.  I'll pass the info on to QA so we can verify.
Whiteboard: [hardblocker][has patch][needs decision] → [hardblocker][has patch][needs landing]
someone was going to land this ASAP, right?
on it
http://hg.mozilla.org/mozilla-central/rev/9ddd1f8658cf

This needs verification.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
(In reply to comment #9)
> http://hg.mozilla.org/mozilla-central/rev/9ddd1f8658cf
> 
> This needs verification.

CCing some QA folks.
Keywords: qawanted
Whiteboard: [hardblocker][has patch][needs landing] → [hardblocker]
On builds from a few days ago, prior to the html5 pref change, I see the problem using my personal account.

Using the latest hourly builds I don't see the problem where the page (individual mail) refreshes continuously using testing accounts provided by the Hotmail team, as well as a personal one.

However, the html5.hotmailworkaround pref didn't get removed, it's is still there and set to true. I'm pretty sure I'm using hourly builds with this fix, so is this expected?
Are you using an existing profile?
No, I used a new profile.
http://mxr.mozilla.org/mozilla-central/search?string=hotmail

Looks like we still have a bunch of workaround-related code in the tree. I will touch base with jst.
(In reply to comment #14)
> http://mxr.mozilla.org/mozilla-central/search?string=hotmail
> 
> Looks like we still have a bunch of workaround-related code in the tree. I will
> touch base with jst.

I think mxr cache tries to trick you.

hgweb is probably much more correct and this is nsHtml5Module.cpp on tip:
https://hg.mozilla.org/mozilla-central/file/716b7303beea/parser/html/nsHtml5Module.cpp

(according to your previous link, this file should have some hotmail workaround code)
in that case juan, you have to double check that you used the right build
(In reply to comment #16)
> in that case juan, you have to double check that you used the right build

FWIW, the pref has indeed been removed: <http://hg.mozilla.org/mozilla-central/rev/9ddd1f8658cf#l3.13>
Yep, I must have downloaded an hourly build without the change. The one from around 6pm today removes the pref entirely, whether I use an existing profile or not, and I re-tested with the testing accounts. It's working.
Verified fixed on today's nightlies:
Mozilla/5.0 (Windows NT 5.1; rv:2.0b13pre) Gecko/20110303 Firefox/4.0b13pre
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b13pre) Gecko/20110303 Firefox/4.0b13pre
Status: RESOLVED → VERIFIED
Keywords: qawanted
You need to log in before you can comment on or make changes to this bug.