636692 - Remove the Hotmail-specific hack that forces the old parser for document.open()

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Henri Sivonen (:hsivonen)]

The patch for bug 627729 is a Hotmail-specific code path that forces the use of the old HTML parser for document.open() on Hotmail.

Remove that code path once Hotmail has deployed a fix for the problem at their end.

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Remove the Hotmail workaround

The patch that added the workaround no longer reverses without rejections, so let's have a removal patch that's cleanly qimportable ready.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 515853 [details] [diff] [review]
Remove the Hotmail workaround

r=me

Comment 3

[Johnathan Nightingale [:johnath]]

Marking this bug as a final hardblocker and resolving bug 627729

Comment 4

[Damon Sicore (:damons)]

[e-mail]:  Please note that we are planning to ship RC with this exception unless we hear that Microsoft can fix in Hotmail in the next 24 hours.

Comment 5

[Damon Sicore (:damons)]

Microsoft has contacted me and they are pushing a fix to hotmail today.  They asked that we not make an exception for Hotmail.  

Please stand by.

Comment 6

[Damon Sicore (:damons)]

OK.  Talked more with Microsoft on the phone, and the plan is to remove the hack to force the old parser.  They are sending me info to test their changes in their
staging cluster.  I'll pass the info on to QA so we can verify.

Comment 7

[Asa Dotzler [:asa]]

someone was going to land this ASAP, right?

Comment 8

[Andreas Gal :gal]

on it

Comment 9

[Andreas Gal :gal]

http://hg.mozilla.org/mozilla-central/rev/9ddd1f8658cf

This needs verification.

Comment 10

[(no longer active)]

(In reply to comment #9)
> http://hg.mozilla.org/mozilla-central/rev/9ddd1f8658cf
> 
> This needs verification.

CCing some QA folks.

Comment 11

[juan becerra [:juanb]]

On builds from a few days ago, prior to the html5 pref change, I see the problem using my personal account.

Using the latest hourly builds I don't see the problem where the page (individual mail) refreshes continuously using testing accounts provided by the Hotmail team, as well as a personal one.

However, the html5.hotmailworkaround pref didn't get removed, it's is still there and set to true. I'm pretty sure I'm using hourly builds with this fix, so is this expected?

Comment 12

[Andreas Gal :gal]

Are you using an existing profile?

Comment 13

[juan becerra [:juanb]]

No, I used a new profile.

Comment 14

[Andreas Gal :gal]

http://mxr.mozilla.org/mozilla-central/search?string=hotmail

Looks like we still have a bunch of workaround-related code in the tree. I will touch base with jst.

Comment 15

[Mounir Lamouri (:mounir)]

(In reply to comment #14)
> http://mxr.mozilla.org/mozilla-central/search?string=hotmail
> 
> Looks like we still have a bunch of workaround-related code in the tree. I will
> touch base with jst.

I think mxr cache tries to trick you.

hgweb is probably much more correct and this is nsHtml5Module.cpp on tip:
https://hg.mozilla.org/mozilla-central/file/716b7303beea/parser/html/nsHtml5Module.cpp

(according to your previous link, this file should have some hotmail workaround code)

Comment 16

[Andreas Gal :gal]

in that case juan, you have to double check that you used the right build

Comment 17

[(no longer active)]

(In reply to comment #16)
> in that case juan, you have to double check that you used the right build

FWIW, the pref has indeed been removed: <http://hg.mozilla.org/mozilla-central/rev/9ddd1f8658cf#l3.13>

Comment 18

[juan becerra [:juanb]]

Yep, I must have downloaded an hourly build without the change. The one from around 6pm today removes the pref entirely, whether I use an existing profile or not, and I re-tested with the testing accounts. It's working.

Comment 19

[juan becerra [:juanb]]

Verified fixed on today's nightlies:
Mozilla/5.0 (Windows NT 5.1; rv:2.0b13pre) Gecko/20110303 Firefox/4.0b13pre
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b13pre) Gecko/20110303 Firefox/4.0b13pre