637126 - misspositioned tabbar arrow with only apptabs open

Status: RESOLVED WONTFIX

(Firefox Graveyard :: Panorama, defect, P3)

Description

[[e-mail]]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b12) Gecko/20100101 Firefox/4.0b12
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b12) Gecko/20100101 Firefox/4.0b12

When you drag a tab from another firefox window into one with only apptabs opened, the little arrow indicating the future tab position will appear mostleft in the window, before the apptabs

Reproducible: Always

Steps to Reproduce:
1.Transform all open tabs except of one into apptabs
2.drag the normal tab out of firefox to open him into a new window
3.now drag him back into the apptab-window, right to the apptabs.

Actual Results:  
the little arrow will appear left from the firefox-menubutton

Expected Results:  
arrow should be in the right of apptabs

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Can you reproduce that in safe mode with all add-ons disabled?

Comment 2

[[e-mail]]

yes

Comment 3

[AndreiD[QA]]

Works For Me: 
Mozilla/5.0 (Windows NT 6.1; rv:2.0b12) Gecko/20100101 Firefox/4.0b12

*Note: Can you attach some screenshots with the issue? Following the steps to reproduce did not result in any issue. The arrow appears where the user drags the tab to position it in the window with apptabs only

Comment 4

[[e-mail]]

There you are 
http://robhau.de/stuff/scrnsht.jpg

Comment 5

[AndreiD[QA]]

It looks like an important issue.
Can you reproduce it on a clean profile (with no history, bookmarks et cetera) or in safe mode?
http://support.mozilla.com/kb/Safe+Mode
http://support.mozilla.com/kb/Managing+profiles

Comment 6

[[e-mail]]

I tested it, the issue only appears when using TabCandy in main Window, doesnt matter whether the profile is clean or not.
Anyway its not such a bad bug, as long a the tab gets inserted correctly.
But  after all it should be fixed.

Comment 7

[AndreiD[QA]]

Reproduceable on:
Mozilla/5.0 (Windows NT 6.1; rv:2.0b12) Gecko/20100101 Firefox/4.0b12

And on:
Mozilla/5.0 (Windows NT 6.1; rv:2.0b13pre) Gecko/20110301 Firefox/4.0b13pre

*Notes: 
Here are more clear STRs, if needed:
1. With FFx open have at least 2 Groups (in Panorama) and 4 Apptabs available.
2. Focus on one of the groups 
3. Leave one single tab beside the Apptab, in that group
4. Drag that tab out to get another window
5. Try to drag and drop the tab back to the previous window (that was initially in), to the right of the apptab.

Expected result: the pointer arrow should be properly displayed.

Actual result: please refer to Comment 4 (see attachement)

Comment 8

[Kevin Hanes]

I can repro. That's really odd.

Comment 9

[Raymond Lee [:raymondlee]]

Attachment: v1

Comment 10

[Ian Gilman [:iangilman]]

Comment on attachment 516544 [details] [diff] [review]
v1

I'm sorry, I don't know enough about this code to give meaningful feedback.

Comment 11

[Kevin Hanes]

bugspam

Comment 12

[Raymond Lee [:raymondlee]]

Tested with latest trunk and this patch still works.  

Dao: please give some feedback on this when you have time.

Comment 13

[Tim Taubert [:ttaubert] (inactive)]

bugspam

Comment 14

[Tim Taubert [:ttaubert] (inactive)]

bugspam

Comment 15

[Tim Taubert [:ttaubert] (inactive)]

bugspam

(Fx7 was branched, removing open bugs from Fx7 meta bug, we won't create new meta bugs for upcoming Fx versions)

Comment 16

[Dão Gottwald [:dao]]

Comment on attachment 516544 [details] [diff] [review]
v1

Not sure what this patch does, other than using visibleTabs instead of childNodes. Seems like a larger refactoring that unfortunately makes the code harder to follow, which is why this was sitting in my review queue for ages (sorry). Needs some documentation.

Comment 17

[Justin Dolske [:Dolske]]

Panorama has been removed from Firefox 45, currently in Beta and scheduled for release on March 7th. As such, I'm closing all existing Panorama bugs.

If you are still using Panorama, you will see a deprecation message in Firefox 44, and when 45 is released your tab group data will be migrated to bookmarks, with a folder for each group. There are also a few addons offering similar functionality.

See https://support.mozilla.org/en-US/kb/tab-groups-removal for more info.

We're removing Panorama because it has extremely low usage (about 0.01% of users), and has a large number of bugs and usability issues. The cost of fixing all those issues is far too high to justify, and so we'll instead be focusing our time and energy on improving other parts of Firefox.