637337 - Website's title remains active during zoom in animation from stacked pile in Panorama

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect, P4)

Description

[George Carstoiu]

Mozilla/5.0 (X11; Linux i686; rv:2.0b13pre) Gecko/20110228 Firefox/4.0b13pre

When accessing a website from a stack pile in Panorama, the titles of the websites remain visible during the zoom in transition.

Reproducible:always

Steps to reproduce:
 1. Create a few tabs and access panorama
 2. Minimize group in order to obtain stack
 3. Press expand button
 4. Select one of the websites and observe transition (look after the website's title)

Actual results:
 - the title stays active during the transition

Expected results:
 - the title becomes inactive (is no longer visible) during the transition

Comment 1

[George Carstoiu]

Regression range:

Last good:
Mozilla/5.0 (X11; Linux i686; rv:2.0b11pre) Gecko/20110131 Firefox/4.0b11pre
http://hg.mozilla.org/mozilla-central/rev/ba3fe7ee56b9

First bad
Mozilla/5.0 (X11; Linux i686; rv:2.0b11pre) Gecko/20110201 Firefox/4.0b11pre
http://hg.mozilla.org/mozilla-central/rev/8b5cb26bbb10

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ba3fe7ee56b9&tochange=8b5cb26bbb10

Comment 2

[Kevin Hanes]

Good catch!

Comment 3

[Raymond Lee [:raymondlee]]

Attachment: v1

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 515860 [details] [diff] [review]
v1

Looks good!

Comment 5

[Ian Gilman [:iangilman]]

Comment on attachment 515860 [details] [diff] [review]
v1

Good polish

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 515860 [details] [diff] [review]
v1

Note to approvers:

This is a really small and safe patch that fixes an ugly graphics bug while zooming out of panorama.

Comment 7

[Ian Gilman [:iangilman]]

(In reply to comment #6)
> Comment on attachment 515860 [details] [diff] [review]
> v1
> 
> Note to approvers:
> 
> This is a really small and safe patch that fixes an ugly graphics bug while
> zooming out of panorama.

... which likely also gives a slight perf improvement (no longer drawing text during the zoom animation).

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 515860 [details] [diff] [review]
v1

Too late, we might consider it as a ride-along.

Comment 9

[Raymond Lee [:raymondlee]]

Sent it to try and waiting for the results.

Comment 10

[Raymond Lee [:raymondlee]]

(In reply to comment #9)
> Sent it to try and waiting for the results.

http://tbpl.mozilla.org/?tree=MozillaTry&rev=fd3c1afb78b2

Comment 11

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/c1959310eb55

Comment 12

[George Carstoiu]

Verified using Mozilla/5.0 (X11; Linux i686; rv:2.2a1pre) Gecko/20110404 Firefox/4.2a1pre

Comment 13

[Tim Taubert [:ttaubert] (inactive)]

bug spam