Closed Bug 637337 Opened 9 years ago Closed 9 years ago

Website's title remains active during zoom in animation from stacked pile in Panorama

Categories

(Firefox Graveyard :: Panorama, defect, P4, minor)

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 5

People

(Reporter: george.carstoiu, Assigned: raymondlee)

References

Details

Attachments

(1 file)

Mozilla/5.0 (X11; Linux i686; rv:2.0b13pre) Gecko/20110228 Firefox/4.0b13pre

When accessing a website from a stack pile in Panorama, the titles of the websites remain visible during the zoom in transition.

Reproducible:always

Steps to reproduce:
 1. Create a few tabs and access panorama
 2. Minimize group in order to obtain stack
 3. Press expand button
 4. Select one of the websites and observe transition (look after the website's title)

Actual results:
 - the title stays active during the transition

Expected results:
 - the title becomes inactive (is no longer visible) during the transition
Regression range:

Last good:
Mozilla/5.0 (X11; Linux i686; rv:2.0b11pre) Gecko/20110131 Firefox/4.0b11pre
http://hg.mozilla.org/mozilla-central/rev/ba3fe7ee56b9

First bad
Mozilla/5.0 (X11; Linux i686; rv:2.0b11pre) Gecko/20110201 Firefox/4.0b11pre
http://hg.mozilla.org/mozilla-central/rev/8b5cb26bbb10

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ba3fe7ee56b9&tochange=8b5cb26bbb10
Good catch!
Blocks: 585689
Priority: -- → P4
Assignee: nobody → raymond
Attached patch v1Splinter Review
Attachment #515860 - Flags: review?(ian)
Status: NEW → ASSIGNED
Comment on attachment 515860 [details] [diff] [review]
v1

Good polish
Attachment #515860 - Flags: review?(ian) → review+
Attachment #515860 - Flags: approval2.0?
Comment on attachment 515860 [details] [diff] [review]
v1

Note to approvers:

This is a really small and safe patch that fixes an ugly graphics bug while zooming out of panorama.
(In reply to comment #6)
> Comment on attachment 515860 [details] [diff] [review]
> v1
> 
> Note to approvers:
> 
> This is a really small and safe patch that fixes an ugly graphics bug while
> zooming out of panorama.

... which likely also gives a slight perf improvement (no longer drawing text during the zoom animation).
Comment on attachment 515860 [details] [diff] [review]
v1

Too late, we might consider it as a ride-along.
Attachment #515860 - Flags: approval2.0? → approval2.0-
Sent it to try and waiting for the results.
(In reply to comment #9)
> Sent it to try and waiting for the results.

http://tbpl.mozilla.org/?tree=MozillaTry&rev=fd3c1afb78b2
No longer blocks: 585689
http://hg.mozilla.org/mozilla-central/rev/c1959310eb55
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified using Mozilla/5.0 (X11; Linux i686; rv:2.2a1pre) Gecko/20110404 Firefox/4.2a1pre
Status: RESOLVED → VERIFIED
bug spam
Hardware: x86 → All
Target Milestone: --- → Firefox 5
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.