640342 - Archive granularity should be flat when using GMail

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Jim Porter (:squib)]

This was originally fixed in bug 475852 with a special check in BatchMessageMover, but bug 517514 inadvertently removed it. However, maybe we want to do this a little bit differently. One option would just be setting the archive_granularity pref on the first identity for the GMail account when it's created. This would allow people to change that if they really wanted. I'm not sure if that's a good thing or not.

Alternately, we could do it the same way as before, but this would mean that we'd probably want to check for Gmail servers and disable the archive options dialog in bug 607295, since changing those prefs wouldn't actually do anything.

Comment 1

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to comment #0)
> This was originally fixed in bug 475852 with a special check in
> BatchMessageMover, but bug 517514 inadvertently removed it. However, maybe we
> want to do this a little bit differently. One option would just be setting the
> archive_granularity pref on the first identity for the GMail account when it's
> created. This would allow people to change that if they really wanted. I'm not
> sure if that's a good thing or not.

This seems like the simplest route and allows people to choose a different scheme if they want it.  I was annoyed at first by the archive labels but have actually found them somewhat useful now and wonder if I'd turn it back on again.

Comment 2

[Jim Porter (:squib)]

Doing it that way would require some kind of migration code for people on 3.0/3.1, but that shouldn't be terribly complicated.

The other way (i.e. the way it was originally handled) is definitely simpler to code, but setting the pref shouldn't be too difficult. I'm not totally sure how setting the pref will interact with multiple identities though. (If there's no pref set, does it fall back to the first identity for the server, or to the global default identity?)

Comment 3

[Jim Porter (:squib)]

Taking this, since at worst, I can just do it the Easy Way.

Comment 4

[Jim Porter (:squib)]

Attachment: Re-add the code from bug 475852

Ok, I went with the easier way (just doing what bug 475852 originally did), and I hid the archive hierarchy button in the options for Gmail accounts. :Bienvenu, since you wrote the original patch, I flagged you for review. Thanks!

(Just setting the archive_granularity pref would be the smarter way to do this, but I'm a little worried about messing with pref-related stuff like that when we're getting close to release.)

Comment 5

[Jim Porter (:squib)]

Checked in: http://hg.mozilla.org/comm-central/rev/ff095e73f250