Closed
Bug 657446
Opened 13 years ago
Closed 13 years ago
Archive Options button in Copies & Folders should be hidden based on target, not source account
Categories
(Thunderbird :: Account Manager, defect)
Thunderbird
Account Manager
Tracking
(blocking-thunderbird5.0 beta2+, thunderbird5.0 beta2-fixed, thunderbird6 fixed)
RESOLVED
FIXED
Thunderbird 7.0
Tracking | Status | |
---|---|---|
blocking-thunderbird5.0 | --- | beta2+ |
thunderbird5.0 | --- | beta2-fixed |
thunderbird6 | --- | fixed |
People
(Reporter: rsx11m.pub, Assigned: squib)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
23.42 KB,
patch
|
standard8
:
review+
bwinton
:
ui-review+
standard8
:
approval-comm-aurora+
standard8
:
approval-thunderbird5.0+
|
Details | Diff | Splinter Review |
It appears that enforcing a flat archiving hierarchy when an account is a GMail IMAP server (thus not allowing subfolders of "All Mail" as the Archives folder) may hide or show the "Archive Options" in the wrong situations. Steps to reproduce: - create a GMail-IMAP account - go into Copies & Folders of GMail account, "Archive Options" is hidden - select "Archives folder in Local Folders" as target location - "Archive Options" remains hidden though Local Folders supports subfolders Thus, the "hidden" status is determined from the source server rather than the target server (using nsIImapIncomingServer.isGMailServer in bug 640342). The following situation may currently occur: - create a second (here: POP) account - in Copies & Folders, select the GMail account as target for archiving - close and reopen Account Settings from the context menu of the POP account - in Copies & Folders, "Account Options" is enabled though not supported As this example shows, it would make more sense to enable or disable the "Archive Options" dialog dynamically based on the selected target account.
Assignee | ||
Comment 1•13 years ago
|
||
Probably easy to do?
Assignee: nobody → squibblyflabbetydoo
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•13 years ago
|
||
This should fix it. I also cleaned up the code a bit here and there, since I had to modify those functions anyway. I may revisit this and clean up the code a bit more in another bug. I feel like there should be tests for this, but I have no idea how to go about doing so. Any ideas?
Attachment #532811 -
Flags: review?(dbienvenu)
Comment 4•13 years ago
|
||
(In reply to comment #3) > I feel like there should be tests for this, but I have no idea how to go > about doing so. Any ideas? It shouldn't be too hard to write a mozmill test for this - you can add an imap account programatically and set the isGMailServer property on the server (it's just a bool pref). You don't need to actually connect to the imap server to test this code, I don't think, or at least, some of it. If you run into difficulty with the code trying to do stuff with the imap server, you should be able to go into offline mode and mozmill is supposed to keep working (Services.io.offline = true);
Comment 5•13 years ago
|
||
Comment on attachment 532811 [details] [diff] [review] Disable the "Archive options" button when the selected folder is from a Gmail IMAP account seems to work fine. Now we're disabling instead of hiding the archive options button - is that intentional and OK withe Blake?
Attachment #532811 -
Flags: review?(dbienvenu) → review+
Assignee | ||
Comment 6•13 years ago
|
||
I've added tests. I'm asking for review again, since the tests seem a bit messy, and maybe there's a better way to do this...
Attachment #532811 -
Attachment is obsolete: true
Attachment #536017 -
Flags: review?(dbienvenu)
Assignee | ||
Comment 7•13 years ago
|
||
I think this might block 5.0... it's fairly bad for anyone with a Gmail account (which I'm guessing is a lot of people).
status-thunderbird5.0:
--- → ?
blocking-thunderbird5.0: --- → ?
status-thunderbird5.0:
? → ---
Comment 8•13 years ago
|
||
Comment on attachment 536017 [details] [diff] [review] Add tests I think showing and hiding the button would be more distracting than disabling and enabling it, given that it is very easy to change its state. So, given that, ui-r=me.
Attachment #536017 -
Flags: ui-review+
Comment 9•13 years ago
|
||
Comment on attachment 536017 [details] [diff] [review] Add tests r=me for the unit test part (David's already reviewed the code). Please land on comm-central and comm-miramar.
Attachment #536017 -
Flags: review?(dbienvenu)
Attachment #536017 -
Flags: review+
Attachment #536017 -
Flags: approval-thunderbird5.0+
Attachment #536017 -
Flags: approval-comm-aurora?
Assignee | ||
Comment 10•13 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/4272db0f51c6 http://hg.mozilla.org/releases/comm-miramar/rev/bd51eb62aa5b I'll leave this open to track pushing to aurora. Also: should there be a Thunderbird 5.0b2 milestone?
Target Milestone: --- → Thunderbird 5.0b1
Comment 11•13 years ago
|
||
Nope, milestone gets set to the trunk version, where it is fixed is tracked by the status flags. I'm using approval-comm-aurora to track these things which should be landed on comm-aurora.
blocking-thunderbird5.0: ? → beta2+
status-thunderbird5.0:
--- → beta2-fixed
Target Milestone: Thunderbird 5.0b1 → Thunderbird 7.0
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Attachment #536017 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Comment 12•13 years ago
|
||
Checked into aurora: http://hg.mozilla.org/releases/comm-aurora/rev/f36b60bb5ed1
status-thunderbird6:
--- → fixed
Comment 13•13 years ago
|
||
It seems to me that one would like to enable the "Archive Options" button even when using Gmail-IMAP, as long as one is NOT using the "[Gmail]/All Mail" folder to do the archiving. One would still like the option of archiving in year or month subfolders of the "Archive" folder, like Archive/2011. Even though Gmail represents such a folder as the label Archive-2011, not as a true sub-label, it still will be a separate Archive/2011 mbox file on the client's computer, so it should work just fine.
Assignee | ||
Comment 14•13 years ago
|
||
(In reply to comment #13) > It seems to me that one would like to enable the "Archive Options" button > even when using Gmail-IMAP, as long as one is NOT using the "[Gmail]/All > Mail" folder to do the archiving. One would still like the option of > archiving in year or month subfolders of the "Archive" folder, like > Archive/2011. Even though Gmail represents such a folder as the label > Archive-2011, not as a true sub-label, it still will be a separate > Archive/2011 mbox file on the client's computer, so it should work just fine. That's fair, but that's a different bug from this, as this was just about making the UI consistent with how the code already behaved.
Comment 15•11 years ago
|
||
I've been using ThunderBird (now 17.0.2) with the false option for over one year now: mail.server.server3.is_gmail;false As long as you do not subscribe to "All Mail" when first adding the Gmail account, the archive function should behave like non-Gmail IMAP mail providers. The other change I would suggest is if a user subscribes to "All Mail" a warning prompt that states that archiving options will be disabled if "All Mail" is checked.
Reporter | ||
Comment 16•11 years ago
|
||
This bug has been closed 18 months ago. Thus, please open a new bug report if you want your suggestions or concerns to be addressed (assuming that they haven't been filed yet).
Comment 17•11 years ago
|
||
Thank you, I found the issue I wanted to report: https://bugzilla.mozilla.org/show_bug.cgi?id=705491
You need to log in
before you can comment on or make changes to this bug.
Description
•