640592 - Bookmarking a web site in panorama displays a doorhanger

Status: RESOLVED WONTFIX

(Firefox Graveyard :: Panorama, defect, P3)

Description

[Florin Strugariu [:Bebe]]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0) Gecko/20100101 Firefox/4.0

When  we try to bookmark a page in panorama (with CTRL+D or Bookmarks->Bookmark this page... ) a doorhanger appears.

Reproducible: Always

Steps to Reproduce:
1. Open www.google.com
2. Go to panorama
3. Try to bookmark the web site

Actual Results:  
3. A doorhanger appears in the middle of the window 


Expected Results:  
3. A normal menu should be displayed without the doorhanger

Comment 1

[George Carstoiu]

Mozilla/5.0 (X11; Linux i686 on x86_64; rv:2.0b13pre) Gecko/20110310 Firefox/4.0b13pre

Confirming issue on Unbuntu 10.04. 

The doorhanger looks strange and out of place in panorama.

Comment 2

[juan becerra [:juanb]]

I can see this across OSs on the RC. I don't think this is an operation that will be commonly used while in Panorama, but it looks really awkward. http://grab.by/9oUd

Comment 3

[Kevin Hanes]

It should not be possible to bookmark from the Panorama UI any longer as bug 587276 has landed. 

Can anyone verify?

Comment 4

[u279076]

(In reply to comment #3)
> It should not be possible to bookmark from the Panorama UI any longer as bug
> 587276 has landed. 
> 
> Can anyone verify?

That was just landed today.  I can verify on tomorrow's nightly if you can wait.

Comment 5

[Raymond Lee [:raymondlee]]

(In reply to comment #4)
> (In reply to comment #3)
> > It should not be possible to bookmark from the Panorama UI any longer as bug
> > 587276 has landed. 
> > 
> > Can anyone verify?
> 
> That was just landed today.  I can verify on tomorrow's nightly if you can
> wait.


Bug 587276 only stops the keyboard shortcut to trigger the bookmark this feature. We still need to implement Bug 621795 to disable the menu items.

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

bugspam

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

bugspam

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

bugspam

(Fx7 was branched, removing open bugs from Fx7 meta bug, we won't create new meta bugs for upcoming Fx versions)

Comment 9

[Justin Dolske [:Dolske]]

Panorama has been removed from Firefox 45, currently in Beta and scheduled for release on March 7th. As such, I'm closing all existing Panorama bugs.

If you are still using Panorama, you will see a deprecation message in Firefox 44, and when 45 is released your tab group data will be migrated to bookmarks, with a folder for each group. There are also a few addons offering similar functionality.

See https://support.mozilla.org/en-US/kb/tab-groups-removal for more info.

We're removing Panorama because it has extremely low usage (about 0.01% of users), and has a large number of bugs and usability issues. The cost of fixing all those issues is far too high to justify, and so we'll instead be focusing our time and energy on improving other parts of Firefox.