640649 - Remove unused cmd_file

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Jim Porter (:squib)]

It seems that button_file and cmd_file are no longer used to do anything, but references to them still exist:

mail/base/content/messageWindow.js
733:      case "button_file":
734:      case "cmd_file":
869:      case "button_file":
870:      case "cmd_file":

mail/base/content/mailWindowOverlay.xul
113:    <command id="cmd_file" disabled="true"/>
288:  <command id="button_file"/>
1710:                   observes="button_file"

mail/base/content/mail3PaneWindowCommands.js
229:      case "button_file":
230:      case "cmd_file":
378:      case "button_file":
379:      case "cmd_file":

We should probably just get rid of them.

Comment 1

[Tobias (:Tobbi) Markus]

Attachment: v1

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 520565 [details] [diff] [review]
v1

Sorry for this, but contrary to comment 0, button_file *is* used - via that observes attribute.

Without it the file button (when customised onto the toolbar) would be enabled all the time.

Would you mind updating the patch to just do the cmd_file changes?

Comment 3

[Tobias (:Tobbi) Markus]

Attachment: v2

Version 2, taking only cmd_file into account

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 522261 [details] [diff] [review]
v2

Thanks for updating the patch. r=Standard8

Comment 5

[Mark Banner (:standard8)]

Thanks Tobias,

Checked in: http://hg.mozilla.org/comm-central/rev/a059ee27a2e5