Closed Bug 642810 Opened 13 years ago Closed 12 years ago

Last-edited filter select does not color/display when selected, if beyond initial scroll

Categories

(MailNews Core :: Filters, defect)

1.9.2 Branch
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: firstpeterfourten, Unassigned)

References

Details

(Whiteboard: [filter-mgmt])

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2.15) Gecko/20110303 Firefox/3.6.15 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9

If it's below the initially viewable scroll set, the last-edited filter is not visually marked as selected (e. g. with dark background) when it is selected. 

Reproducible: Always

Steps to Reproduce:
1. Open Message Filters.  Already have a list of several message filters in place, so many that there's a scroll bar on the right.
2. Scroll down.
3. Double click on one of the ones you had to scroll down to see, to edit it.  
4. Optionally edit the filter, then click OK (not cancel).
5. The filter you just edited remains in the filter list, surrounded by dotted lines, but it does not appear to be selected.
6. You can click on other filters to select them, and the selection is indicated by surrounding the filter row with dotted lines, filling it with navy blue, and changing the text to white. (In inactive focus, it's a grey background with no dotted lines, and black text).
Actual Results:  
When you click the last-edited filter, it is just surrounded by ded lines, and in inactive focus it looks like there's nothing selected at all.  You can select any other filter, jump around, select a range, and when the last-edited filter is part of the selection, its coloration remains the same as if it was not selected, and it's hard to tell if you've actually selected it (because it doesn't look like any other filter does when that other filter is "selected").

If you shift-select a range that includes the last-edited filter, the range is selected but the last-edited filter doesn't have the white text/navy background, and it LOOKS like the range just skips that filter (when in fact it is included, for the purposes of any actions). 

Expected Results:  
After editing a filter, it should appear selected (as do those in the top part of the list), and when selecting it after editing, it should appear selected in the same way as any other selected filter.  Being "last-edited" shouldn't matter.


You can change which filter demonstrates this behavior by editing a different filter, and only the last-edited filter shows it.  More properly, it affects the filter "last edited since the last time the Message Filters window was opened:" You can also close and re-open the Message Filters window to clear the status.

This bug only happens on the filter that are out of view (due to scroll) when the filters window initially loads.
The bug isn't there if you click Cancel after viewing the filter details, instead of OK. I think it is related to the re-rendering of the list when a filter is saved.
(In reply to comment #0)

> Actual Results:  
> When you click the last-edited filter, it is just surrounded by ded lines, 

*ded = dotted.  My computer's lag on keystrokes and mouse actions is getting a little ridiculous, especially now that I can type fast enough (typing speed hasn't changed) to overflow the buffer and see characters drop.
Component: Mail Window Front End → Filters
Product: Thunderbird → MailNews Core
QA Contact: front-end → filters
iirc I reproduced this, but I don't recall if I was reading this bug at the time, or a different one
Severity: normal → minor
Rimas, can you reproduce this?
Yes, I can. Last-edited filter that has to be scrolled to in the list does not look like selected when it is. Why are you asking me though? :)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Confirming on TB8, linux.
OS: Windows Vista → All
Hardware: x86 → All
Version: unspecified → 1.9.2 Branch
Whiteboard: [filter-mgmt]
Can anybody still see this in TB18? I can't now.
WFM
May have been fixed by bug 780473. Let's wait for more confirmations.
Whiteboard: [filter-mgmt] → [filter-mgmt][CLOSEME 2012-12-01]
Resolved per whiteboard and Comment 9
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WORKSFORME
Whiteboard: [filter-mgmt][CLOSEME 2012-12-01] → [filter-mgmt]
I still observe this in TB16, but will wait and see in TB18+.
I think the fix went into TB17 too (there is Aurora approval). It is not 100% but should fix most visible cases.
You need to log in before you can comment on or make changes to this bug.