Closed Bug 644743 Opened 9 years ago Closed 9 years ago

Remove the Windows CE code for accelerometer support

Categories

(Core :: DOM: Core & HTML, defect)

All
Windows CE
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

This code is not used, and it's confusing, so it should leave our tree.
Blocks: 614720
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #521612 - Flags: review?(jst)
OS: Mac OS X → Windows CE
Hardware: x86 → All
Attachment #521612 - Flags: review?(jst) → review+
http://hg.mozilla.org/mozilla-central/rev/5a964711c027
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
Apologies if I've misunderstood what cases the WINCE & WINCE_WINDOWS_MOBILE definitions cover, but the patch left a few of:

> #if !defined(WINCE) && !defined(WINCE_WINDOWS_MOBILE) // normal windows.

Since the #ifdef WINCE_WINDOWS_MOBILE cases have been removed; surely checking for the opposite is now redundant?

If so, want me to file a follow up?
(In reply to comment #3)
> Apologies if I've misunderstood what cases the WINCE & WINCE_WINDOWS_MOBILE
> definitions cover, but the patch left a few of:
> 
> > #if !defined(WINCE) && !defined(WINCE_WINDOWS_MOBILE) // normal windows.
> 
> Since the #ifdef WINCE_WINDOWS_MOBILE cases have been removed; surely checking
> for the opposite is now redundant?

I think so, yes.

> If so, want me to file a follow up?

Please do!
Depends on: 648508
Component: DOM: Mozilla Extensions → DOM
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.